All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 2/2] x86: edison: Add the rest of UARTs present on board
Date: Thu, 28 Feb 2019 16:45:59 +0200	[thread overview]
Message-ID: <20190228144559.GE9224@smile.fi.intel.com> (raw)
In-Reply-To: <20190228112957.GC9224@smile.fi.intel.com>

On Thu, Feb 28, 2019 at 01:29:57PM +0200, Andy Shevchenko wrote:
> On Thu, Feb 28, 2019 at 04:21:48PM +0800, Bin Meng wrote:
> > On Thu, Feb 28, 2019 at 4:12 PM Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > >
> > > Intel Edison has three UART ports, i.e.
> > >  port 0 - Bluetooth
> > >  port 1 - auxiliary, available for general purpose use
> > >  port 2 - debugging, usually console output is here
> > >
> > > Enable all of them for future use.
> > >
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > ---
> > >  arch/x86/dts/edison.dts | 18 ++++++++++++++++++
> > >  1 file changed, 18 insertions(+)
> > >
> > 
> > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> 
> Thanks, but please defer this series. It made a regression.

I found the root cause.

It's a regression in the

commit a61cbad78e67963944e7d719f0aee27b8aef6c02
Author: Simon Glass <sjg@chromium.org>
Date:   Fri Dec 28 14:23:10 2018 -0700

    dm: serial: Adjust serial_getinfo() to use proper API

I will send a fix soon.

This series is okay as long as future fix will be applied.

Should I make a fix as patch 1 in the series and resend as v3?

-- 
With Best Regards,
Andy Shevchenko

  reply	other threads:[~2019-02-28 14:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-28  8:10 [U-Boot] [PATCH v2 1/2] x86: edison: Use proper number of serial interface Andy Shevchenko
2019-02-28  8:10 ` [U-Boot] [PATCH v2 2/2] x86: edison: Add the rest of UARTs present on board Andy Shevchenko
2019-02-28  8:21   ` Bin Meng
2019-02-28 11:29     ` Andy Shevchenko
2019-02-28 14:45       ` Andy Shevchenko [this message]
2019-03-04  6:24     ` Bin Meng
2019-03-04  6:24 ` [U-Boot] [PATCH v2 1/2] x86: edison: Use proper number of serial interface Bin Meng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190228144559.GE9224@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.