From: Alice Michael <alice.michael@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [next PATCH S3 3/9] i40e: remove error msg when vf with port vlan tries to remove vlan 0
Date: Thu, 28 Feb 2019 09:52:49 -0800 [thread overview]
Message-ID: <20190228175255.54754-3-alice.michael@intel.com> (raw)
In-Reply-To: <20190228175255.54754-1-alice.michael@intel.com>
From: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
VF's attempt to delete vlan 0 when a port vlan is configured is harmless
in this case pf driver just does nothing. If vf will try to remove
other vlans when a port vlan is configured it will still produce error
as before.
Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
---
drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
index 71cd159e7902..24628de8e624 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
@@ -2766,7 +2766,8 @@ static int i40e_vc_remove_vlan_msg(struct i40e_vf *vf, u8 *msg)
vsi = pf->vsi[vf->lan_vsi_idx];
if (vsi->info.pvid) {
- aq_ret = I40E_ERR_PARAM;
+ if (vfl->num_elements > 1 || vfl->vlan_id[0])
+ aq_ret = I40E_ERR_PARAM;
goto error_param;
}
--
2.19.2
next prev parent reply other threads:[~2019-02-28 17:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 17:52 [Intel-wired-lan] [next PATCH S3 1/9] i40e: Fix for allowing too many MDD events on VF Alice Michael
2019-02-28 17:52 ` [Intel-wired-lan] [next PATCH S3 2/9] i40e: change behavior on PF in response to MDD event Alice Michael
2019-03-02 0:22 ` Bowers, AndrewX
2019-02-28 17:52 ` Alice Michael [this message]
2019-02-28 17:57 ` [Intel-wired-lan] [next PATCH S3 3/9] i40e: remove error msg when vf with port vlan tries to remove vlan 0 Loktionov, Aleksandr
2019-03-02 0:22 ` Bowers, AndrewX
2019-02-28 17:52 ` [Intel-wired-lan] [next PATCH S3 4/9] i40e: ShadowRAM checksum calculation change Alice Michael
2019-03-02 0:23 ` Bowers, AndrewX
2019-02-28 17:52 ` [Intel-wired-lan] [next PATCH S3 5/9] i40e: Report advertised link modes on 40GBase_LR4, CR4 and fibre Alice Michael
2019-03-02 0:23 ` Bowers, AndrewX
2019-03-04 9:11 ` Ludkiewicz, Adam
2019-02-28 17:52 ` [Intel-wired-lan] [next PATCH S3 6/9] i40e: Further implementation of LLDP Alice Michael
2019-02-28 17:56 ` Loktionov, Aleksandr
2019-03-02 0:24 ` Bowers, AndrewX
2019-02-28 17:52 ` [Intel-wired-lan] [next PATCH S3 7/9] i40e: remove out-of-range comparisions in i40e_validate_cloud_filter Alice Michael
2019-03-02 0:24 ` Bowers, AndrewX
2019-02-28 17:52 ` [Intel-wired-lan] [next PATCH S3 8/9] i40e: update version number Alice Michael
2019-03-02 0:25 ` Bowers, AndrewX
2019-02-28 17:52 ` [Intel-wired-lan] [next PATCH S3 9/9] i40e: fix misleading message about promisc setting on un-trusted VF Alice Michael
2019-03-02 0:26 ` Bowers, AndrewX
2019-03-02 0:21 ` [Intel-wired-lan] [next PATCH S3 1/9] i40e: Fix for allowing too many MDD events on VF Bowers, AndrewX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190228175255.54754-3-alice.michael@intel.com \
--to=alice.michael@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.