From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [CI, v3, 1/2] drm/i915: Prevent a race during I915_GEM_MMAP ioctl with WC set Date: Thu, 28 Feb 2019 11:12:49 -0800 Message-ID: <20190228191249.GA10430@roeck-us.net> References: <20190207085454.10598-1-joonas.lahtinen@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pf1-x441.google.com (mail-pf1-x441.google.com [IPv6:2607:f8b0:4864:20::441]) by gabe.freedesktop.org (Postfix) with ESMTPS id 389576E230 for ; Thu, 28 Feb 2019 19:12:51 +0000 (UTC) Received: by mail-pf1-x441.google.com with SMTP id i19so10188131pfd.0 for ; Thu, 28 Feb 2019 11:12:51 -0800 (PST) Content-Disposition: inline In-Reply-To: <20190207085454.10598-1-joonas.lahtinen@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Joonas Lahtinen Cc: Intel graphics driver community testing & development List-Id: intel-gfx@lists.freedesktop.org SGksCgpPbiBUaHUsIEZlYiAwNywgMjAxOSBhdCAxMDo1NDo1M0FNICswMjAwLCBKb29uYXMgTGFo dGluZW4gd3JvdGU6Cj4gTWFrZSBzdXJlIHRoZSB1bmRlcmx5aW5nIFZNQSBpbiB0aGUgcHJvY2Vz cyBhZGRyZXNzIHNwYWNlIGlzIHRoZQo+IHNhbWUgYXMgaXQgd2FzIGR1cmluZyB2bV9tbWFwIHRv IGF2b2lkIGFwcGx5aW5nIFdDIHRvIHdyb25nIFZNQS4KPiAKPiBBIG1vcmUgbG9uZy10ZXJtIHNv bHV0aW9uIHdvdWxkIGJlIHRvIGhhdmUgdm1fbW1hcF9sb2NrZWQgdmFyaWFudAo+IGluIGxpbnV4 L21tYXAuaCBmb3Igd2hlbiBjYWxsZXIgd2FudHMgdG8gaG9sZCBtbWFwX3NlbSBmb3IgYW4KPiBl eHRlbmRlZCBkdXJhdGlvbi4KPiAKCkl0IHNlZW1zIGxpa2Ugd2UgbWF5IGhhdmUgYSByZWdyZXNz aW9uIGR1ZSB0byB0aGlzIHBhdGNoLiBJIGFtIHN0aWxsCmRlYnVnZ2luZywgYnV0IEkgaGF2ZSBh IHF1ZXN0aW9uOyBwbGVhc2Ugc2VlIGJlbG93LgoKVGhhbmtzLApHdWVudGVyCgo+IHYyOgo+IC0g UmVmYWN0b3IgdGhlIGNvbXBhcmUgZnVuY3Rpb24KPiAKPiBGaXhlczogMTgxNmY5MjM2MzAzICgi ZHJtL2k5MTU6IFN1cHBvcnQgY3JlYXRpb24gb2YgdW5ib3VuZCB3YyB1c2VyIG1hcHBpbmdzIGZv ciBvYmplY3RzIikKPiBSZXBvcnRlZC1ieTogQWRhbSBaYWJyb2NraSA8YWRhbXphQG1pY3Jvc29m dC5jb20+Cj4gU3VnZ2VzdGVkLWJ5OiBMaW51cyBUb3J2YWxkcyA8dG9ydmFsZHNAbGludXgtZm91 bmRhdGlvbi5vcmc+Cj4gU2lnbmVkLW9mZi1ieTogSm9vbmFzIExhaHRpbmVuIDxqb29uYXMubGFo dGluZW5AbGludXguaW50ZWwuY29tPgo+IENjOiA8c3RhYmxlQHZnZXIua2VybmVsLm9yZz4gIyB2 NC4wKwo+IENjOiBBa2FzaCBHb2VsIDxha2FzaC5nb2VsQGludGVsLmNvbT4KPiBDYzogQ2hyaXMg V2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gQ2M6IFR2cnRrbyBVcnN1bGluIDx0 dnJ0a28udXJzdWxpbkBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IEFkYW0gWmFicm9ja2kgPGFkYW16 YUBtaWNyb3NvZnQuY29tPgo+IFJldmlld2VkLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlz LXdpbHNvbi5jby51az4KPiBSZXZpZXdlZC1ieTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1 bGluQGludGVsLmNvbT4gI3YxCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2Vt LmMgfCAxMiArKysrKysrKysrKy0KPiAgMSBmaWxlIGNoYW5nZWQsIDExIGluc2VydGlvbnMoKyks IDEgZGVsZXRpb24oLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9nZW0uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiBpbmRleCAwNWNlOTE3 NmFjNGUuLjUyNjM5Zjc0OTkwOCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X2dlbS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+IEBAIC0x NjgxLDYgKzE2ODEsMTYgQEAgaTkxNV9nZW1fc3dfZmluaXNoX2lvY3RsKHN0cnVjdCBkcm1fZGV2 aWNlICpkZXYsIHZvaWQgKmRhdGEsCj4gIAlyZXR1cm4gMDsKPiAgfQo+ICAKPiArc3RhdGljIGlu bGluZSBib29sCj4gK19fdm1hX21hdGNoZXMoc3RydWN0IHZtX2FyZWFfc3RydWN0ICp2bWEsIHN0 cnVjdCBmaWxlICpmaWxwLAo+ICsJICAgICAgdW5zaWduZWQgbG9uZyBhZGRyLCB1bnNpZ25lZCBs b25nIHNpemUpCj4gK3sKPiArCWlmICh2bWEtPnZtX2ZpbGUgIT0gZmlscCkKPiArCQlyZXR1cm4g ZmFsc2U7Cj4gKwo+ICsJcmV0dXJuIHZtYS0+dm1fc3RhcnQgPT0gYWRkciAmJiAodm1hLT52bV9l bmQgLSB2bWEtPnZtX3N0YXJ0KSA9PSBzaXplOwoKU2hvdWxkbid0IHRoaXMgYmU6CglyZXR1cm4g dm1hLT52bV9zdGFydCA9PSBhZGRyICYmICh2bWEtPnZtX2VuZCAtIHZtYS0+dm1fc3RhcnQgKyAx KSA9PSBzaXplOwppbnN0ZWFkID8KCj4gK30KPiArCj4gIC8qKgo+ICAgKiBpOTE1X2dlbV9tbWFw X2lvY3RsIC0gTWFwcyB0aGUgY29udGVudHMgb2YgYW4gb2JqZWN0LCByZXR1cm5pbmcgdGhlIGFk ZHJlc3MKPiAgICoJCQkgaXQgaXMgbWFwcGVkIHRvLgo+IEBAIC0xNzM5LDcgKzE3NDksNyBAQCBp OTE1X2dlbV9tbWFwX2lvY3RsKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHZvaWQgKmRhdGEsCj4g IAkJCXJldHVybiAtRUlOVFI7Cj4gIAkJfQo+ICAJCXZtYSA9IGZpbmRfdm1hKG1tLCBhZGRyKTsK PiAtCQlpZiAodm1hKQo+ICsJCWlmICh2bWEgJiYgX192bWFfbWF0Y2hlcyh2bWEsIG9iai0+YmFz ZS5maWxwLCBhZGRyLCBhcmdzLT5zaXplKSkKPiAgCQkJdm1hLT52bV9wYWdlX3Byb3QgPQo+ICAJ CQkJcGdwcm90X3dyaXRlY29tYmluZSh2bV9nZXRfcGFnZV9wcm90KHZtYS0+dm1fZmxhZ3MpKTsK PiAgCQllbHNlCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA==