From: Alexey Dobriyan <adobriyan@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, yamada.masahiro@socionext.com,
wang.bo116@zte.com.cn, wdjjwb@163.com
Subject: Re: + include-linux-typesh-use-unsigned-int-instead-of-unsigned.patch added to -mm tree
Date: Fri, 1 Mar 2019 00:11:26 +0300 [thread overview]
Message-ID: <20190228211126.GA28901@avx2> (raw)
In-Reply-To: <20190228174109.MrWZN%akpm@linux-foundation.org>
On Thu, Feb 28, 2019 at 09:41:09AM -0800, akpm@linux-foundation.org wrote:
> --- a/include/linux/types.h~include-linux-typesh-use-unsigned-int-instead-of-unsigned
> +++ a/include/linux/types.h
> @@ -155,9 +155,9 @@ typedef u64 dma_addr_t;
> typedef u32 dma_addr_t;
> #endif
>
> -typedef unsigned __bitwise gfp_t;
> -typedef unsigned __bitwise slab_flags_t;
> -typedef unsigned __bitwise fmode_t;
> +typedef unsigned int __bitwise gfp_t;
> +typedef unsigned int __bitwise slab_flags_t;
> +typedef unsigned int __bitwise fmode_t;
I don't know if this is desireable. Switching to "unsigned" is better:
1 less token and less 80 column pressure.
next parent reply other threads:[~2019-02-28 21:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190228174109.MrWZN%akpm@linux-foundation.org>
2019-02-28 21:11 ` Alexey Dobriyan [this message]
2019-03-01 0:13 ` + include-linux-typesh-use-unsigned-int-instead-of-unsigned.patch added to -mm tree Masahiro Yamada
2019-03-01 6:56 ` Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190228211126.GA28901@avx2 \
--to=adobriyan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wang.bo116@zte.com.cn \
--cc=wdjjwb@163.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.