From: Guenter Roeck <linux@roeck-us.net>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Intel graphics driver community testing & development
<intel-gfx@lists.freedesktop.org>
Subject: Re: [CI, v3, 1/2] drm/i915: Prevent a race during I915_GEM_MMAP ioctl with WC set
Date: Thu, 28 Feb 2019 14:27:35 -0800 [thread overview]
Message-ID: <20190228222735.GA18025@roeck-us.net> (raw)
In-Reply-To: <155139230746.5847.12709934432272887200@skylake-alporthouse-com>
On Thu, Feb 28, 2019 at 10:18:32PM +0000, Chris Wilson wrote:
>
> If you have userspace that is broken, we need to fix it. We can get away
> with quietly changing ABI only so long as nobody notices. It sounds like
> you have some userspace that will break if you updated the kernel; ergo
> we have a problem.
>
> We just need that as a clear statement so that we have the user impact
> recorded.
Yes, it does break our userspace code. I fixed the problem in our kernels
with the following patch:
- return vma->vm_start == addr && (vma->vm_end - vma->vm_start) == size;
+ return vma->vm_start == addr && (vma->vm_end - vma->vm_start) == roundup(size, PAGE_SIZE);
Guenter
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-02-28 22:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-07 8:54 [CI v3 1/2] drm/i915: Prevent a race during I915_GEM_MMAP ioctl with WC set Joonas Lahtinen
2019-02-07 8:54 ` [CI v3 2/2] drm/i915: Handle vm_mmap error " Joonas Lahtinen
2019-02-07 9:29 ` ✓ Fi.CI.BAT: success for series starting with [CI,v3,1/2] drm/i915: Prevent a race " Patchwork
2019-02-07 11:52 ` ✓ Fi.CI.IGT: " Patchwork
2019-02-28 19:12 ` [CI, v3, 1/2] " Guenter Roeck
2019-02-28 21:32 ` Guenter Roeck
2019-02-28 21:48 ` Chris Wilson
2019-02-28 21:57 ` Guenter Roeck
2019-02-28 22:01 ` Chris Wilson
2019-02-28 22:11 ` Guenter Roeck
2019-02-28 22:18 ` Chris Wilson
2019-02-28 22:27 ` Guenter Roeck [this message]
2019-02-28 22:34 ` Chris Wilson
2019-03-01 0:15 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190228222735.GA18025@roeck-us.net \
--to=linux@roeck-us.net \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.