From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [PATCH 1/2] drm/i915/icl: Default to Thread Group preemption for compute workloads Date: Thu, 28 Feb 2019 14:32:35 -0800 Message-ID: <20190228223235.GE2189@intel.com> References: <20190227155109.30993-1-michal.winiarski@intel.com> <20190228190254.GC2189@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 22EF089DFD for ; Thu, 28 Feb 2019 22:32:25 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190228190254.GC2189@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?utf-8?Q?Micha=C5=82?= Winiarski Cc: intel-gfx@lists.freedesktop.org, Anuj Phogat List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBGZWIgMjgsIDIwMTkgYXQgMTE6MDI6NTRBTSAtMDgwMCwgUm9kcmlnbyBWaXZpIHdy b3RlOgo+IE9uIFdlZCwgRmViIDI3LCAyMDE5IGF0IDA0OjUxOjA4UE0gKzAxMDAsIE1pY2hhxYIg V2luaWFyc2tpIHdyb3RlOgo+ID4gV2UgYXNzdW1lZCB0aGF0IHRoZSBkZWZhdWx0IHByZWVtcHRp b24gZ3JhbnVsYXJpdHkgaXMgZmluZSBmb3IgSUNMLgo+ID4gVW5mb3J0dW5hdGVseSwgaXQgdHVy bnMgb3V0IHRoYXQgc29tZSBkcml2ZXJzIGRvbid0IHN1cHBvcnQgbWlkLXRocmVhZAo+ID4gcHJl ZW1wdGlvbiBmb3IgY29tcHV0ZSB3b3JrbG9hZHMuCj4gPiBJZiBhIHdvcmtsb2FkIHRoYXQgZG9l c24ndCBzdXBwb3J0IG1pZC10aHJlYWQgcHJlZW1wdGlvbiBnZXRzIG1pZC10aHJlYWQKPiA+IHBy ZWVtcHRlZCwgd2UncmUgZ29pbmcgdG8gb2JzZXJ2ZSBhIEdQVSBoYW5nLgo+ID4gV2hpbGUgSSdt IGhlcmUsIGxldCdzIGFsc28gdXBkYXRlIHRoZSAid29ya2Fyb3VuZCIgbmFtaW5nLgo+ID4gCj4g PiBTaWduZWQtb2ZmLWJ5OiBNaWNoYcWCIFdpbmlhcnNraSA8bWljaGFsLndpbmlhcnNraUBpbnRl bC5jb20+Cj4gPiBDYzogQW51aiBQaG9nYXQgPGFudWoucGhvZ2F0QGludGVsLmNvbT4KPiA+IENj OiBKb29uYXMgTGFodGluZW4gPGpvb25hcy5sYWh0aW5lbkBsaW51eC5pbnRlbC5jb20+Cj4gPiBD YzogTWF0dCBSb3BlciA8bWF0dGhldy5kLnJvcGVyQGludGVsLmNvbT4KPiA+IENjOiBSYWZhZWwg QW50b2dub2xsaSA8cmFmYWVsLmFudG9nbm9sbGlAaW50ZWwuY29tPgo+ID4gLS0tCj4gPiAgZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfd29ya2Fyb3VuZHMuYyB8IDkgKysrKysrKy0tCj4gPiAg MSBmaWxlIGNoYW5nZWQsIDcgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPiA+IAo+ID4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3dvcmthcm91bmRzLmMgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF93b3JrYXJvdW5kcy5jCj4gPiBpbmRleCA3NDNjZjVi MDAxNTUuLmExOWUxYzAwNTJhNyAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX3dvcmthcm91bmRzLmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X3dvcmthcm91bmRzLmMKPiA+IEBAIC01NTUsNiArNTU1LDExIEBAIHN0YXRpYyB2b2lkIGljbF9j dHhfd29ya2Fyb3VuZHNfaW5pdChzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4gPiAg CQkJICAgR0VOMTBfQ0FDSEVfTU9ERV9TUywKPiA+ICAJCQkgICAwLCAvKiB3cml0ZS1vbmx5LCBz byBza2lwIHZhbGlkYXRpb24gKi8KPiA+ICAJCQkgICBfTUFTS0VEX0JJVF9FTkFCTEUoRkxPQVRf QkxFTkRfT1BUSU1JWkFUSU9OX0VOQUJMRSkpOwo+ID4gKwo+ID4gKwkvKiBXYURpc2FibGVHUEdQ VU1pZFRocmVhZFByZWVtcHRpb246aWNsICovCj4gCj4gQ291bGQgeW91IHBsZWFzZSBnaXZlIG1l IHNvbWUgaW50ZXJuYWwgcG9pbnRlcnMgdG8gdGhpcyBXQT8KPiBJIGNvdWxkbid0IGZpbmQgaXQg b24gYnNwZWMgbm9yIG9uIHdhZGIuCj4gCj4gPiArCVdBX1NFVF9GSUVMRF9NQVNLRUQoR0VOOF9D U19DSElDS0VOMSwKPiA+ICsJCQkgICAgR0VOOV9QUkVFTVBUX0dQR1BVX0xFVkVMX01BU0ssCj4g PiArCQkJICAgIEdFTjlfUFJFRU1QVF9HUEdQVV9USFJFQURfR1JPVVBfTEVWRUwpOwo+ID4gIH0K PiA+ICAKPiA+ICB2b2lkIGludGVsX2VuZ2luZV9pbml0X2N0eF93YShzdHJ1Y3QgaW50ZWxfZW5n aW5lX2NzICplbmdpbmUpCj4gPiBAQCAtMTE3MCw4ICsxMTc1LDggQEAgcmNzX2VuZ2luZV93YV9p bml0KHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSwgc3RydWN0IGk5MTVfd2FfbGlzdCAq d2FsKQo+ID4gIAkJCQkgICAgR0VON19ESVNBQkxFX1NBTVBMRVJfUFJFRkVUQ0gpOwo+ID4gIAl9 Cj4gPiAgCj4gPiAtCWlmIChJU19HRU4oaTkxNSwgOSkgfHwgSVNfQ0FOTk9OTEFLRShpOTE1KSkg ewo+ID4gLQkJLyogV2FFbmFibGVQcmVlbXB0aW9uR3JhbnVsYXJpdHlDb250cm9sQnlVTUQ6c2ts LGJ4dCxrYmwsY2ZsLGNubCAqLwo+IAo+IFBsZWFzZSBkb24ndCByZW1vdmUgdGhlIG9sZCBuYW1l IHRoYXQgaXMgc3RpbGwgcGFydCBvZiBvbGQKPiByZWZlcmVuY2VzLiBJZiB3ZSBoYXZlIGEgbmV3 IG5hbWUgZm9yIElDTCsgcGxlYXNlIGtlZXAgYm90aAo+IGhlcmUgb24gdGhlIGNvbW1lbnRzLgoK SSdtIHNvcnJ5IGZvciBteSBkZWxheWVkIHJlc3BvbnNlIG9uIGlyYywgSSBob3BlIHlvdSB0aGF0 IGFuc3dlcgpjYW1lIGluIHRpbWUgdG8gYXZvaWQgeW91ciByZXdvcmsuCgpJIGp1c3Qgbm90aWNl ZCB0aGF0IHRoaXMgbmFtZSBmb3IgZ2VuOS8xMCBwbGF0Zm9yc20gaXMgYWxyZWFkeSBpbnNpZGUK Z2VuOV93aGl0ZWxpc3RfYnVpbGQoKSBhbmQgdGhhdCBvbiBuZXh0IHBhdGNoIHlvdSByZS1pbnRy b2R1Y2UgdGhlIGljbApvbmUuLi4KCkFsc28gdGhhbmtzIGZvciBhbGwgdGhlIGV4cGxhbmF0aW9u cy4gSSBjaGVja2VkIGJpdHMgd2l0aCBzcGVjCmFuZCBldmVyeXRoaW5nIG1ha2VzIHNlbnNlIG5v dywgc286CgpSZXZpZXdlZC1ieTogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29t PgoKKFdoYXQgSScgd29uZGVyaW5nIG5vdyBpcyB0aGF0IGhvdyB0aGlzIGJlaGF2aW91ciBjYW4g Y2hhbmdlIHdpdGggR3VDLi4uCkkgaGVhcmQgc29tZSBtZWRpYSBmb2xrcyB3ZXJlIHVzaW5nIGk5 MTUgZGlyZWN0bHkgYW5kIGZhY2luZyBzb21lCnN0cmFuZ2UgZ3B1IGhhbmdzIGJ1dCBubyBncHUg aGFuZyB3aGVuIHVzaW5nIGd1YyBzdWJtaXNzaW9uLi4uKQoKPiAKPiAKPiA+ICsJaWYgKElTX0dF Tl9SQU5HRShpOTE1LCA5LCAxMSkpIHsKPiA+ICsJCS8qIEZ0clBlckN0eHRQcmVlbXB0aW9uR3Jh bnVsYXJpdHlDb250cm9sOnNrbCxieHQsa2JsLGNmbCxjbmwsaWNsICovCj4gCj4gYWxzbyBwbGVh c2UgZ2l2ZSBtZSBhIHBvaW50ZXIgdG8gdGhpcy4uLgo+IAo+IFRoYW5rcywKPiBSb2RyaWdvLgo+ IAo+ID4gIAkJd2FfbWFza2VkX2VuKHdhbCwKPiA+ICAJCQkgICAgIEdFTjdfRkZfU0xJQ0VfQ1Nf Q0hJQ0tFTjEsCj4gPiAgCQkJICAgICBHRU45X0ZGU0NfUEVSQ1RYX1BSRUVNUFRfQ1RSTCk7Cj4g PiAtLSAKPiA+IDIuMjAuMQo+ID4gCj4gPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwo+ID4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+ID4gSW50ZWwtZ2Z4 QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9pbnRlbC1nZngKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vaW50ZWwtZ2Z4