From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: luojiajun <luojiajun3@huawei.com>, <linux-ext4@vger.kernel.org>,
<jack@suse.com>, <yi.zhang@huawei.com>, <miaoxie@huawei.com>
Subject: Re: [PATCH] jbd2: fix invalid descriptor block checksum
Date: Fri, 1 Mar 2019 00:30:38 -0500 [thread overview]
Message-ID: <20190301053038.GA7930@mit.edu> (raw)
In-Reply-To: <20190226124710.GB15629@quack2.suse.cz>
On Tue, Feb 26, 2019 at 01:47:10PM +0100, Jan Kara wrote:
> On Tue 26-02-19 09:31:25, luojiajun wrote:
> > In jbd2_journal_commit_transaction(), if we are in abort mode,
> > we may flush the buffer without setting descriptor block checksum
> > by goto start_journal_io. Then fs is mounted,
> > jbd2_descriptor_block_csum_verify() failed.
> >
> > [ 271.379811] EXT4-fs (vdd): shut down requested (2)
> > [ 271.381827] Aborting journal on device vdd-8.
> > [ 271.597136] JBD2: Invalid checksum recovering block 22199 in log
> > [ 271.598023] JBD2: recovery failed
> > [ 271.598484] EXT4-fs (vdd): error loading journal
> >
> > Fix this problem by keep setting descriptor block checksum if the
> > descriptor buffer is not NULL.
> >
> > This checksum problem can be reproduced by xfstests generic/388.
> >
> > Signed-off-by: luojiajun <luojiajun3@huawei.com>
>
> The patch looks good to me. You can add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>
Thanks, applied.
- Ted
prev parent reply other threads:[~2019-03-01 5:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 1:31 [PATCH] jbd2: fix invalid descriptor block checksum luojiajun
2019-02-26 12:47 ` Jan Kara
2019-03-01 5:30 ` Theodore Y. Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190301053038.GA7930@mit.edu \
--to=tytso@mit.edu \
--cc=jack@suse.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=luojiajun3@huawei.com \
--cc=miaoxie@huawei.com \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.