From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: davem@davemloft.net, mkubecek@suse.cz, andrew@lunn.ch,
f.fainelli@gmail.com, netdev@vger.kernel.org,
oss-drivers@netronome.com
Subject: Re: [PATCH net-next v4 1/6] net: devlink: turn devlink into a built-in
Date: Fri, 1 Mar 2019 08:23:04 +0100 [thread overview]
Message-ID: <20190301072304.GF2314@nanopsycho> (raw)
In-Reply-To: <20190228080256.773f4f19@cakuba.netronome.com>
Thu, Feb 28, 2019 at 05:02:56PM CET, jakub.kicinski@netronome.com wrote:
>On Thu, 28 Feb 2019 16:01:25 +0100, Jiri Pirko wrote:
>> Tue, Feb 26, 2019 at 04:34:02AM CET, jakub.kicinski@netronome.com wrote:
>> >diff --git a/net/Kconfig b/net/Kconfig
>> >index 62da6148e9f8..1efe1f9ee492 100644
>> >--- a/net/Kconfig
>> >+++ b/net/Kconfig
>> >@@ -429,21 +429,12 @@ config NET_SOCK_MSG
>> > with the help of BPF programs.
>> >
>> > config NET_DEVLINK
>> >- tristate "Network physical/parent device Netlink interface"
>> >+ bool "Network physical/parent device Netlink interface"
>>
>> Wouldn't "default y" be better?
>
>No opinion. It used to be 'n', it didn't change here.. But we can
>change if we write convincing enough commit message :)
>
>Did you see cases where people "forget" to enable it?
I just did :) But I believe that is what's going to happen in the future.
>
>> > help
>> > Network physical/parent device Netlink interface provides
>> > infrastructure to support access to physical chip-wide config and
>> > monitoring.
>> >
>
>
next prev parent reply other threads:[~2019-03-01 7:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 3:34 [PATCH net-next v4 0/6] devlink: make ethtool compat reliable Jakub Kicinski
2019-02-26 3:34 ` [PATCH net-next v4 1/6] net: devlink: turn devlink into a built-in Jakub Kicinski
2019-02-28 15:01 ` Jiri Pirko
2019-02-28 16:02 ` Jakub Kicinski
2019-03-01 7:23 ` Jiri Pirko [this message]
2019-02-26 3:34 ` [PATCH net-next v4 2/6] devlink: create a special NDO for getting the devlink instance Jakub Kicinski
2019-02-26 8:56 ` Jiri Pirko
2019-02-26 3:34 ` [PATCH net-next v4 3/6] nfp: add .ndo_get_devlink Jakub Kicinski
2019-02-26 3:34 ` [PATCH net-next v4 4/6] nfp: remove ethtool flashing fallback Jakub Kicinski
2019-02-26 3:34 ` [PATCH net-next v4 5/6] devlink: hold a reference to the netdevice around ethtool compat Jakub Kicinski
2019-02-26 4:26 ` Florian Fainelli
2019-02-26 8:57 ` Jiri Pirko
2019-02-26 3:34 ` [PATCH net-next v4 6/6] devlink: require non-NULL ops for devlink instances Jakub Kicinski
2019-02-26 4:29 ` Florian Fainelli
2019-02-26 8:59 ` Jiri Pirko
2019-02-26 16:50 ` [PATCH net-next v4 0/6] devlink: make ethtool compat reliable David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190301072304.GF2314@nanopsycho \
--to=jiri@resnulli.us \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.