All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Madhumitha Prabakaran <madhumithabiw@gmail.com>
Cc: forest@alittletooquiet.net, outreachy-kernel@googlegroups.com
Subject: Re: [PATCH 0/2] Staging: vt6655: Fix comment style of SPDX-License
Date: Fri, 1 Mar 2019 08:57:51 +0100	[thread overview]
Message-ID: <20190301075751.GA13643@kroah.com> (raw)
In-Reply-To: <cover.1551402120.git.madhumithabiw@gmail.com>

On Thu, Feb 28, 2019 at 07:11:37PM -0600, Madhumitha Prabakaran wrote:
> Cc: forest@alittletooquiet.net, gregkh@linuxfoundation.org, outreachy-kernel@googlegroups.com
> 
> This patchset fixes the comment styles of SPDX-License Identifier based
> on License Identifier syntax.
> 
> Madhumitha Prabakaran (2):
>   Staging: vt6655: Modify comment style of SPDX License Identifier
>   Staging: vt6655: Fix comment style of SPDX License Identifier

You really are doing the same thing to two different files, so this
could be:

  Staging: vt6655: channel.h: Fix comment style of SPDX License Identifier
  Staging: vt6655: desc.h: Fix comment style of SPDX License Identifier

right?  That makes it more obvious what is going on here, and you don't
have to "reword" the subject lines to be different in tiny ways.

Also, this is a v2 series, right?  Please make it v3 next time you
resend it.

thanks,

greg k-h


      parent reply	other threads:[~2019-03-01  7:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-01  1:11 [PATCH 0/2] Staging: vt6655: Fix comment style of SPDX-License Madhumitha Prabakaran
2019-03-01  1:11 ` [PATCH 1/2] Staging: vt6655: Modify comment style of SPDX License Identifier Madhumitha Prabakaran
2019-03-01  1:11 ` [PATCH 2/2] Staging: vt6655: Fix " Madhumitha Prabakaran
2019-03-01  7:57 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190301075751.GA13643@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=forest@alittletooquiet.net \
    --cc=madhumithabiw@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.