From: Greg KH <gregkh@linuxfoundation.org>
To: Himadri Pandya <himadri18.07@gmail.com>
Cc: Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com,
outreachy-kernel@googlegroups.com
Subject: Re: [PATCH 1/3] staging: rtl8712: rename bDriverStopped to driver_stopped
Date: Fri, 1 Mar 2019 09:02:37 +0100 [thread overview]
Message-ID: <20190301080237.GE13643@kroah.com> (raw)
In-Reply-To: <20190301051505.55407-1-himadri18.07@gmail.com>
On Fri, Mar 01, 2019 at 10:45:03AM +0530, Himadri Pandya wrote:
> Fix checkpatch warning: Avoid CameCase for struct variable
> bDriverStopped by renaming it to driver_stopped.
>
> Signed-off-by: Himadri Pandya <himadri18.07@gmail.com>
> ---
> drivers/staging/rtl8712/drv_types.h | 3 +--
> drivers/staging/rtl8712/os_intfs.c | 2 +-
> drivers/staging/rtl8712/rtl8712_cmd.c | 4 ++--
> drivers/staging/rtl8712/rtl8712_io.c | 4 ++--
> drivers/staging/rtl8712/rtl8712_led.c | 6 +++---
> drivers/staging/rtl8712/rtl8712_recv.c | 10 +++++-----
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 16 ++++++++--------
> drivers/staging/rtl8712/rtl871x_mlme.c | 6 +++---
> drivers/staging/rtl8712/rtl871x_pwrctrl.c | 4 ++--
> drivers/staging/rtl8712/usb_intf.c | 2 +-
> drivers/staging/rtl8712/usb_ops_linux.c | 18 +++++++++---------
> 11 files changed, 37 insertions(+), 38 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/drv_types.h b/drivers/staging/rtl8712/drv_types.h
> index 48d62fe6c8d4..60c5ed55ab04 100644
> --- a/drivers/staging/rtl8712/drv_types.h
> +++ b/drivers/staging/rtl8712/drv_types.h
> @@ -145,7 +145,7 @@ struct _adapter {
> struct hal_priv halpriv;
> struct led_priv ledpriv;
> struct mp_priv mppriv;
> - s32 bDriverStopped;
> + s32 driver_stopped;
This is odd. The "b" implies that this is a "boolean" flag, not a s32
value. Why not also change this to 'bool' at the same time to preserve
that type information.
> s32 bSurpriseRemoved;
> s32 bSuspended;
> u32 IsrContent;
> @@ -180,4 +180,3 @@ static inline u8 *myid(struct eeprom_priv *peepriv)
> u8 r8712_usb_hal_bus_init(struct _adapter *adapter);
>
> #endif /*__DRV_TYPES_H__*/
> -
No need to delete this line in the same patch :(
> diff --git a/drivers/staging/rtl8712/os_intfs.c b/drivers/staging/rtl8712/os_intfs.c
> index 2d3f38007299..bd2ffd0ebde9 100644
> --- a/drivers/staging/rtl8712/os_intfs.c
> +++ b/drivers/staging/rtl8712/os_intfs.c
> @@ -374,7 +374,7 @@ static int netdev_open(struct net_device *pnetdev)
>
> mutex_lock(&padapter->mutex_start);
> if (!padapter->bup) {
> - padapter->bDriverStopped = false;
> + padapter->driver_stopped = false;
See you are using it as a boolean, might as well have it be a real
boolean.
thanks,
greg k-h
next prev parent reply other threads:[~2019-03-01 8:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 5:15 [PATCH 1/3] staging: rtl8712: rename bDriverStopped to driver_stopped Himadri Pandya
2019-03-01 5:15 ` [PATCH 2/3] staging: rtl8712: rename bSurpriseRemoved to surprise_removed Himadri Pandya
2019-03-01 8:02 ` Greg KH
2019-03-01 5:15 ` [PATCH 3/3] staging: rtl8712: rename bSuspended to suspended Himadri Pandya
2019-03-01 8:03 ` Greg KH
2019-03-01 6:59 ` [Outreachy kernel] [PATCH 1/3] staging: rtl8712: rename bDriverStopped to driver_stopped Julia Lawall
2019-03-01 10:23 ` Himadri Pandya
2019-03-01 8:02 ` Greg KH [this message]
2019-03-01 10:33 ` [PATCH v2 0/3] rename variables of struct _adapter and change Himadri Pandya
2019-03-01 10:48 ` [PATCH v2 0/3] fix checkpatch warning: Avoid CamelCase Himadri Pandya
2019-03-01 10:48 ` [PATCH v2 1/3] staging: rtl8712: rename bDriverStopped to driver_stopped Himadri Pandya
2019-03-01 10:48 ` [PATCH v2 2/3] staging: rtl8712: rename bSurpriseRemoved to surprise_removed Himadri Pandya
2019-03-01 10:48 ` [PATCH v2 3/3] staging: rtl8712: rename bSuspended to suspended Himadri Pandya
2019-03-01 11:30 ` [Outreachy kernel] " Julia Lawall
2019-03-01 11:31 ` [Outreachy kernel] [PATCH v2 0/3] fix checkpatch warning: Avoid CamelCase Julia Lawall
2019-03-03 8:03 ` Himadri Pandya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190301080237.GE13643@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Larry.Finger@lwfinger.net \
--cc=florian.c.schilhabel@googlemail.com \
--cc=himadri18.07@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.