From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: wusb: Remove unnecessary static function ckhdid_printf From: Louis Taylor Message-Id: <20190301111543.GA6028@gmail.com> Date: Fri, 1 Mar 2019 11:15:45 +0000 To: Joe Perches Cc: Jon Flatley , gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, Linux Kernel Mailing List , clang-built-linux@googlegroups.com, Nick Desaulniers List-ID: T24gVGh1LCBGZWIgMjgsIDIwMTkgYXQgMDg6Mzg6MTZQTSAtMDgwMCwgSm9lIFBlcmNoZXMgd3Jv dGU6Cj4gVGhpcyBzdGF0aWMgaW5saW5lIGlzIHVubmVjZXNzYXJ5IGFuZCBjYW4gYmUgcmVtb3Zl ZAo+IGJ5IHVzaW5nIHRoZSB2c3ByaW50ZiAlcGggZXh0ZW5zaW9uLgo+IAo+IFRoaXMgcmVkdWNl cyBvdmVyYWxsIG9iamVjdCBzaXplIGJ5IG1vcmUgdGhhbiAySy4KPiAKPiBTaWduZWQtb2ZmLWJ5 OiBKb2UgUGVyY2hlcyA8am9lQHBlcmNoZXMuY29tPgo+IC0tLQo+ICBkcml2ZXJzL3VzYi93dXNi Y29yZS9jYmFmLmMgICAgICAgfCAxNSArKysrLS0tLS0tLS0tLS0KPiAgZHJpdmVycy91c2Ivd3Vz YmNvcmUvZGV2LXN5c2ZzLmMgIHwgIDUgKystLS0KPiAgZHJpdmVycy91c2Ivd3VzYmNvcmUvZGV2 Y29ubmVjdC5jIHwgIDIgKy0KPiAgZHJpdmVycy91c2Ivd3VzYmNvcmUvd3VzYmhjLmMgICAgIHwg IDYgKy0tLS0tCj4gIGluY2x1ZGUvbGludXgvdXNiL3d1c2IuaCAgICAgICAgICB8IDE2IC0tLS0t LS0tLS0tLS0tLS0KPiAgNSBmaWxlcyBjaGFuZ2VkLCA4IGluc2VydGlvbnMoKyksIDM2IGRlbGV0 aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3VzYi93dXNiY29yZS9jYmFmLmMgYi9k cml2ZXJzL3VzYi93dXNiY29yZS9jYmFmLmMKPiBpbmRleCAyMjIyMjhjNWMxZTEuLmFmNzcwNjRj NzQ1NiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3VzYi93dXNiY29yZS9jYmFmLmMKPiArKysgYi9k cml2ZXJzL3VzYi93dXNiY29yZS9jYmFmLmMKPiBAQCAtMzAyLDEwICszMDIsOCBAQCBzdGF0aWMg c3NpemVfdCBjYmFmX3d1c2JfY2hpZF9zaG93KHN0cnVjdCBkZXZpY2UgKmRldiwKPiAgewo+ICAJ c3RydWN0IHVzYl9pbnRlcmZhY2UgKmlmYWNlID0gdG9fdXNiX2ludGVyZmFjZShkZXYpOwo+ICAJ c3RydWN0IGNiYWYgKmNiYWYgPSB1c2JfZ2V0X2ludGZkYXRhKGlmYWNlKTsKPiAtCWNoYXIgcHJf Y2hpZFtXVVNCX0NLSERJRF9TVFJTSVpFXTsKPiAgCj4gLQlja2hkaWRfcHJpbnRmKHByX2NoaWQs IHNpemVvZihwcl9jaGlkKSwgJmNiYWYtPmNoaWQpOwo+IC0JcmV0dXJuIHNjbnByaW50ZihidWYs IFBBR0VfU0laRSwgIiVzXG4iLCBwcl9jaGlkKTsKPiArCXJldHVybiBzcHJpbnRmKGJ1ZiwgIiUx NnBoXG4iLCBjYmFmLT5jaGlkLmRhdGEpOwo+ICB9Cj4gIAo+ICBzdGF0aWMgc3NpemVfdCBjYmFm X3d1c2JfY2hpZF9zdG9yZShzdHJ1Y3QgZGV2aWNlICpkZXYsCj4gQEAgLTQxNSwxMCArNDEzLDgg QEAgc3RhdGljIHNzaXplX3QgY2JhZl93dXNiX2NkaWRfc2hvdyhzdHJ1Y3QgZGV2aWNlICpkZXYs Cj4gIHsKPiAgCXN0cnVjdCB1c2JfaW50ZXJmYWNlICppZmFjZSA9IHRvX3VzYl9pbnRlcmZhY2Uo ZGV2KTsKPiAgCXN0cnVjdCBjYmFmICpjYmFmID0gdXNiX2dldF9pbnRmZGF0YShpZmFjZSk7Cj4g LQljaGFyIHByX2NkaWRbV1VTQl9DS0hESURfU1RSU0laRV07Cj4gIAo+IC0JY2toZGlkX3ByaW50 Zihwcl9jZGlkLCBzaXplb2YocHJfY2RpZCksICZjYmFmLT5jZGlkKTsKPiAtCXJldHVybiBzY25w cmludGYoYnVmLCBQQUdFX1NJWkUsICIlc1xuIiwgcHJfY2RpZCk7Cj4gKwlyZXR1cm4gc3ByaW50 ZihidWYsICIlMTZwaFxuIiwgY2JhZi0+Y2RpZC5kYXRhKTsKPiAgfQo+ICAKPiAgc3RhdGljIHNz aXplX3QgY2JhZl93dXNiX2NkaWRfc3RvcmUoc3RydWN0IGRldmljZSAqZGV2LAo+IEBAIC01MDMs NyArNDk5LDYgQEAgc3RhdGljIGludCBjYmFmX2NjX3VwbG9hZChzdHJ1Y3QgY2JhZiAqY2JhZikK PiAgCWludCByZXN1bHQ7Cj4gIAlzdHJ1Y3QgZGV2aWNlICpkZXYgPSAmY2JhZi0+dXNiX2lmYWNl LT5kZXY7Cj4gIAlzdHJ1Y3Qgd3VzYl9jYmFmX2NjX2RhdGEgKmNjZDsKPiAtCWNoYXIgcHJfY2Rp ZFtXVVNCX0NLSERJRF9TVFJTSVpFXTsKPiAgCj4gIAljY2QgPSAgY2JhZi0+YnVmZmVyOwo+ICAJ KmNjZCA9IGNiYWZfY2NfZGF0YV9kZWZhdWx0czsKPiBAQCAtNTEzLDEwICs1MDgsOCBAQCBzdGF0 aWMgaW50IGNiYWZfY2NfdXBsb2FkKHN0cnVjdCBjYmFmICpjYmFmKQo+ICAJY2NkLT5CYW5kR3Jv dXBzID0gY3B1X3RvX2xlMTYoY2JhZi0+aG9zdF9iYW5kX2dyb3Vwcyk7Cj4gIAo+ICAJZGV2X2Ri ZyhkZXYsICJUcnlpbmcgdG8gdXBsb2FkIENDOlxuIik7Cj4gLQlja2hkaWRfcHJpbnRmKHByX2Nk aWQsIHNpemVvZihwcl9jZGlkKSwgJmNjZC0+Q0hJRCk7Cj4gLQlkZXZfZGJnKGRldiwgIiAgQ0hJ RCAgICAgICAlc1xuIiwgcHJfY2RpZCk7Cj4gLQlja2hkaWRfcHJpbnRmKHByX2NkaWQsIHNpemVv Zihwcl9jZGlkKSwgJmNjZC0+Q0RJRCk7Cj4gLQlkZXZfZGJnKGRldiwgIiAgQ0RJRCAgICAgICAl c1xuIiwgcHJfY2RpZCk7Cj4gKwlkZXZfZGJnKGRldiwgIiAgQ0hJRCAgICAgICAlMTZwaFxuIiwg Y2NkLT5DSElELmRhdGEpOwo+ICsJZGV2X2RiZyhkZXYsICIgIENESUQgICAgICAgJTE2cGhcbiIs IGNjZC0+Q0RJRC5kYXRhKTsKPiAgCWRldl9kYmcoZGV2LCAiICBCYW5kZ3JvdXBzIDB4JTA0eFxu IiwgY2JhZi0+aG9zdF9iYW5kX2dyb3Vwcyk7Cj4gIAo+ICAJcmVzdWx0ID0gdXNiX2NvbnRyb2xf bXNnKAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3VzYi93dXNiY29yZS9kZXYtc3lzZnMuYyBiL2Ry aXZlcnMvdXNiL3d1c2Jjb3JlL2Rldi1zeXNmcy5jCj4gaW5kZXggODVhMWFjZjNhNzI5Li42N2Iw YTRjNDEyYjIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy91c2Ivd3VzYmNvcmUvZGV2LXN5c2ZzLmMK PiArKysgYi9kcml2ZXJzL3VzYi93dXNiY29yZS9kZXYtc3lzZnMuYwo+IEBAIC01MCwxMCArNTAs OSBAQCBzdGF0aWMgc3NpemVfdCB3dXNiX2NkaWRfc2hvdyhzdHJ1Y3QgZGV2aWNlICpkZXYsCj4g IAl3dXNiX2RldiA9IHd1c2JfZGV2X2dldF9ieV91c2JfZGV2KHRvX3VzYl9kZXZpY2UoZGV2KSk7 Cj4gIAlpZiAod3VzYl9kZXYgPT0gTlVMTCkKPiAgCQlyZXR1cm4gLUVOT0RFVjsKPiAtCXJlc3Vs dCA9IGNraGRpZF9wcmludGYoYnVmLCBQQUdFX1NJWkUsICZ3dXNiX2Rldi0+Y2RpZCk7Cj4gLQlz dHJjYXQoYnVmLCAiXG4iKTsKPiArCXJlc3VsdCA9IHNwcmludGYoYnVmLCAiJTE2cGhcbiIsIHd1 c2JfZGV2LT5jZGlkLmRhdGEpOwo+ICAJd3VzYl9kZXZfcHV0KHd1c2JfZGV2KTsKPiAtCXJldHVy biByZXN1bHQgKyAxOwo+ICsJcmV0dXJuIHJlc3VsdDsKPiAgfQo+ICBzdGF0aWMgREVWSUNFX0FU VFJfUk8od3VzYl9jZGlkKTsKPiAgCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvdXNiL3d1c2Jjb3Jl L2RldmNvbm5lY3QuYyBiL2RyaXZlcnMvdXNiL3d1c2Jjb3JlL2RldmNvbm5lY3QuYwo+IGluZGV4 IGZjYjA2YWVmMjY3NS4uYTkzODM3ZDU3ZDUzIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvdXNiL3d1 c2Jjb3JlL2RldmNvbm5lY3QuYwo+ICsrKyBiL2RyaXZlcnMvdXNiL3d1c2Jjb3JlL2RldmNvbm5l Y3QuYwo+IEBAIC01MzIsNyArNTMyLDcgQEAgc3RhdGljIHZvaWQgd3VzYmhjX2hhbmRsZV9kbl9j b25uZWN0KHN0cnVjdCB3dXNiaGMgKnd1c2JoYywKPiAgCX0KPiAgCj4gIAlkbmMgPSBjb250YWlu ZXJfb2YoZG5faGRyLCBzdHJ1Y3Qgd3VzYl9kbl9jb25uZWN0LCBoZHIpOwo+IC0JY2toZGlkX3By aW50Zihwcl9jZGlkLCBzaXplb2YocHJfY2RpZCksICZkbmMtPkNESUQpOwo+ICsJc3ByaW50Zihw cl9jZGlkLCAiJTE2cGgiLCBkbmMtPkNESUQuZGF0YSk7Cj4gIAlkZXZfaW5mbyhkZXYsICJETiBD T05ORUNUOiBkZXZpY2UgJXMgQCAleCAoJXMpIHdhbnRzIHRvICVzXG4iLAo+ICAJCSBwcl9jZGlk LAo+ICAJCSB3dXNiX2RuX2Nvbm5lY3RfcHJldl9kZXZfYWRkcihkbmMpLAo+IGRpZmYgLS1naXQg YS9kcml2ZXJzL3VzYi93dXNiY29yZS93dXNiaGMuYyBiL2RyaXZlcnMvdXNiL3d1c2Jjb3JlL3d1 c2JoYy5jCj4gaW5kZXggZTViYTYxNDBjMWJhLi5kMGI0MDRkMjU4ZTggMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy91c2Ivd3VzYmNvcmUvd3VzYmhjLmMKPiArKysgYi9kcml2ZXJzL3VzYi93dXNiY29y ZS93dXNiaGMuYwo+IEBAIC04MCwxNyArODAsMTMgQEAgc3RhdGljIHNzaXplX3Qgd3VzYl9jaGlk X3Nob3coc3RydWN0IGRldmljZSAqZGV2LAo+ICB7Cj4gIAlzdHJ1Y3Qgd3VzYmhjICp3dXNiaGMg PSB1c2JoY19kZXZfdG9fd3VzYmhjKGRldik7Cj4gIAljb25zdCBzdHJ1Y3Qgd3VzYl9ja2hkaWQg KmNoaWQ7Cj4gLQlzc2l6ZV90IHJlc3VsdCA9IDA7Cj4gIAo+ICAJaWYgKHd1c2JoYy0+d3VpZV9o b3N0X2luZm8gIT0gTlVMTCkKPiAgCQljaGlkID0gJnd1c2JoYy0+d3VpZV9ob3N0X2luZm8tPkNI SUQ7Cj4gIAllbHNlCj4gIAkJY2hpZCA9ICZ3dXNiX2NraGRpZF96ZXJvOwo+ICAKPiAtCXJlc3Vs dCArPSBja2hkaWRfcHJpbnRmKGJ1ZiwgUEFHRV9TSVpFLCBjaGlkKTsKPiAtCXJlc3VsdCArPSBz cHJpbnRmKGJ1ZiArIHJlc3VsdCwgIlxuIik7Cj4gLQo+IC0JcmV0dXJuIHJlc3VsdDsKPiArCXJl dHVybiBzcHJpbnRmKGJ1ZiwgIiUxNnBoXG4iLCBjaGlkLT5kYXRhKTsKPiAgfQo+ICAKPiAgLyoK PiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9saW51eC91c2Ivd3VzYi5oIGIvaW5jbHVkZS9saW51eC91 c2Ivd3VzYi5oCj4gaW5kZXggOWU0YTMyMTNmMmMyLi42NWFkZWU2MjkxMDYgMTAwNjQ0Cj4gLS0t IGEvaW5jbHVkZS9saW51eC91c2Ivd3VzYi5oCj4gKysrIGIvaW5jbHVkZS9saW51eC91c2Ivd3Vz Yi5oCj4gQEAgLTIzNiwyMiArMjM2LDYgQEAgZW51bSB7Cj4gIAlXVVNCX1RSVVNUX1RJTUVPVVRf TVMgPSA0MDAwLAkvKiBbV1VTQl0gc2VjdGlvbiA0LjE1LjEgKi8KPiAgfTsKPiAgCj4gLXN0YXRp YyBpbmxpbmUgc2l6ZV90IGNraGRpZF9wcmludGYoY2hhciAqcHJfY2toZGlkLCBzaXplX3Qgc2l6 ZSwKPiAtCQkJCSAgIGNvbnN0IHN0cnVjdCB3dXNiX2NraGRpZCAqY2toZGlkKQo+IC17Cj4gLQly ZXR1cm4gc2NucHJpbnRmKHByX2NraGRpZCwgc2l6ZSwKPiAtCQkJICIlMDJoeCAlMDJoeCAlMDJo eCAlMDJoeCAlMDJoeCAlMDJoeCAlMDJoeCAlMDJoeCAiCj4gLQkJCSAiJTAyaHggJTAyaHggJTAy aHggJTAyaHggJTAyaHggJTAyaHggJTAyaHggJTAyaHgiLAo+IC0JCQkgY2toZGlkLT5kYXRhWzBd LCAgY2toZGlkLT5kYXRhWzFdLAo+IC0JCQkgY2toZGlkLT5kYXRhWzJdLCAgY2toZGlkLT5kYXRh WzNdLAo+IC0JCQkgY2toZGlkLT5kYXRhWzRdLCAgY2toZGlkLT5kYXRhWzVdLAo+IC0JCQkgY2to ZGlkLT5kYXRhWzZdLCAgY2toZGlkLT5kYXRhWzddLAo+IC0JCQkgY2toZGlkLT5kYXRhWzhdLCAg Y2toZGlkLT5kYXRhWzldLAo+IC0JCQkgY2toZGlkLT5kYXRhWzEwXSwgY2toZGlkLT5kYXRhWzEx XSwKPiAtCQkJIGNraGRpZC0+ZGF0YVsxMl0sIGNraGRpZC0+ZGF0YVsxM10sCj4gLQkJCSBja2hk aWQtPmRhdGFbMTRdLCBja2hkaWQtPmRhdGFbMTVdKTsKPiAtfQoKVGhpcyByZW1vdmVzIHRoZSBv cmlnaW5hbCBjbGFuZyB3YXJuaW5nIGFuZCBzZWVtcyBsaWtlIGEgbmljZSBjbGVhbnVwLgoKUmV2 aWV3ZWQtYnk6IExvdWlzIFRheWxvciA8bG91aXNAa3JhZ25pei5ldT4KCkNoZWVycywKTG91aXMK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DEC4C43381 for ; Fri, 1 Mar 2019 11:16:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 519F420850 for ; Fri, 1 Mar 2019 11:16:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kragniz.eu header.i=@kragniz.eu header.b="Vr6bf0IL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733251AbfCALQe (ORCPT ); Fri, 1 Mar 2019 06:16:34 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:52734 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727932AbfCALQe (ORCPT ); Fri, 1 Mar 2019 06:16:34 -0500 Received: by mail-wm1-f66.google.com with SMTP id m1so12206766wml.2 for ; Fri, 01 Mar 2019 03:16:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kragniz.eu; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Cm2xSot7H/olf7uiYvr9ICVuca5jG8v4koRvKNfds50=; b=Vr6bf0IL5rldkVenrPm6yR29raVONgvWt07u6jIC38Wcn8xwd67oYZBsUqqEw5Hc0d OpQC7IJyFYucxNHvaWhRhh04FXXTzgt4KZEw2TFuRydWye0FdmfnfQqmeG8+xg6lqvCK yB0YNPUK3AQW3F0spnphDsdfI41MlIF+r4bss= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Cm2xSot7H/olf7uiYvr9ICVuca5jG8v4koRvKNfds50=; b=f4IBe81ooLvdra08QkvrtNXPwhKbWxu5w+si1lMmn+pog9Ni6P9pnx1nQz/4HA2XFo Z+WS4/tWz/iJH3V7PVaZlSoc5CBnlsW8Pgsq+UGmDvCne8ejTsrZKkuDRCVlU35CUE2r c0Lh8Q3+DGOAXrGmatQPH8bERbQEbmx9woBGH57YJeaJYAD4qcnu8gCuQV3ZaCD4ESjl h2othJUbRNg7LYpMZsFTTqlDq6YmXXhth1Lrc6JA9wl084VOw8HpIJ+WUYJuLg8KCEnH 6+uhGXydCkjASFKAkVf5vekUEc291CJArQAaD687hsf8/6iWAX5dRER30fbaROwcM02m P+ig== X-Gm-Message-State: APjAAAWRHFuLfabUfMmCc5dIswH6fwjBBbmlzxH+E/t9nLI6ZOWbj3VJ SCO3y8+jiAW5/sRT419uVpL73A== X-Google-Smtp-Source: AHgI3IauNYWV45cwKkAdozAPjLsSh2KsIZmNHq47bIZfXoGcTbdBer2PEwOsFiVv8ha9Ih3kNKmM4g== X-Received: by 2002:a1c:e084:: with SMTP id x126mr2923588wmg.39.1551438991671; Fri, 01 Mar 2019 03:16:31 -0800 (PST) Received: from gmail.com ([95.149.160.3]) by smtp.gmail.com with ESMTPSA id u4sm10602151wmb.25.2019.03.01.03.16.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 01 Mar 2019 03:16:31 -0800 (PST) Date: Fri, 1 Mar 2019 11:15:45 +0000 From: Louis Taylor To: Joe Perches Cc: Jon Flatley , gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, Linux Kernel Mailing List , clang-built-linux@googlegroups.com, Nick Desaulniers Subject: Re: [PATCH] wusb: Remove unnecessary static function ckhdid_printf Message-ID: <20190301111543.GA6028@gmail.com> References: <20190228115256.5446-1-louis@kragniz.eu> <20190228122417.9318-1-louis@kragniz.eu> <15c6689389503a82394bccb9204650bf20a7a6d3.camel@perches.com> <1450785b937f4a2b5f98c8548986b162684a719b.camel@perches.com> <3f515cdb5cb6f77acb5cd8029bacd0be782eed64.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3f515cdb5cb6f77acb5cd8029bacd0be782eed64.camel@perches.com> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 28, 2019 at 08:38:16PM -0800, Joe Perches wrote: > This static inline is unnecessary and can be removed > by using the vsprintf %ph extension. > > This reduces overall object size by more than 2K. > > Signed-off-by: Joe Perches > --- > drivers/usb/wusbcore/cbaf.c | 15 ++++----------- > drivers/usb/wusbcore/dev-sysfs.c | 5 ++--- > drivers/usb/wusbcore/devconnect.c | 2 +- > drivers/usb/wusbcore/wusbhc.c | 6 +----- > include/linux/usb/wusb.h | 16 ---------------- > 5 files changed, 8 insertions(+), 36 deletions(-) > > diff --git a/drivers/usb/wusbcore/cbaf.c b/drivers/usb/wusbcore/cbaf.c > index 222228c5c1e1..af77064c7456 100644 > --- a/drivers/usb/wusbcore/cbaf.c > +++ b/drivers/usb/wusbcore/cbaf.c > @@ -302,10 +302,8 @@ static ssize_t cbaf_wusb_chid_show(struct device *dev, > { > struct usb_interface *iface = to_usb_interface(dev); > struct cbaf *cbaf = usb_get_intfdata(iface); > - char pr_chid[WUSB_CKHDID_STRSIZE]; > > - ckhdid_printf(pr_chid, sizeof(pr_chid), &cbaf->chid); > - return scnprintf(buf, PAGE_SIZE, "%s\n", pr_chid); > + return sprintf(buf, "%16ph\n", cbaf->chid.data); > } > > static ssize_t cbaf_wusb_chid_store(struct device *dev, > @@ -415,10 +413,8 @@ static ssize_t cbaf_wusb_cdid_show(struct device *dev, > { > struct usb_interface *iface = to_usb_interface(dev); > struct cbaf *cbaf = usb_get_intfdata(iface); > - char pr_cdid[WUSB_CKHDID_STRSIZE]; > > - ckhdid_printf(pr_cdid, sizeof(pr_cdid), &cbaf->cdid); > - return scnprintf(buf, PAGE_SIZE, "%s\n", pr_cdid); > + return sprintf(buf, "%16ph\n", cbaf->cdid.data); > } > > static ssize_t cbaf_wusb_cdid_store(struct device *dev, > @@ -503,7 +499,6 @@ static int cbaf_cc_upload(struct cbaf *cbaf) > int result; > struct device *dev = &cbaf->usb_iface->dev; > struct wusb_cbaf_cc_data *ccd; > - char pr_cdid[WUSB_CKHDID_STRSIZE]; > > ccd = cbaf->buffer; > *ccd = cbaf_cc_data_defaults; > @@ -513,10 +508,8 @@ static int cbaf_cc_upload(struct cbaf *cbaf) > ccd->BandGroups = cpu_to_le16(cbaf->host_band_groups); > > dev_dbg(dev, "Trying to upload CC:\n"); > - ckhdid_printf(pr_cdid, sizeof(pr_cdid), &ccd->CHID); > - dev_dbg(dev, " CHID %s\n", pr_cdid); > - ckhdid_printf(pr_cdid, sizeof(pr_cdid), &ccd->CDID); > - dev_dbg(dev, " CDID %s\n", pr_cdid); > + dev_dbg(dev, " CHID %16ph\n", ccd->CHID.data); > + dev_dbg(dev, " CDID %16ph\n", ccd->CDID.data); > dev_dbg(dev, " Bandgroups 0x%04x\n", cbaf->host_band_groups); > > result = usb_control_msg( > diff --git a/drivers/usb/wusbcore/dev-sysfs.c b/drivers/usb/wusbcore/dev-sysfs.c > index 85a1acf3a729..67b0a4c412b2 100644 > --- a/drivers/usb/wusbcore/dev-sysfs.c > +++ b/drivers/usb/wusbcore/dev-sysfs.c > @@ -50,10 +50,9 @@ static ssize_t wusb_cdid_show(struct device *dev, > wusb_dev = wusb_dev_get_by_usb_dev(to_usb_device(dev)); > if (wusb_dev == NULL) > return -ENODEV; > - result = ckhdid_printf(buf, PAGE_SIZE, &wusb_dev->cdid); > - strcat(buf, "\n"); > + result = sprintf(buf, "%16ph\n", wusb_dev->cdid.data); > wusb_dev_put(wusb_dev); > - return result + 1; > + return result; > } > static DEVICE_ATTR_RO(wusb_cdid); > > diff --git a/drivers/usb/wusbcore/devconnect.c b/drivers/usb/wusbcore/devconnect.c > index fcb06aef2675..a93837d57d53 100644 > --- a/drivers/usb/wusbcore/devconnect.c > +++ b/drivers/usb/wusbcore/devconnect.c > @@ -532,7 +532,7 @@ static void wusbhc_handle_dn_connect(struct wusbhc *wusbhc, > } > > dnc = container_of(dn_hdr, struct wusb_dn_connect, hdr); > - ckhdid_printf(pr_cdid, sizeof(pr_cdid), &dnc->CDID); > + sprintf(pr_cdid, "%16ph", dnc->CDID.data); > dev_info(dev, "DN CONNECT: device %s @ %x (%s) wants to %s\n", > pr_cdid, > wusb_dn_connect_prev_dev_addr(dnc), > diff --git a/drivers/usb/wusbcore/wusbhc.c b/drivers/usb/wusbcore/wusbhc.c > index e5ba6140c1ba..d0b404d258e8 100644 > --- a/drivers/usb/wusbcore/wusbhc.c > +++ b/drivers/usb/wusbcore/wusbhc.c > @@ -80,17 +80,13 @@ static ssize_t wusb_chid_show(struct device *dev, > { > struct wusbhc *wusbhc = usbhc_dev_to_wusbhc(dev); > const struct wusb_ckhdid *chid; > - ssize_t result = 0; > > if (wusbhc->wuie_host_info != NULL) > chid = &wusbhc->wuie_host_info->CHID; > else > chid = &wusb_ckhdid_zero; > > - result += ckhdid_printf(buf, PAGE_SIZE, chid); > - result += sprintf(buf + result, "\n"); > - > - return result; > + return sprintf(buf, "%16ph\n", chid->data); > } > > /* > diff --git a/include/linux/usb/wusb.h b/include/linux/usb/wusb.h > index 9e4a3213f2c2..65adee629106 100644 > --- a/include/linux/usb/wusb.h > +++ b/include/linux/usb/wusb.h > @@ -236,22 +236,6 @@ enum { > WUSB_TRUST_TIMEOUT_MS = 4000, /* [WUSB] section 4.15.1 */ > }; > > -static inline size_t ckhdid_printf(char *pr_ckhdid, size_t size, > - const struct wusb_ckhdid *ckhdid) > -{ > - return scnprintf(pr_ckhdid, size, > - "%02hx %02hx %02hx %02hx %02hx %02hx %02hx %02hx " > - "%02hx %02hx %02hx %02hx %02hx %02hx %02hx %02hx", > - ckhdid->data[0], ckhdid->data[1], > - ckhdid->data[2], ckhdid->data[3], > - ckhdid->data[4], ckhdid->data[5], > - ckhdid->data[6], ckhdid->data[7], > - ckhdid->data[8], ckhdid->data[9], > - ckhdid->data[10], ckhdid->data[11], > - ckhdid->data[12], ckhdid->data[13], > - ckhdid->data[14], ckhdid->data[15]); > -} This removes the original clang warning and seems like a nice cleanup. Reviewed-by: Louis Taylor Cheers, Louis