All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] perf intel-pt: Fix divide by zero
Date: Fri, 1 Mar 2019 14:49:39 -0300	[thread overview]
Message-ID: <20190301174939.GJ13100@kernel.org> (raw)
In-Reply-To: <20190301103536.7197-1-adrian.hunter@intel.com>

Em Fri, Mar 01, 2019 at 12:35:36PM +0200, Adrian Hunter escreveu:
> When tsc is not available, "timeless" decoding is used but a divide by
> zero occurs if perf_time_to_tsc() is called. Ensure the divisor is not
> zero.

Thanks, applied.

- Arnaldo
 
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
> Cc: stable@vger.kernel.org # v4.9+
> ---
>  tools/perf/util/intel-pt.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/perf/util/intel-pt.c b/tools/perf/util/intel-pt.c
> index 3b497bab4324..6d288237887b 100644
> --- a/tools/perf/util/intel-pt.c
> +++ b/tools/perf/util/intel-pt.c
> @@ -2531,6 +2531,8 @@ int intel_pt_process_auxtrace_info(union perf_event *event,
>  	}
>  
>  	pt->timeless_decoding = intel_pt_timeless_decoding(pt);
> +	if (pt->timeless_decoding && !pt->tc.time_mult)
> +		pt->tc.time_mult = 1;
>  	pt->have_tsc = intel_pt_have_tsc(pt);
>  	pt->sampling_mode = false;
>  	pt->est_tsc = !pt->timeless_decoding;
> -- 
> 2.17.1

-- 

- Arnaldo

           reply	other threads:[~2019-03-01 17:49 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20190301103536.7197-1-adrian.hunter@intel.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190301174939.GJ13100@kernel.org \
    --to=arnaldo.melo@gmail.com \
    --cc=adrian.hunter@intel.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.