All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Mackerras <paulus@ozlabs.org>
To: Andrej Shadura <andrew.shadura@collabora.co.uk>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] gitk: refresh the colour scheme
Date: Sun, 3 Mar 2019 10:02:28 +1100	[thread overview]
Message-ID: <20190302230228.GA26937@blackberry> (raw)
In-Reply-To: <20190226110535.29172-1-andrew.shadura@collabora.co.uk>

On Tue, Feb 26, 2019 at 12:05:34PM +0100, Andrej Shadura wrote:
> The colours gitk is currently using are from the basic 16 colour
> palette, and are a bit too intensive to be comfortable or pleasant
> to work with.
> 
> Adjust the main colours (commit nodes, remotes, tags and one branch
> colour) to be slightly softer.
> 
> Signed-off-by: Andrej Shadura <andrew.shadura@collabora.co.uk>

Thanks for the patch, but I disagree.  I do like the change you made
to the tag colours, but the blue you have for the commit node circles
is pretty blah.  That needs a more definite colour.

Also, the "too intensive to be comfortable or pleasant" in the commit
message reflect a personal preference, and the way it is put seems to
me to be too intensive to be comfortable or pleasant.

Paul.

  parent reply	other threads:[~2019-03-03  1:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-26 11:05 [PATCH 1/2] gitk: refresh the colour scheme Andrej Shadura
2019-02-26 11:05 ` [PATCH 2/2] gitk: disable autoselect by default Andrej Shadura
2019-03-02 23:02 ` Paul Mackerras [this message]
2019-03-04  9:35   ` [PATCH 1/2] gitk: refresh the colour scheme Andrej Shadura
2021-02-04 20:34     ` Andrej Shadura

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190302230228.GA26937@blackberry \
    --to=paulus@ozlabs.org \
    --cc=andrew.shadura@collabora.co.uk \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.