All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Himadri Pandya <himadri18.07@gmail.com>
Cc: Larry.Finger@lwfinger.net, floarian.c.schilhabel@googlemail.com,
	outreachy-kernel@googlegroups.com
Subject: Re: [PATCH v2 1/3] staging: rtl8712: rename bDriverStopped to driver_stopped
Date: Sun, 3 Mar 2019 09:22:31 +0100	[thread overview]
Message-ID: <20190303082231.GA20326@kroah.com> (raw)
In-Reply-To: <20190303081808.83540-2-himadri18.07@gmail.com>

On Sun, Mar 03, 2019 at 01:48:06PM +0530, Himadri Pandya wrote:
> Fix checkpatch warning: Avoid CameCase for struct variable
> bDriverStopped by renaming it to driver_stopped.
> 
> Signed-off-by: Himadri Pandya <himadri18.07@gmail.com>
> ---
> Changes in V2:
> 	- Change type to bool as the variable is being used as boolean.

Didn't Julia also ask you to say that you changed the type in the
changelog text?  You need to do that for all of these patches.

thanks,

greg k-h


  parent reply	other threads:[~2019-03-03  8:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-03  8:18 [PATCH v2 0/3] fix checkpatch warning: Avoid CamelCase Himadri Pandya
2019-03-03  8:18 ` [PATCH v2 1/3] staging: rtl8712: rename bDriverStopped to driver_stopped Himadri Pandya
2019-03-03  8:21   ` [Outreachy kernel] " Julia Lawall
2019-03-03  8:22   ` Greg KH [this message]
2019-03-03  8:18 ` [PATCH v2 2/3] staging: rtl8712: rename bSurpriseRemoved to surprise_removed Himadri Pandya
2019-03-03  8:24   ` [Outreachy kernel] " Julia Lawall
2019-03-03  8:18 ` [PATCH v2 3/3] staging: rtl8712: rename bSuspended to suspended Himadri Pandya
  -- strict thread matches above, loose matches on Subject: below --
2019-03-01  5:15 [PATCH 1/3] staging: rtl8712: rename bDriverStopped to driver_stopped Himadri Pandya
2019-03-01 10:48 ` [PATCH v2 0/3] fix checkpatch warning: Avoid CamelCase Himadri Pandya
2019-03-01 10:48   ` [PATCH v2 1/3] staging: rtl8712: rename bDriverStopped to driver_stopped Himadri Pandya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190303082231.GA20326@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=floarian.c.schilhabel@googlemail.com \
    --cc=himadri18.07@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.