From: Jonathan Cameron <jic23@kernel.org>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Song Qiang <songqiang1304521@gmail.com>,
Jean-Baptiste Maneyrol <jmaneyrol@invensense.com>,
Martin Kelly <mkelly@xevo.com>,
Jonathan Marek <jonathan@marek.ca>,
Brian Masney <masneyb@onstation.org>,
Stephan Gerhold <stephan@gerhold.net>,
letux-kernel@openphoenux.org, Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 09/10] iio: mpu6050: improve code readability
Date: Sun, 3 Mar 2019 15:30:07 +0000 [thread overview]
Message-ID: <20190303153007.643fe422@archlinux> (raw)
In-Reply-To: <1493d22e5c0710a4ced34bf3bc714d367bdf58a3.1550768574.git.hns@goldelico.com>
On Thu, 21 Feb 2019 18:02:54 +0100
"H. Nikolaus Schaller" <hns@goldelico.com> wrote:
> - use temporary variable in get_mount_matrix()
> - remove , after { }
>
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
Applied.
Thanks,
Jonathan
> ---
> drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> index 533d1f8321ac..e7721b6fb441 100644
> --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> @@ -765,12 +765,14 @@ static const struct iio_mount_matrix *
> inv_get_mount_matrix(const struct iio_dev *indio_dev,
> const struct iio_chan_spec *chan)
> {
> - return &((struct inv_mpu6050_state *)iio_priv(indio_dev))->orientation;
> + struct inv_mpu6050_state *data = iio_priv(indio_dev);
> +
> + return &data->orientation;
> }
>
> static const struct iio_chan_spec_ext_info inv_ext_info[] = {
> IIO_MOUNT_MATRIX(IIO_SHARED_BY_TYPE, inv_get_mount_matrix),
> - { },
> + { }
> };
>
> #define INV_MPU6050_CHAN(_type, _channel2, _index) \
next prev parent reply other threads:[~2019-03-03 15:30 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 17:02 [PATCH v2 00/10] iio mount matrix - revitalize missing bindings documentation and provide code for bmc150, bmg160, bma180, itg3200, hmc584x H. Nikolaus Schaller
2019-02-21 17:02 ` [PATCH v2 01/10] iio: Allow to read mount matrix from ACPI H. Nikolaus Schaller
2019-03-03 14:59 ` Jonathan Cameron
2019-02-21 17:02 ` [PATCH v2 02/10] iio: document bindings for mounting matrices H. Nikolaus Schaller
2019-02-22 23:42 ` Rob Herring
2019-02-22 23:42 ` Rob Herring
2019-02-25 16:32 ` Jonathan Corbet
2019-02-25 16:32 ` Jonathan Corbet
2019-02-25 18:24 ` Linus Walleij
2019-02-25 18:24 ` Linus Walleij
2019-02-25 18:29 ` Jonathan Corbet
2019-02-25 18:29 ` Jonathan Corbet
2019-02-25 19:38 ` Rob Herring
2019-02-25 19:38 ` Rob Herring
2019-03-03 15:19 ` Jonathan Cameron
2019-03-03 15:19 ` Jonathan Cameron
2019-03-07 12:53 ` H. Nikolaus Schaller
2019-03-07 12:53 ` H. Nikolaus Schaller
2019-07-23 7:42 ` Linus Walleij
2019-07-23 7:42 ` Linus Walleij
2019-07-23 9:46 ` H. Nikolaus Schaller
2019-07-23 9:46 ` H. Nikolaus Schaller
2019-07-28 7:50 ` Jonathan Cameron
2019-07-28 7:50 ` Jonathan Cameron
2019-07-28 10:07 ` Linus Walleij
2019-07-28 10:07 ` Linus Walleij
2019-07-23 15:39 ` Andy Shevchenko
2019-07-23 15:39 ` Andy Shevchenko
2019-02-21 17:02 ` [PATCH v2 03/10] iio: accel: bmc150: add mount matrix support H. Nikolaus Schaller
2019-03-03 15:20 ` Jonathan Cameron
2019-02-21 17:02 ` [PATCH v2 04/10] iio: accel: bma180: " H. Nikolaus Schaller
2019-03-03 15:20 ` Jonathan Cameron
2019-02-21 17:02 ` [PATCH v2 05/10] iio: gyro: bmg160: " H. Nikolaus Schaller
2019-03-03 15:21 ` Jonathan Cameron
2019-02-21 17:02 ` [PATCH v2 06/10] iio: gyro: itg3200: " H. Nikolaus Schaller
2019-03-03 15:22 ` Jonathan Cameron
2019-02-21 17:02 ` [PATCH v2 07/10] iio: magnetometer: bmc150: " H. Nikolaus Schaller
2019-03-03 15:23 ` Jonathan Cameron
2019-02-21 17:02 ` [PATCH v2 08/10] iio: magnetometer: hmc5843: " H. Nikolaus Schaller
2019-03-03 15:24 ` Jonathan Cameron
2019-02-21 17:02 ` [PATCH v2 09/10] iio: mpu6050: improve code readability H. Nikolaus Schaller
2019-03-03 15:30 ` Jonathan Cameron [this message]
2019-02-21 17:02 ` [PATCH v2 10/10] iio: ak8975: " H. Nikolaus Schaller
2019-03-03 15:30 ` Jonathan Cameron
2019-02-22 14:48 ` [PATCH v2 00/10] iio mount matrix - revitalize missing bindings documentation and provide code for bmc150, bmg160, bma180, itg3200, hmc584x Andy Shevchenko
2019-02-22 14:48 ` Andy Shevchenko
2019-03-03 15:32 ` Jonathan Cameron
2019-03-03 15:32 ` Jonathan Cameron
2019-04-04 6:29 ` H. Nikolaus Schaller
2019-04-04 6:29 ` H. Nikolaus Schaller
2019-04-07 11:41 ` Jonathan Cameron
2019-04-07 11:41 ` Jonathan Cameron
2019-04-08 6:32 ` H. Nikolaus Schaller
2019-02-22 16:24 ` Linus Walleij
2019-02-22 16:24 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190303153007.643fe422@archlinux \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ckeepax@opensource.cirrus.com \
--cc=devicetree@vger.kernel.org \
--cc=hns@goldelico.com \
--cc=jmaneyrol@invensense.com \
--cc=jonathan@marek.ca \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=letux-kernel@openphoenux.org \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=masneyb@onstation.org \
--cc=mkelly@xevo.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=songqiang1304521@gmail.com \
--cc=stephan@gerhold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.