From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Guo Subject: Re: [PATCH v2] arm64: dts: ls1088a: add one more thermal zone node Date: Mon, 4 Mar 2019 14:53:03 +0800 Message-ID: <20190304065302.GD26041@dragon> References: <20190304032111.21770-1-andy.tang@nxp.com> <20190304062115.GB26041@dragon> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Andy Tang Cc: "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , "linux-pm@vger.kernel.org" , "daniel.lezcano@linaro.org" , "linux-kernel@vger.kernel.org" , Leo Li , "edubezval@gmail.com" , "robh+dt@kernel.org" , "rui.zhang@intel.com" , "linux-arm-kernel@lists.infradead.org" List-Id: linux-pm@vger.kernel.org On Mon, Mar 04, 2019 at 06:46:32AM +0000, Andy Tang wrote: > > > > -----Original Message----- > > From: Shawn Guo > > Sent: 2019年3月4日 14:21 > > To: Andy Tang > > Cc: Leo Li ; robh+dt@kernel.org; mark.rutland@arm.com; > > linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org; > > linux-kernel@vger.kernel.org; linux-pm@vger.kernel.org; > > daniel.lezcano@linaro.org; rui.zhang@intel.com; edubezval@gmail.com > > Subject: Re: [PATCH v2] arm64: dts: ls1088a: add one more thermal zone node > > > > On Mon, Mar 04, 2019 at 11:21:11AM +0800, Yuantian Tang wrote: > > > Ls1088a has 2 thermal sensors, core cluster and SoC platform. Core > > > cluster sensor is used to monitor the temperature of core and SoC > > > platform is for platform. The current dts only support the first sensor. > > > This patch adds the second sensor node to dts to enable it. > > > > > > Signed-off-by: Yuantian Tang > > > --- > > > v2: > > > - Add more information about sensors to description > > > PS: In order to keep consistency to the first thermal-zone node, there > > > will be "WARNING: line over 80 characters" warnings. > > > > > > arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 43 > > +++++++++++++++++++++-- > > > 1 files changed, 39 insertions(+), 4 deletions(-) > > > > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > > > b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > > > index 661137f..9f52bc9 100644 > > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > > > @@ -129,19 +129,19 @@ > > > }; > > > > > > thermal-zones { > > > - cpu_thermal: cpu-thermal { > > > + ccu { > > > > Is this change really necessary? What does 'ccu' stand for? > I think so. ccu stands for core cluster unit. cpu is too general. > On some platforms, there are more than one core clusters. > At least we should change it to "core cluster" if short form is not appropriate. Yes, please give it a more descriptive name. Shawn From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A19E8C10F03 for ; Mon, 4 Mar 2019 06:54:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6F05C2082F for ; Mon, 4 Mar 2019 06:54:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dU75fUg1"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="PGNaDuIZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6F05C2082F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XZrBG6FN+V34hn9EBX1lYOJCDJpMHgcdKQLVSo7V9E0=; b=dU75fUg1picA5B /vU05iambjqzR778BE/rGJ5OV5oH5xnSUZsvIwkjkvivGH4xtBrIHI5t1V050FpHRw2Suu46+PhtN 6Wjacw0UmmUuzszqwDZ0e3Baxf7yZwCCzvPymCOmMqVMHS0iFDESMtuivjAj+Dpu7J4vPMJkxjVuY Zs97eTYxqMwzsSEZjRkM/3/BvpKcX0W918sPkA7WtOzetVHIsU211ESMrVfl+tramIgPiILPfczBL FgKbjtYMzdgz69zhtBrS2Kfp+6PoHRgA/CGnp4XYWnmpTS1t/clIx6VLL7q1ahDdLNs1PRl4PF8N7 vjNZsoYr+yJcu7x+MLRA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h0hUH-00018W-JO; Mon, 04 Mar 2019 06:54:09 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h0hUF-00018B-4h for linux-arm-kernel@lists.infradead.org; Mon, 04 Mar 2019 06:54:08 +0000 Received: from dragon (61-216-91-114.HINET-IP.hinet.net [61.216.91.114]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 88A3A21019; Mon, 4 Mar 2019 06:54:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551682446; bh=6VuAjyAddotNq2EYZx+fOq8K4a8Mvh/0OZ3+vmq28q4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PGNaDuIZrzn8JSBn5hZopIHxQgqmB0y4sHpRnbYReTDUG3tQACtvejPaBjf97ydYc VG8fNr4eRr+BFYGYtDhIxoe6QxVfk1vsGk+5h7tPkx3WNFsfJmRndwo5ULif2t19Xw JYGNLL2vlrWEhURkCxb/UIRqZYZioZ1j9QAr2OhQ= Date: Mon, 4 Mar 2019 14:53:03 +0800 From: Shawn Guo To: Andy Tang Subject: Re: [PATCH v2] arm64: dts: ls1088a: add one more thermal zone node Message-ID: <20190304065302.GD26041@dragon> References: <20190304032111.21770-1-andy.tang@nxp.com> <20190304062115.GB26041@dragon> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190303_225407_199208_419E66EC X-CRM114-Status: GOOD ( 17.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , "linux-pm@vger.kernel.org" , "daniel.lezcano@linaro.org" , "linux-kernel@vger.kernel.org" , Leo Li , "edubezval@gmail.com" , "robh+dt@kernel.org" , "rui.zhang@intel.com" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBNYXIgMDQsIDIwMTkgYXQgMDY6NDY6MzJBTSArMDAwMCwgQW5keSBUYW5nIHdyb3Rl Ogo+IAo+IAo+ID4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0KPiA+IEZyb206IFNoYXduIEd1 byA8c2hhd25ndW9Aa2VybmVsLm9yZz4KPiA+IFNlbnQ6IDIwMTnlubQz5pyINOaXpSAxNDoyMQo+ ID4gVG86IEFuZHkgVGFuZyA8YW5keS50YW5nQG54cC5jb20+Cj4gPiBDYzogTGVvIExpIDxsZW95 YW5nLmxpQG54cC5jb20+OyByb2JoK2R0QGtlcm5lbC5vcmc7IG1hcmsucnV0bGFuZEBhcm0uY29t Owo+ID4gbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnOyBkZXZpY2V0cmVlQHZn ZXIua2VybmVsLm9yZzsKPiA+IGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc7IGxpbnV4LXBt QHZnZXIua2VybmVsLm9yZzsKPiA+IGRhbmllbC5sZXpjYW5vQGxpbmFyby5vcmc7IHJ1aS56aGFu Z0BpbnRlbC5jb207IGVkdWJlenZhbEBnbWFpbC5jb20KPiA+IFN1YmplY3Q6IFJlOiBbUEFUQ0gg djJdIGFybTY0OiBkdHM6IGxzMTA4OGE6IGFkZCBvbmUgbW9yZSB0aGVybWFsIHpvbmUgbm9kZQo+ ID4gCj4gPiBPbiBNb24sIE1hciAwNCwgMjAxOSBhdCAxMToyMToxMUFNICswODAwLCBZdWFudGlh biBUYW5nIHdyb3RlOgo+ID4gPiBMczEwODhhIGhhcyAyIHRoZXJtYWwgc2Vuc29ycywgY29yZSBj bHVzdGVyIGFuZCBTb0MgcGxhdGZvcm0uIENvcmUKPiA+ID4gY2x1c3RlciBzZW5zb3IgaXMgdXNl ZCB0byBtb25pdG9yIHRoZSB0ZW1wZXJhdHVyZSBvZiBjb3JlIGFuZCBTb0MKPiA+ID4gcGxhdGZv cm0gaXMgZm9yIHBsYXRmb3JtLiBUaGUgY3VycmVudCBkdHMgb25seSBzdXBwb3J0IHRoZSBmaXJz dCBzZW5zb3IuCj4gPiA+IFRoaXMgcGF0Y2ggYWRkcyB0aGUgc2Vjb25kIHNlbnNvciBub2RlIHRv IGR0cyB0byBlbmFibGUgaXQuCj4gPiA+Cj4gPiA+IFNpZ25lZC1vZmYtYnk6IFl1YW50aWFuIFRh bmcgPGFuZHkudGFuZ0BueHAuY29tPgo+ID4gPiAtLS0KPiA+ID4gdjI6Cj4gPiA+IAktIEFkZCBt b3JlIGluZm9ybWF0aW9uIGFib3V0IHNlbnNvcnMgdG8gZGVzY3JpcHRpb24KPiA+ID4gUFM6IElu IG9yZGVyIHRvIGtlZXAgY29uc2lzdGVuY3kgdG8gdGhlIGZpcnN0IHRoZXJtYWwtem9uZSBub2Rl LCB0aGVyZQo+ID4gPiB3aWxsIGJlICJXQVJOSU5HOiBsaW5lIG92ZXIgODAgY2hhcmFjdGVycyIg d2FybmluZ3MuCj4gPiA+Cj4gPiA+ICBhcmNoL2FybTY0L2Jvb3QvZHRzL2ZyZWVzY2FsZS9mc2wt bHMxMDg4YS5kdHNpIHwgICA0Mwo+ID4gKysrKysrKysrKysrKysrKysrKysrLS0KPiA+ID4gIDEg ZmlsZXMgY2hhbmdlZCwgMzkgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKPiA+ID4KPiA+ ID4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtNjQvYm9vdC9kdHMvZnJlZXNjYWxlL2ZzbC1sczEwODhh LmR0c2kKPiA+ID4gYi9hcmNoL2FybTY0L2Jvb3QvZHRzL2ZyZWVzY2FsZS9mc2wtbHMxMDg4YS5k dHNpCj4gPiA+IGluZGV4IDY2MTEzN2YuLjlmNTJiYzkgMTAwNjQ0Cj4gPiA+IC0tLSBhL2FyY2gv YXJtNjQvYm9vdC9kdHMvZnJlZXNjYWxlL2ZzbC1sczEwODhhLmR0c2kKPiA+ID4gKysrIGIvYXJj aC9hcm02NC9ib290L2R0cy9mcmVlc2NhbGUvZnNsLWxzMTA4OGEuZHRzaQo+ID4gPiBAQCAtMTI5 LDE5ICsxMjksMTkgQEAKPiA+ID4gIAl9Owo+ID4gPgo+ID4gPiAgCXRoZXJtYWwtem9uZXMgewo+ ID4gPiAtCQljcHVfdGhlcm1hbDogY3B1LXRoZXJtYWwgewo+ID4gPiArCQljY3Ugewo+ID4gCj4g PiBJcyB0aGlzIGNoYW5nZSByZWFsbHkgbmVjZXNzYXJ5PyAgV2hhdCBkb2VzICdjY3UnIHN0YW5k IGZvcj8KPiBJIHRoaW5rIHNvLiBjY3Ugc3RhbmRzIGZvciBjb3JlIGNsdXN0ZXIgdW5pdC4gY3B1 IGlzIHRvbyBnZW5lcmFsLgo+IE9uIHNvbWUgcGxhdGZvcm1zLCB0aGVyZSBhcmUgbW9yZSB0aGFu IG9uZSBjb3JlIGNsdXN0ZXJzLgo+IEF0IGxlYXN0IHdlIHNob3VsZCBjaGFuZ2UgaXQgdG8gImNv cmUgY2x1c3RlciIgaWYgc2hvcnQgZm9ybSBpcyBub3QgYXBwcm9wcmlhdGUuCgpZZXMsIHBsZWFz ZSBnaXZlIGl0IGEgbW9yZSBkZXNjcmlwdGl2ZSBuYW1lLgoKU2hhd24KCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGlu ZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMu aW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK