From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linutronix.de (146.0.238.70:993) by crypto-ml.lab.linutronix.de with IMAP4-SSL for ; 04 Mar 2019 07:33:20 -0000 Received: from mail.kernel.org ([198.145.29.99]) by Galois.linutronix.de with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1h0i6A-0003Mv-4Z for speck@linutronix.de; Mon, 04 Mar 2019 08:33:18 +0100 Date: Mon, 4 Mar 2019 08:33:09 +0100 From: Greg KH Subject: [MODERATED] Re: [PATCH RFC 3/4] 3 Message-ID: <20190304073309.GC23573@kroah.com> References: <20190304012138.gikabpafseh2swre@treble> <20190304012455.xi23xfddnexvdz2r@treble> MIME-Version: 1.0 In-Reply-To: <20190304012455.xi23xfddnexvdz2r@treble> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit To: speck@linutronix.de List-ID: On Sun, Mar 03, 2019 at 07:24:55PM -0600, speck for Josh Poimboeuf wrote: > From: Josh Poimboeuf > Subject: [PATCH RFC 3/4] x86/speculation/mds: Add SMT warning message > > MDS is vulnerable with SMT. Make that clear with a one-time printk > whenever SMT first gets enabled. > > Signed-off-by: Josh Poimboeuf > --- > arch/x86/kernel/cpu/bugs.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/x86/kernel/cpu/bugs.c b/arch/x86/kernel/cpu/bugs.c > index 9e20aef01d38..346f0f05879d 100644 > --- a/arch/x86/kernel/cpu/bugs.c > +++ b/arch/x86/kernel/cpu/bugs.c > @@ -691,6 +691,8 @@ static void update_mds_branch_idle(void) > static_branch_disable(&mds_idle_clear); > } > > +#define MDS_MSG_SMT "MDS CPU bug present and SMT on, data leak possible. See https://www.kernel.org/doc/html/latest/admin-guide/hw-vuln/mds.html for more details.\n" Why a #define? Just stick that string into the printk message. thanks, greg k-h