From: Greg KH <gregkh@linuxfoundation.org>
To: Debleena Sen <idebleenasen@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [PATCH] Staging: pi433: Fix line over 80 characters issue
Date: Mon, 4 Mar 2019 08:46:50 +0100 [thread overview]
Message-ID: <20190304074650.GC22711@kroah.com> (raw)
In-Reply-To: <1551679530-2635-1-git-send-email-idebleenasen@gmail.com>
On Sun, Mar 03, 2019 at 10:05:30PM -0800, Debleena Sen wrote:
> Delete extra whitespace and tab space to remove
> checkpatch.pl warning:
> WARNING: line over 80 characters
>
> Signed-off-by: Debleena Sen <idebleenasen@gmail.com>
> ---
> drivers/staging/pi433/pi433_if.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
> index b231463..53928af 100644
> --- a/drivers/staging/pi433/pi433_if.c
> +++ b/drivers/staging/pi433/pi433_if.c
> @@ -45,10 +45,10 @@
> #include "pi433_if.h"
> #include "rf69.h"
>
> -#define N_PI433_MINORS BIT(MINORBITS) /*32*/ /* ... up to 256 */
> -#define MAX_MSG_SIZE 900 /* min: FIFO_SIZE! */
> -#define MSG_FIFO_SIZE 65536 /* 65536 = 2^16 */
> -#define NUM_DIO 2
> +#define N_PI433_MINORS BIT(MINORBITS) /*32*/ /* ... up to 256 */
> +#define MAX_MSG_SIZE 900 /* min: FIFO_SIZE! */
> +#define MSG_FIFO_SIZE 65536 /* 65536 = 2^16 */
The comment above should also use a tab, right?
thanks,
greg k-h
next prev parent reply other threads:[~2019-03-04 7:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-04 6:05 [PATCH] Staging: pi433: Fix line over 80 characters issue Debleena Sen
2019-03-04 7:46 ` Greg KH [this message]
2019-03-04 14:25 ` idebleenasen
2019-03-04 14:42 ` [Outreachy kernel] " Julia Lawall
2019-03-04 14:44 ` Debleena Sen
2019-03-04 7:58 ` [Outreachy kernel] " Julia Lawall
-- strict thread matches above, loose matches on Subject: below --
2019-03-05 17:13 Debleena Sen
2019-03-06 9:15 ` Greg KH
[not found] ` <CACw+u4GRhRY5kgjQgd-sYOLp4nfHU-tp_oKfK74i+QR7cnWQNg@mail.gmail.com>
[not found] ` <20190306094415.GA31537@kroah.com>
2019-03-06 9:47 ` Debleena Sen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190304074650.GC22711@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=idebleenasen@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.