From: Baoquan He <bhe@redhat.com>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: linux-kernel@vger.kernel.org, kirill.shutemov@linux.intel.com,
dave.hansen@linux.intel.com, luto@kernel.org,
peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, hpa@zytor.com, x86@kernel.org,
keescook@chromium.org, thgarnie@google.com
Subject: Re: [PATCH v2 0/2] x86/mm/KASLR: Change the granularity of randomization to PUD size in 5-level
Date: Mon, 4 Mar 2019 16:52:10 +0800 [thread overview]
Message-ID: <20190304085210.GY14858@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20190304081529.nuneutcjhoa56fw7@kshutemo-mobl1>
On 03/04/19 at 11:15am, Kirill A. Shutemov wrote:
> On Fri, Mar 01, 2019 at 10:45:02PM +0800, Baoquan He wrote:
> > Hi Kirill,
> >
> > I updated patch per your comments. While I kept the 'paddr' variable and
> > the '0' initilization stuffs. My thought is there are two kinds of mapping
> > in the handling, so keeping these names from old codes can make it more
> > understandable. What do you think?
> >
> > Kind Physical address Virtual address
> > ----------------------------------------------------------------
> > Direct mapping paddr vaddr = paddr+PAGE_OFFSET
> > 1:1 mapping paddr paddr
>
> I agree with your logic and patch looks good to me. But maybe you should
> exmplain this in the comments too?
OK, will add this into code comment, and sent a v3 patchset to wrap all
these changes according to your suggestions. Thanks a lot.
Thanks
Baoquan
next prev parent reply other threads:[~2019-03-04 8:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 0:35 [PATCH v2 0/2] x86/mm/KASLR: Change the granularity of randomization to PUD size in 5-level Baoquan He
2019-02-28 0:35 ` [PATCH v2 1/2] x86/mm/KASLR: Only build one PUD entry of area for real mode trampoline Baoquan He
2019-02-28 0:35 ` [PATCH v2 2/2] x86/mm/KASLR: Change the granularity of randomization to PUD size in 5-level Baoquan He
2019-02-28 9:10 ` [PATCH v2 0/2] " Kirill A. Shutemov
2019-02-28 9:23 ` Baoquan He
2019-02-28 9:55 ` Kirill A. Shutemov
2019-02-28 10:04 ` Baoquan He
2019-02-28 10:30 ` Kirill A. Shutemov
2019-02-28 13:01 ` Baoquan He
2019-03-01 14:45 ` Baoquan He
2019-03-04 8:15 ` Kirill A. Shutemov
2019-03-04 8:52 ` Baoquan He [this message]
2019-02-28 9:29 ` [PATCH v3 " Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190304085210.GY14858@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=thgarnie@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.