From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 2/9] drm/bridge: tc358767: Simplify tc_stream_clock_calc() Date: Mon, 4 Mar 2019 14:20:21 +0200 Message-ID: <20190304122021.GD6325@pendragon.ideasonboard.com> References: <20190226193609.9862-1-andrew.smirnov@gmail.com> <20190226193609.9862-3-andrew.smirnov@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 74BE489289 for ; Mon, 4 Mar 2019 12:20:28 +0000 (UTC) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Andrzej Hajda Cc: Andrey Smirnov , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Chris Healy List-Id: dri-devel@lists.freedesktop.org SGVsbG8sCgpPbiBNb24sIE1hciAwNCwgMjAxOSBhdCAxMDo0MjoyMEFNICswMTAwLCBBbmRyemVq IEhhamRhIHdyb3RlOgo+IE9uIDI2LjAyLjIwMTkgMjA6MzYsIEFuZHJleSBTbWlybm92IHdyb3Rl Ogo+ID4gRHJvcCB0aGUgdXNlIG9mIHRjX3dyaXRlKCkgYXMgd2VsbCBhcyAibWFnaWNseSIgdXNl ZCAicmV0IiBhbmQgImVycjoiCj4gPiBhbmQgcmVwbGFjZSBpdCB3aXRoIGEgc2ltcGxlIGNhbGwg dG8gcmVnbWFwX3dyaXRlKCkuIE5vIGZ1bmN0aW9uYWwKPiA+IGNoYW5nZSBpbnRlbmRlZC4KPiA+ Cj4gPiBTaWduZWQtb2ZmLWJ5OiBBbmRyZXkgU21pcm5vdiA8YW5kcmV3LnNtaXJub3ZAZ21haWwu Y29tPgo+ID4gQ2M6IEFyY2hpdCBUYW5lamEgPGFyY2hpdHRAY29kZWF1cm9yYS5vcmc+Cj4gPiBD YzogQW5kcnplaiBIYWpkYSA8YS5oYWpkYUBzYW1zdW5nLmNvbT4KPiA+IENjOiBMYXVyZW50IFBp bmNoYXJ0IDxMYXVyZW50LnBpbmNoYXJ0QGlkZWFzb25ib2FyZC5jb20+Cj4gPiBDYzogQ2hyaXMg SGVhbHkgPGNwaGVhbHlAZ21haWwuY29tPgo+ID4gQ2M6IEx1Y2FzIFN0YWNoIDxsLnN0YWNoQHBl bmd1dHJvbml4LmRlPgo+ID4gQ2M6IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiA+ IENjOiBsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnCj4gPiAtLS0KPiA+ICBkcml2ZXJzL2dw dS9kcm0vYnJpZGdlL3RjMzU4NzY3LmMgfCA3ICstLS0tLS0KPiA+ICAxIGZpbGUgY2hhbmdlZCwg MSBpbnNlcnRpb24oKyksIDYgZGVsZXRpb25zKC0pCj4gPgo+ID4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9icmlkZ2UvdGMzNTg3NjcuYyBiL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvdGMz NTg3NjcuYwo+ID4gaW5kZXggYjBmODI2NGExMjg1Li44NmViZDQ5MTk0YjcgMTAwNjQ0Cj4gPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL3RjMzU4NzY3LmMKPiA+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9icmlkZ2UvdGMzNTg3NjcuYwo+ID4gQEAgLTUwNCw3ICs1MDQsNiBAQCBzdGF0aWMg aW50IHRjX3B4bF9wbGxfZGlzKHN0cnVjdCB0Y19kYXRhICp0YykKPiA+ICAKPiA+ICBzdGF0aWMg aW50IHRjX3N0cmVhbV9jbG9ja19jYWxjKHN0cnVjdCB0Y19kYXRhICp0YykKPiA+ICB7Cj4gPiAt CWludCByZXQ7Cj4gPiAgCS8qCj4gPiAgCSAqIElmIHRoZSBTdHJlYW0gY2xvY2sgYW5kIExpbmsg U3ltYm9sIGNsb2NrIGFyZQo+ID4gIAkgKiBhc3luY2hyb25vdXMgd2l0aCBlYWNoIG90aGVyLCB0 aGUgdmFsdWUgb2YgTSBjaGFuZ2VzIG92ZXIKPiA+IEBAIC01MjAsMTEgKzUxOSw3IEBAIHN0YXRp YyBpbnQgdGNfc3RyZWFtX2Nsb2NrX2NhbGMoc3RydWN0IHRjX2RhdGEgKnRjKQo+ID4gIAkgKiBN L04gPSBmX1NUUk1DTEsgLyBmX0xTQ0xLCj4gPiAgCSAqCj4gPiAgCSAqLwo+ID4gLQl0Y193cml0 ZShEUDBfVklETU5HRU4xLCAzMjc2OCk7Cj4gPiAtCj4gPiAtCXJldHVybiAwOwo+ID4gLWVycjoK PiA+IC0JcmV0dXJuIHJldDsKPiA+ICsJcmV0dXJuIHJlZ21hcF93cml0ZSh0Yy0+cmVnbWFwLCBE UDBfVklETU5HRU4xLCAzMjc2OCk7Cj4gCj4gCj4gVGhlIHBhdGNoIGxvb2tzIHNlbWFudGljYWxs eSBjb3JyZWN0LCBidXQgeW91IGFyZSBkcm9wcGluZyBoZXJlIGN1c3RvbQo+IGFjY2Vzc29yICh0 Y193cml0ZSkgaW4gZmF2b3Igb2YgcmVnbWFwIEFQSS4KPiAKPiBJIHRoaW5rIHRoZSBiZXN0IHdv dWxkIGJlIGNvbnNpc3RlbnQgYWNyb3NzIHRoZSB3aG9sZSBkcml2ZXI6IGVpdGhlciB1c2UKPiBv bmx5wqAgYWNjZXNzb3JzLCBlaXRoZXIgZHJvcCB0aGVtIGVudGlyZWx5IGFuZCB1c2UgcmVnbWFw IEFQSS4KCkkgYWdyZWUgd2l0aCB0aGlzLiBUaGUgdGNfd3JpdGUgbWFjcm8gd2l0aCBpdHMgZ290 byBlcnIgaXMgcHJldHR5IG5hc3R5LAphbmQgSSdkIGxpa2UgdG8gc2VlIGl0IHJlbW92ZWQgZnJv bSB0aGUgd2hvbGUgZHJpdmVyLCBvciBhdCBsZWFzdApyZXBsYWNlZCB3aXRoIGFuIGFjY2Vzc29y IHRoYXQgd291bGRuJ3QgaGlkZSB0aGUgZ290by4KCj4gQW5kIGl0IHdvdWxkIGJlIGdvb2QgdG8g aGF2ZSBjb21tZW50IG9mIHRoZSBvcmlnaW5hbCBhdXRob3JzIGFib3V0IHRoaXMKPiBjaGFuZ2Uu Cj4gCj4gPiAgfQo+ID4gIAo+ID4gIHN0YXRpYyBpbnQgdGNfYXV4X2xpbmtfc2V0dXAoc3RydWN0 IHRjX2RhdGEgKnRjKQoKLS0gClJlZ2FyZHMsCgpMYXVyZW50IFBpbmNoYXJ0Cl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxp c3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D85FC43381 for ; Mon, 4 Mar 2019 12:20:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 487FC20830 for ; Mon, 4 Mar 2019 12:20:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="BbnFOFST" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726413AbfCDMU3 (ORCPT ); Mon, 4 Mar 2019 07:20:29 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:36224 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726029AbfCDMU3 (ORCPT ); Mon, 4 Mar 2019 07:20:29 -0500 Received: from pendragon.ideasonboard.com (dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi [IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id ED1D1322; Mon, 4 Mar 2019 13:20:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1551702027; bh=UUt7uxYVF+P4/h6B+6jShHNIZvXptTdwrd75a0yc2js=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BbnFOFSTgPy3aOlER6Ia45QvtsOh2N5FzlvoDBH1oPK+5qRlpra5SfOLxSe+scdlb A0XxI7rrfkc66nYowMkGUsOUeTDLgK7wG++UvMW4K7W4Ksxax5BEJB/mxcZXshl3hj vb3odFVozf/iUIJRhOzlV+ei3jBQs5hdjS5BvZ74= Date: Mon, 4 Mar 2019 14:20:21 +0200 From: Laurent Pinchart To: Andrzej Hajda Cc: Andrey Smirnov , dri-devel@lists.freedesktop.org, Archit Taneja , Chris Healy , Lucas Stach , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/9] drm/bridge: tc358767: Simplify tc_stream_clock_calc() Message-ID: <20190304122021.GD6325@pendragon.ideasonboard.com> References: <20190226193609.9862-1-andrew.smirnov@gmail.com> <20190226193609.9862-3-andrew.smirnov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Mon, Mar 04, 2019 at 10:42:20AM +0100, Andrzej Hajda wrote: > On 26.02.2019 20:36, Andrey Smirnov wrote: > > Drop the use of tc_write() as well as "magicly" used "ret" and "err:" > > and replace it with a simple call to regmap_write(). No functional > > change intended. > > > > Signed-off-by: Andrey Smirnov > > Cc: Archit Taneja > > Cc: Andrzej Hajda > > Cc: Laurent Pinchart > > Cc: Chris Healy > > Cc: Lucas Stach > > Cc: dri-devel@lists.freedesktop.org > > Cc: linux-kernel@vger.kernel.org > > --- > > drivers/gpu/drm/bridge/tc358767.c | 7 +------ > > 1 file changed, 1 insertion(+), 6 deletions(-) > > > > diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c > > index b0f8264a1285..86ebd49194b7 100644 > > --- a/drivers/gpu/drm/bridge/tc358767.c > > +++ b/drivers/gpu/drm/bridge/tc358767.c > > @@ -504,7 +504,6 @@ static int tc_pxl_pll_dis(struct tc_data *tc) > > > > static int tc_stream_clock_calc(struct tc_data *tc) > > { > > - int ret; > > /* > > * If the Stream clock and Link Symbol clock are > > * asynchronous with each other, the value of M changes over > > @@ -520,11 +519,7 @@ static int tc_stream_clock_calc(struct tc_data *tc) > > * M/N = f_STRMCLK / f_LSCLK > > * > > */ > > - tc_write(DP0_VIDMNGEN1, 32768); > > - > > - return 0; > > -err: > > - return ret; > > + return regmap_write(tc->regmap, DP0_VIDMNGEN1, 32768); > > > The patch looks semantically correct, but you are dropping here custom > accessor (tc_write) in favor of regmap API. > > I think the best would be consistent across the whole driver: either use > only  accessors, either drop them entirely and use regmap API. I agree with this. The tc_write macro with its goto err is pretty nasty, and I'd like to see it removed from the whole driver, or at least replaced with an accessor that wouldn't hide the goto. > And it would be good to have comment of the original authors about this > change. > > > } > > > > static int tc_aux_link_setup(struct tc_data *tc) -- Regards, Laurent Pinchart