From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6806AC43381 for ; Mon, 4 Mar 2019 13:53:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 290ED20652 for ; Mon, 4 Mar 2019 13:53:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="3d0IEQOG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726635AbfCDNxI (ORCPT ); Mon, 4 Mar 2019 08:53:08 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:45742 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725997AbfCDNxH (ORCPT ); Mon, 4 Mar 2019 08:53:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=eQhTgAgD9P1gPm332/+MPCYBCIZfyIqbBMiHAU9DVkg=; b=3d0IEQOGENDs5wExdNBPCWYXoQ 8LCY1vTI7CMXdZr14Tm39HEC9XQDzBJzZHDZsmJxoIIS1962PxvKYgEYzRh+OI1/mRvjZPhDGCGQO qWnn3xytuaGw0oGwjesmCvpO4FVFWGsuvfrCrl1aG/CB0PQm+GhmqDQ4bDw8pghJTrM8=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1h0o1h-0003iJ-3Y; Mon, 04 Mar 2019 14:53:05 +0100 Date: Mon, 4 Mar 2019 14:53:05 +0100 From: Andrew Lunn To: Vladimir Oltean Cc: Linus Walleij , Florian Fainelli , netdev Subject: Re: [PATCH 3/3] net: dsa: Add Vitesse VSC73xx DSA router driver Message-ID: <20190304135305.GD26378@lunn.ch> References: <3ad23735-38be-16ea-3bd0-c77eccc22f16@gmail.com> <20190303120839.17868-1-olteanv@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > I do see that neither vitesse-vsc73xx nor rtl8366 do implement the bridge > membership callbacks, and as I don't happen to know nearly enough about DSA, I > wonder at what moment in time does forwarding get activated between ports. If those callbacks are not implement, it means the software bridge does the forwarding. The hardware is not used. The DSA model allows you to start simple and just implement something like a port multiplexor. All frames get passed to the host, and the host then decides what to do with them. You can then add more callbacks and make more use of the hardware, e.g. get the hardware to bridge between ports. If the hardware is not capable of supporting vlan filtering, but you can support simpler modes, you should implement what you can, and return an error when asked to do something which it cannot support. Andrew