Re: [Outreachy kernel] [PATCH v2] Staging: wlan-ng: Fix parenthesis alignment

[Greg KH <greg@kroah.com>]

On Mon, Mar 04, 2019 at 05:19:18PM +0200, Daniela Mormocea wrote:
> Fix alignment issue with parenthesis.
> 
> Signed-off-by: Daniela Mormocea <daniela.mormocea@gmail.com>
> ---
>  drivers/staging/wlan-ng/cfg80211.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)

What changed from v1?

That always belongs below the --- line.

> 
> diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
> index 8a862f7..7c4e8f1f8 100644
> --- a/drivers/staging/wlan-ng/cfg80211.c
> +++ b/drivers/staging/wlan-ng/cfg80211.c
> @@ -332,8 +332,7 @@ static int prism2_scan(struct wiphy *wiphy,
>  		(i < request->n_channels) && i < ARRAY_SIZE(prism2_channels);
>  		i++)
>  		msg1.channellist.data.data[i] =
> -			ieee80211_frequency_to_channel(
> -				request->channels[i]->center_freq);
> +			ieee80211_frequency_to_channel(request->channels[i]->center_freq);

You just violated another coding style rule by doing this :(

The original code is fine, leave it as-is please.

>  	msg1.channellist.data.len = request->n_channels;
>  
>  	msg1.maxchanneltime.data = 250;
> @@ -372,11 +371,9 @@ static int prism2_scan(struct wiphy *wiphy,
>  			(const u8 *)&msg2.bssid.data.data,
>  			msg2.timestamp.data, msg2.capinfo.data,
>  			msg2.beaconperiod.data,
> -			ie_buf,
> -			ie_len,
> +			ie_buf, ie_len,

This change has nothing to do with the subject :(

thanks,

greg k-h