From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECCCAC43381 for ; Mon, 4 Mar 2019 15:59:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BDE6A206B6 for ; Mon, 4 Mar 2019 15:59:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kkdYXhiB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BDE6A206B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=s6pzWnJrPham+fkqfEZ/DwFzpaVmFcCOosfFl6kX+sA=; b=kkdYXhiBrsVfjH Xa4s+Bma1e0JHYzpuy+jvurLc4bGP8Dd/FC3k1eYP9H59977v1gtQNB4kpjQ3RbIgWfxBbopmf2Rs B/hfk+kc44TSGS8HjmcmgyzKiuTmNVSLEU0x93nuBiz4LCHEEXoTorqj7NIXNdrjxsbwTroEd+Kjw MBonQOh67ToRpfJEF/8BHHfSdJ6FztQkw6ab4cxe2CqkBHiXpunS835R13eGxn43fgZ4ignr9Fn5J KMFqoUfM+I/OqfcWPD3Rg+ENMHk6/p/OrxgrWaI/8j9mqCZDCKzNaQcsGtol+BOlvMGtcNGtbmen1 5i1Fy8gUdq8tGLSLLyNA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h0q0D-00038f-2M; Mon, 04 Mar 2019 15:59:41 +0000 Received: from mga12.intel.com ([192.55.52.136]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h0q09-00038I-DU for linux-arm-kernel@lists.infradead.org; Mon, 04 Mar 2019 15:59:39 +0000 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Mar 2019 07:59:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,440,1544515200"; d="scan'208";a="148460740" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by fmsmga002.fm.intel.com with SMTP; 04 Mar 2019 07:59:32 -0800 Received: by stinkbox (sSMTP sendmail emulation); Mon, 04 Mar 2019 17:59:31 +0200 Date: Mon, 4 Mar 2019 17:59:31 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Maxime Ripard Subject: Re: [PATCH 2/7] drm/edid: Allow to ignore the audio EDID data Message-ID: <20190304155931.GW20097@intel.com> References: <4914bea9fc3ef3deaffa39ab691dbd9a76461e97.1551711042.git-series.maxime.ripard@bootlin.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4914bea9fc3ef3deaffa39ab691dbd9a76461e97.1551711042.git-series.maxime.ripard@bootlin.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190304_075937_467875_765595FF X-CRM114-Status: GOOD ( 21.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: eben@raspberrypi.org, David Airlie , Maarten Lankhorst , dri-devel@lists.freedesktop.org, Paul Kocialkowski , Sean Paul , Thomas Petazzoni , Daniel Vetter , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 04, 2019 at 03:52:35PM +0100, Maxime Ripard wrote: > In some cases, in order to accomodate with displays with poor EDIDs, we > need to ignore that the monitor alledgedly supports audio output and > disable the audio output. > = > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/drm_edid.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > = > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > index 990b1909f9d7..c0258b011bb2 100644 > --- a/drivers/gpu/drm/drm_edid.c > +++ b/drivers/gpu/drm/drm_edid.c > @@ -4190,6 +4190,11 @@ bool drm_detect_hdmi_monitor(struct edid *edid) > } > EXPORT_SYMBOL(drm_detect_hdmi_monitor); > = > +static bool ignore_edid_audio =3D false; > +module_param(ignore_edid_audio, bool, 0644); > +MODULE_PARM_DESC(ignore_edid_audio, > + "Ignore the EDID and always consider that a monitor doesn't have audi= o capabilities"); > + I would suggest that this is not the best apporach. Years of experience from i915 says that more modparams means random forums full of people trading cargo culted settings. And as soon as the average user comes across the magic incantation that works they are likely to not file the appropriate bug report. Also years later we still see people using modparams that stopped working five hardware generations ago. So at least for i915 new modparams are generally frowned upon. Bad EDIDs at least should be quirked. Which means we really need the bug reports, and hence a modparam can be somewhat counter productive. For allowing the user to force the DVI vs. HDMI and audio vs. not i915 does have the "audio" connector property. Other drivers could adopt the same thing. Though I'm not sure even i915 should be exposing this for the reasons already mentioned. There is one hardware generation where it can actually be useful on i915 as the hardware is only capably of sending infoframes/audio to a single HDMI port at a time. So with this property the user can at least select which display gets to do those things. I do agree that there is an unfortnate problem with fbcon vs. initial property values. I've sometimes pondered about exposing kms properties in a generic fashion via sysfs and/or kernel cmdline somehow. IIRC devicetree/something similar has also been proposed occasionally to solve this problem. > /** > * drm_detect_monitor_audio - check monitor audio capability > * @edid: EDID block to scan > @@ -4209,6 +4214,9 @@ bool drm_detect_monitor_audio(struct edid *edid) > bool has_audio =3D false; > int start_offset, end_offset; > = > + if (ignore_edid_audio) > + goto end; > + > edid_ext =3D drm_find_cea_extension(edid); > if (!edid_ext) > goto end; > -- = > git-series 0.9.1 > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- = Ville Syrj=E4l=E4 Intel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 2/7] drm/edid: Allow to ignore the audio EDID data Date: Mon, 4 Mar 2019 17:59:31 +0200 Message-ID: <20190304155931.GW20097@intel.com> References: <4914bea9fc3ef3deaffa39ab691dbd9a76461e97.1551711042.git-series.maxime.ripard@bootlin.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9D69E89CAD for ; Mon, 4 Mar 2019 15:59:37 +0000 (UTC) Content-Disposition: inline In-Reply-To: <4914bea9fc3ef3deaffa39ab691dbd9a76461e97.1551711042.git-series.maxime.ripard@bootlin.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Maxime Ripard Cc: eben@raspberrypi.org, David Airlie , dri-devel@lists.freedesktop.org, Paul Kocialkowski , Sean Paul , Thomas Petazzoni , Daniel Vetter , linux-arm-kernel@lists.infradead.org List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBNYXIgMDQsIDIwMTkgYXQgMDM6NTI6MzVQTSArMDEwMCwgTWF4aW1lIFJpcGFyZCB3 cm90ZToKPiBJbiBzb21lIGNhc2VzLCBpbiBvcmRlciB0byBhY2NvbW9kYXRlIHdpdGggZGlzcGxh eXMgd2l0aCBwb29yIEVESURzLCB3ZQo+IG5lZWQgdG8gaWdub3JlIHRoYXQgdGhlIG1vbml0b3Ig YWxsZWRnZWRseSBzdXBwb3J0cyBhdWRpbyBvdXRwdXQgYW5kCj4gZGlzYWJsZSB0aGUgYXVkaW8g b3V0cHV0Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IE1heGltZSBSaXBhcmQgPG1heGltZS5yaXBhcmRA Ym9vdGxpbi5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fZWRpZC5jIHwgOCArKysr KysrKwo+ICAxIGZpbGUgY2hhbmdlZCwgOCBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9kcm1fZWRpZC5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9lZGlkLmMK PiBpbmRleCA5OTBiMTkwOWY5ZDcuLmMwMjU4YjAxMWJiMiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vZHJtX2VkaWQuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZWRpZC5jCj4g QEAgLTQxOTAsNiArNDE5MCwxMSBAQCBib29sIGRybV9kZXRlY3RfaGRtaV9tb25pdG9yKHN0cnVj dCBlZGlkICplZGlkKQo+ICB9Cj4gIEVYUE9SVF9TWU1CT0woZHJtX2RldGVjdF9oZG1pX21vbml0 b3IpOwo+ICAKPiArc3RhdGljIGJvb2wgaWdub3JlX2VkaWRfYXVkaW8gPSBmYWxzZTsKPiArbW9k dWxlX3BhcmFtKGlnbm9yZV9lZGlkX2F1ZGlvLCBib29sLCAwNjQ0KTsKPiArTU9EVUxFX1BBUk1f REVTQyhpZ25vcmVfZWRpZF9hdWRpbywKPiArCQkgIklnbm9yZSB0aGUgRURJRCBhbmQgYWx3YXlz IGNvbnNpZGVyIHRoYXQgYSBtb25pdG9yIGRvZXNuJ3QgaGF2ZSBhdWRpbyBjYXBhYmlsaXRpZXMi KTsKPiArCgpJIHdvdWxkIHN1Z2dlc3QgdGhhdCB0aGlzIGlzIG5vdCB0aGUgYmVzdCBhcHBvcmFj aC4gWWVhcnMgb2YgZXhwZXJpZW5jZQpmcm9tIGk5MTUgc2F5cyB0aGF0IG1vcmUgbW9kcGFyYW1z IG1lYW5zIHJhbmRvbSBmb3J1bXMgZnVsbCBvZiBwZW9wbGUKdHJhZGluZyAgY2FyZ28gY3VsdGVk IHNldHRpbmdzLiBBbmQgYXMgc29vbiBhcyB0aGUgYXZlcmFnZSB1c2VyIGNvbWVzCmFjcm9zcyB0 aGUgbWFnaWMgaW5jYW50YXRpb24gdGhhdCB3b3JrcyB0aGV5IGFyZSBsaWtlbHkgdG8gbm90IGZp bGUgdGhlCmFwcHJvcHJpYXRlIGJ1ZyByZXBvcnQuIEFsc28geWVhcnMgbGF0ZXIgd2Ugc3RpbGwg c2VlIHBlb3BsZSB1c2luZwptb2RwYXJhbXMgdGhhdCBzdG9wcGVkIHdvcmtpbmcgZml2ZSBoYXJk d2FyZSBnZW5lcmF0aW9ucyBhZ28uIFNvIGF0CmxlYXN0IGZvciBpOTE1IG5ldyBtb2RwYXJhbXMg YXJlIGdlbmVyYWxseSBmcm93bmVkIHVwb24uCgpCYWQgRURJRHMgYXQgbGVhc3Qgc2hvdWxkIGJl IHF1aXJrZWQuIFdoaWNoIG1lYW5zIHdlIHJlYWxseSBuZWVkIHRoZQpidWcgcmVwb3J0cywgYW5k IGhlbmNlIGEgbW9kcGFyYW0gY2FuIGJlIHNvbWV3aGF0IGNvdW50ZXIgcHJvZHVjdGl2ZS4KCkZv ciBhbGxvd2luZyB0aGUgdXNlciB0byBmb3JjZSB0aGUgRFZJIHZzLiBIRE1JIGFuZCBhdWRpbyB2 cy4gbm90IGk5MTUKZG9lcyBoYXZlIHRoZSAiYXVkaW8iIGNvbm5lY3RvciBwcm9wZXJ0eS4gT3Ro ZXIgZHJpdmVycyBjb3VsZCBhZG9wdCB0aGUKc2FtZSB0aGluZy4gVGhvdWdoIEknbSBub3Qgc3Vy ZSBldmVuIGk5MTUgc2hvdWxkIGJlIGV4cG9zaW5nIHRoaXMgZm9yCnRoZSByZWFzb25zIGFscmVh ZHkgbWVudGlvbmVkLiBUaGVyZSBpcyBvbmUgaGFyZHdhcmUgZ2VuZXJhdGlvbiB3aGVyZQppdCBj YW4gYWN0dWFsbHkgYmUgdXNlZnVsIG9uIGk5MTUgYXMgdGhlIGhhcmR3YXJlIGlzIG9ubHkgY2Fw YWJseSBvZgpzZW5kaW5nIGluZm9mcmFtZXMvYXVkaW8gdG8gYSBzaW5nbGUgSERNSSBwb3J0IGF0 IGEgdGltZS4gU28gd2l0aCB0aGlzCnByb3BlcnR5IHRoZSB1c2VyIGNhbiBhdCBsZWFzdCBzZWxl Y3Qgd2hpY2ggZGlzcGxheSBnZXRzIHRvIGRvIHRob3NlCnRoaW5ncy4KCkkgZG8gYWdyZWUgdGhh dCB0aGVyZSBpcyBhbiB1bmZvcnRuYXRlIHByb2JsZW0gd2l0aCBmYmNvbiB2cy4KaW5pdGlhbCBw cm9wZXJ0eSB2YWx1ZXMuIEkndmUgc29tZXRpbWVzIHBvbmRlcmVkIGFib3V0IGV4cG9zaW5nCmtt cyBwcm9wZXJ0aWVzIGluIGEgZ2VuZXJpYyBmYXNoaW9uIHZpYSBzeXNmcyBhbmQvb3Iga2VybmVs CmNtZGxpbmUgc29tZWhvdy4gSUlSQyBkZXZpY2V0cmVlL3NvbWV0aGluZyBzaW1pbGFyIGhhcyBh bHNvIGJlZW4KcHJvcG9zZWQgb2NjYXNpb25hbGx5IHRvIHNvbHZlIHRoaXMgcHJvYmxlbS4KCj4g IC8qKgo+ICAgKiBkcm1fZGV0ZWN0X21vbml0b3JfYXVkaW8gLSBjaGVjayBtb25pdG9yIGF1ZGlv IGNhcGFiaWxpdHkKPiAgICogQGVkaWQ6IEVESUQgYmxvY2sgdG8gc2Nhbgo+IEBAIC00MjA5LDYg KzQyMTQsOSBAQCBib29sIGRybV9kZXRlY3RfbW9uaXRvcl9hdWRpbyhzdHJ1Y3QgZWRpZCAqZWRp ZCkKPiAgCWJvb2wgaGFzX2F1ZGlvID0gZmFsc2U7Cj4gIAlpbnQgc3RhcnRfb2Zmc2V0LCBlbmRf b2Zmc2V0Owo+ICAKPiArCWlmIChpZ25vcmVfZWRpZF9hdWRpbykKPiArCQlnb3RvIGVuZDsKPiAr Cj4gIAllZGlkX2V4dCA9IGRybV9maW5kX2NlYV9leHRlbnNpb24oZWRpZCk7Cj4gIAlpZiAoIWVk aWRfZXh0KQo+ICAJCWdvdG8gZW5kOwo+IC0tIAo+IGdpdC1zZXJpZXMgMC45LjEKPiBfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IGRyaS1kZXZlbCBtYWls aW5nIGxpc3QKPiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwKCi0tIApWaWxsZSBT eXJqw6Rsw6QKSW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRl dmVs