From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: Simplify i830 DVO 2x clock handling Date: Mon, 4 Mar 2019 18:16:32 +0200 Message-ID: <20190304161632.GX20097@intel.com> References: <20190304134113.13024-1-ville.syrjala@linux.intel.com> <155171474959.18705.17582274098311462977@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id E29B089D39 for ; Mon, 4 Mar 2019 16:16:35 +0000 (UTC) Content-Disposition: inline In-Reply-To: <155171474959.18705.17582274098311462977@skylake-alporthouse-com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBNYXIgMDQsIDIwMTkgYXQgMDM6NTI6MzBQTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IFF1b3RpbmcgVmlsbGUgU3lyamFsYSAoMjAxOS0wMy0wNCAxMzo0MToxMykKPiA+IEZy b206IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiAK PiA+IExldCdzIGp1c3QgYWx3YXlzIGVuYWJsZSB0aGUgRFZPIDJ4IGNsb2NrIG9uIGk4MzAuIFRo aXMgd2F5IHdlIGRvbid0Cj4gPiBoYXZlIHRvIHRyYWNrIGlmIERWTyBpcyBiZWluZyB1c2VkIG9y IG5vdC4gVGhlIHNwZWMgZG9lcyBzdWdnZXN0IHdlCj4gPiBzaG91bGQgZGlzYWJsZSB0aGUgY2xv Y2sgd2hlbiBpdCBpc24ndCBuZWVkZWQsIGJ1dCB0aGlzIGRvZXMgYXBwZWFyCj4gPiB0byB3b3Jr IGp1c3QgZmluZS4KPiAKPiBBbmQgYWZ0ZXIgaTgzMCwgMlhfTU9ERSBzZWVtcyB0byBiZSB0aGUg ZGVmYXVsdD8gV2hlcmVhcyB0aGUgb25seSByZWFzb24KPiBmb3IgaTgzMCBiZWluZyBzcGVjaWFs IGlzIHRoYXQgYm90aCBwaXBlcyBtdXN0IGJlIHVzaW5nIHRoZSBzYW1lIG1vZGUsCj4gZXJnbyB3 ZSBkaWRuJ3QgZG8gZWl0aGVyIChvciBzb21ldGhpbmcgbGlrZSB0aGF0KS4KClBvc3QgaTgzMCB0 aGUgaHcgd2FzIGZpeGVkIHNvIHdlIG9ubHkgaGF2ZSB0byBlbmFibGUgdGhlIDJ4IGNsb2NrCndo ZW4gdGhlIHBpcGUgaXMgZHJpdmluZyBhIERWTyBwb3J0LiBEcml2aW5nIHRoZSBDUlQgYW5kIExW RFMgcG9ydHMKZG9lcyBub3QgcmVxdWlyZSB0aGUgMnggY2xvY2suCgo+IAo+ID4gVGhpcyByZW1v dmVzIGFub3RoZXIgY3J0Yy0+Y29uZmlnIHVzYWdlLgo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBW aWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+ID4gLS0tCj4g PiBAQCAtMTQ2OCwyNiArMTQ1NSwxMiBAQCBzdGF0aWMgdm9pZCBpOXh4X2VuYWJsZV9wbGwoc3Ry dWN0IGludGVsX2NydGMgKmNydGMsCj4gPiAgICAgICAgIC8qCj4gPiAgICAgICAgICAqIEFwcGFy ZW50bHkgd2UgbmVlZCB0byBoYXZlIFZHQSBtb2RlIGVuYWJsZWQgcHJpb3IgdG8gY2hhbmdpbmcK PiA+ICAgICAgICAgICogdGhlIFAxL1AyIGRpdmlkZXJzLiBPdGhlcndpc2UgdGhlIERQTEwgd2ls bCBrZWVwIHVzaW5nIHRoZSBvbGQKPiA+ICAgICAgICAgICogZGl2aWRlcnMsIGV2ZW4gdGhvdWdo IHRoZSByZWdpc3RlciB2YWx1ZSBkb2VzIGNoYW5nZS4KPiA+ICAgICAgICAgICovCj4gPiAtICAg ICAgIEk5MTVfV1JJVEUocmVnLCAwKTsKPiA+IC0KPiA+ICsgICAgICAgSTkxNV9XUklURShyZWcs IGRwbGwgJiB+RFBMTF9WR0FfTU9ERV9ESVMpOwo+IAo+IFRoaXMgbG9va3MgdG8gYmUgYSBzZXBh cmF0ZSB0d2Vhaz8KCkkgZGlkbid0IHdhbnQgdG8gdGVybXBvcmFyaWx5IGRpc2FibGUgdGhlIERQ TEwsIGV2ZW4gZm9yIGEgbWluaXNjdWxlCmFtb3VudCBvZiB0aW1lLiBTaW5jZSB0aGUgb2xkIGNv ZGUgZGlkIHdvcmsgSSBzdXBwb3NlIGl0J3Mgbm90CnJlYWxseSBuZWVkZWQsIGJ1dCB0aGlzIHNl ZW1zIG1vcmUgY29uc2lzdGVudCB3aXRoIHRoZSB3aG9sZSBwcmVtaXNlCm9mIGtlZXBpbmcgYm90 aCBEUExMcyBvbiBhbGwgdGhlIHRpbWUuCgpJIHN1cHBvc2UgSSBjb3VsZCBleHRyYWN0IHRoaXMg dG8gYSBzZXBhcmF0ZSBwYXRjaCBmb3IgY2xhcml0eS4KCj4gCj4gPiAgICAgICAgIEk5MTVfV1JJ VEUocmVnLCBkcGxsKTsKPiA+ICAKPiA+ICAgICAgICAgLyogV2FpdCBmb3IgdGhlIGNsb2NrcyB0 byBzdGFiaWxpemUuICovCj4gCj4gPiBAQCAtNzQ5NCw3ICs3NDU3LDE5IEBAIHN0YXRpYyB2b2lk IGk4eHhfY29tcHV0ZV9kcGxsKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjLAo+ID4gICAgICAgICAg ICAgICAgICAgICAgICAgZHBsbCB8PSBQTExfUDJfRElWSURFX0JZXzQ7Cj4gPiAgICAgICAgIH0K PiA+ICAKPiA+IC0gICAgICAgaWYgKCFJU19JODMwKGRldl9wcml2KSAmJgo+ID4gKyAgICAgICAv Kgo+ID4gKyAgICAgICAgKiBCc3BlYzoKPiA+ICsgICAgICAgICogIltBbG1hZG9yIEVycmF0YX06 IEZvciB0aGUgY29ycmVjdCBvcGVyYXRpb24gb2YgdGhlIG11eGVkIERWTyBwaW5zCj4gPiArICAg ICAgICAqICAoR0RFVlNFTEIvIEkgMiBDZGF0YSwgR0lSREJZL0kgMiBDQ2xrKSBhbmQgKEdGUkFN RUIvRFZJX0RhdGEsCj4gPiArICAgICAgICAqICBHVFJEWUIvRFZJX0Nsayk6IEJpdCAzMSAoRFBM TCBWQ08gRW5hYmxlKSBhbmQgQml0IDMwICgyWCBDbG9jawo+ID4gKyAgICAgICAgKiAgRW5hYmxl KSBtdXN0IGJlIHNldCB0byDigJwx4oCdIGluIGJvdGggdGhlIERQTEwgQSBDb250cm9sIFJlZ2lz dGVyCj4gPiArICAgICAgICAqICAoMDYwMTRoLTA2MDE3aCkgYW5kIERQTEwgQiBDb250cm9sIFJl Z2lzdGVyICgwNjAxOGgtMDYwMUJoKS4iCj4gPiArICAgICAgICAqCj4gPiArICAgICAgICAqIEZv ciBzaW1wbGljaXR5IFdlIHNpbXBseSBrZWVwIGJvdGggYml0cyBhbHdheXMgZW5hYmxlZCBpbgo+ ID4gKyAgICAgICAgKiBib3RoIERQTExTLiBUaGUgc3BlYyBzYXlzIHdlIHNob3VsZCBkaXNhYmxl IHRoZSBEVk8gMlggY2xvY2sKPiA+ICsgICAgICAgICogd2hlbiBub3QgbmVlZGVkLCBidXQgdGhp cyBzZWVtcyB0byB3b3JrIGZpbmUgaW4gcHJhY3RpY2UuCj4gPiArICAgICAgICAqLwo+ID4gKyAg ICAgICBpZiAoSVNfSTgzMChkZXZfcHJpdikgfHwKPiA+ICAgICAgICAgICAgIGludGVsX2NydGNf aGFzX3R5cGUoY3J0Y19zdGF0ZSwgSU5URUxfT1VUUFVUX0RWTykpCj4gPiAgICAgICAgICAgICAg ICAgZHBsbCB8PSBEUExMX0RWT18yWF9NT0RFOwo+IAo+IElzIFZHQS9DUlQgYSBuYXRpdmUgZW5j b2Rlcj8gVGhhdCBtaWdodCBiZSBhIHVzZWZ1bCB0ZXN0IHRvIGNoZWNrIHRoYXQKPiBzdGlsbCB3 b3Jrcy4KClllcywgYW5kIHllcyBpdCBzdGlsbCB3b3Jrcy4KCj4gCj4gSSBjb3VsZG4ndCBzZWUg YW55dGhpbmcgeW91IG1pc3NlZCBmb3IgRFBMTF9EVk9fMlhfTU9ERSwgc28gaGFwcHkgdGhhdAo+ IHRoaXMgZG9lcyB3aGF0IGl0IHNheXMgb24gdGhlIHRpbiwgYW5kIEkgdHJ1c3QgdGhhdCB5b3Ug YWN0dWFsbHkgcmFuCj4gdGhpcyBvbiBhbiBpODMwLi4uCgpJbmRlZWQgSSBkaWQuIEFuZCBJIGFs c28gdGVzdGVkIHRoZSAncy8wL2RwbGwgJiB+RFBMTF9WR0FfTU9ERV9ESVMvJwpjaGFuZ2Ugb24g bXkgY3RnIGFzIHRob3NlIGFyZSBrbm93biB0byBzdWZmZXIgZnJvbSB0aGUgcDEvcDIgZGl2aWRl cnMKbm90IGxhdGNoaW5nIGlzc3VlLiBUaGUgbmV3IHNlcXVlbmNlIHN0aWxsIGZvcmNlcyBwMS9w MiB0byBsYXRjaC4KCj4gCj4gUmV2aWV3ZWQtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMt d2lsc29uLmNvLnVrPgoKVGhhbmtzLiAKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxp bmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4