All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Debleena Sen <idebleenasen@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [PATCH v3] Staging: pi433: Fix line over 80 characters issue
Date: Mon, 4 Mar 2019 20:01:30 +0100	[thread overview]
Message-ID: <20190304190130.GC13830@kroah.com> (raw)
In-Reply-To: <1551720850-101768-1-git-send-email-idebleenasen@gmail.com>

On Mon, Mar 04, 2019 at 09:34:10AM -0800, Debleena Sen wrote:
> Delete extra whitespace and tab space and use one tab space to
> remove the checkpatch.pl warning:
> WARNING: line over 80 characters
> 
> Signed-off-by: Debleena Sen <idebleenasen@gmail.com>
> 
> Changes in v3:
> 	- Add version change log
> Changes in v2:
> 	- Add "and use one tab space" to the log message
> ---
>  drivers/staging/pi433/pi433_if.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

The "changes in" lines go below the --- line, not above it :(

(note, one kernel subsystem does want it above the line, the graphics
developers.  But they are crazy anyway and like doing things
differently, so don't worry about them just yet...)

thanks,

greg k-h


  reply	other threads:[~2019-03-04 19:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-04 17:34 [PATCH v3] Staging: pi433: Fix line over 80 characters issue Debleena Sen
2019-03-04 19:01 ` Greg KH [this message]
2019-03-04 19:30   ` Debleena Sen
2019-03-05  7:03     ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2019-03-03  7:46 Debleena Sen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190304190130.GC13830@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=idebleenasen@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.