Re: [PATCH] staging: greybus: Add brackets to avoid precedence issues

[Greg KH <gregkh@linuxfoundation.org>]

On Mon, Mar 04, 2019 at 11:09:47PM +0530, Nishka Dasgupta wrote:
> Add parentheses around arguments to avoid precedence issues. Issue found
> by Checkpatch.
> 
> Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
> ---
>  drivers/staging/greybus/camera.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/greybus/camera.c b/drivers/staging/greybus/camera.c
> index 615c8e7fd51e..7b653a4fd63f 100644
> --- a/drivers/staging/greybus/camera.c
> +++ b/drivers/staging/greybus/camera.c
> @@ -180,9 +180,9 @@ static const struct gb_camera_fmt_info *gb_camera_get_format_info(u16 gb_fmt)
>  
>  #define GB_CAMERA_MAX_SETTINGS_SIZE	8192
>  
> -#define gcam_dbg(gcam, format...)	dev_dbg(&gcam->bundle->dev, format)
> -#define gcam_info(gcam, format...)	dev_info(&gcam->bundle->dev, format)
> -#define gcam_err(gcam, format...)	dev_err(&gcam->bundle->dev, format)
> +#define gcam_dbg((gcam), format...)	dev_dbg(&gcam->bundle->dev, format)
> +#define gcam_info((gcam), format...)	dev_info(&gcam->bundle->dev, format)
> +#define gcam_err((gcam), format...)	dev_err(&gcam->bundle->dev, format)

Please explain how adding an extra () helps anything here.

I think checkpatch is very confused.  Always use your brain when running
it, as it is just a perl script and sometimes gets things wrong (like
here.)

thanks,

greg k-h