From: Greg KH <gregkh@linuxfoundation.org>
To: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [PATCH] staging: octeon-usb: Add brackets to avoid precedence issues
Date: Mon, 4 Mar 2019 20:03:11 +0100 [thread overview]
Message-ID: <20190304190311.GE13830@kroah.com> (raw)
In-Reply-To: <20190304175753.543-1-nishka.dasgupta@yahoo.com>
On Mon, Mar 04, 2019 at 11:27:53PM +0530, Nishka Dasgupta wrote:
> Add parentheses around macro arguments to avoid precedence issues. Issue
> found with Checkpatch.
>
> Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
> ---
> drivers/staging/octeon-usb/octeon-hcd.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/octeon-usb/octeon-hcd.h b/drivers/staging/octeon-usb/octeon-hcd.h
> index ae7ae50071ae..0ee74f63fdbf 100644
> --- a/drivers/staging/octeon-usb/octeon-hcd.h
> +++ b/drivers/staging/octeon-usb/octeon-hcd.h
> @@ -51,10 +51,10 @@
> #include <asm/bitfield.h>
>
> #define CVMX_USBCXBASE 0x00016F0010000000ull
> -#define CVMX_USBCXREG1(reg, bid) \
> +#define CVMX_USBCXREG1((reg), bid) \
I really do not think you changed any "precedence issues" here at all :(
next prev parent reply other threads:[~2019-03-04 19:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-04 17:57 [PATCH] staging: octeon-usb: Add brackets to avoid precedence issues Nishka Dasgupta
2019-03-04 19:03 ` Greg KH [this message]
2019-03-04 20:14 ` [Outreachy kernel] " Nishka Dasgupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190304190311.GE13830@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=nishka.dasgupta@yahoo.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.