From: Niklas Cassel <niklas.cassel@linaro.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Nicolas Dechesne <nicolas.dechesne@linaro.org>
Subject: Re: [PATCH] arm64: dts: qcom: qcs404: Fix regulator supply names
Date: Mon, 4 Mar 2019 20:23:55 +0100 [thread overview]
Message-ID: <20190304192355.GA13754@centauri.lan> (raw)
In-Reply-To: <20181213183200.3204-1-bjorn.andersson@linaro.org>
On Thu, Dec 13, 2018 at 10:32:00AM -0800, Bjorn Andersson wrote:
> The regulator definition got their supply names cleaned up during
> upstreaming, so they no longer match the driver defined names. Update
> the supply names.
>
> Also fill out the missing voltage of SMPS 5.
>
> Fixes: 0b363f5b871c ("arm64: dts: qcom: qcs404: Add PMS405 RPM regulators")
> Reported-by: Nicolas Dechesne <nicolas.dechesne@linaro.org>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/qcs404-evb.dtsi | 28 ++++++++++++------------
> 1 file changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi b/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi
> index a39924efebe4..d6cc3a96530e 100644
> --- a/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi
> +++ b/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi
> @@ -37,18 +37,18 @@
> pms405-regulators {
> compatible = "qcom,rpm-pms405-regulators";
>
> - vdd-s1-supply = <&vph_pwr>;
> - vdd-s2-supply = <&vph_pwr>;
> - vdd-s3-supply = <&vph_pwr>;
> - vdd-s4-supply = <&vph_pwr>;
> - vdd-s5-supply = <&vph_pwr>;
> - vdd-l1-l2-supply = <&vreg_s5_1p35>;
> - vdd-l3-l8-supply = <&vreg_s5_1p35>;
> - vdd-l4-supply = <&vreg_s5_1p35>;
> - vdd-l5-l6-supply = <&vreg_s4_1p8>;
> - vdd-l7-supply = <&vph_pwr>;
> - vdd-l9-supply = <&vreg_s5_1p35>;
> - vdd-l10-l11-l12-l13-supply = <&vph_pwr>;
> + vdd_s1-supply = <&vph_pwr>;
> + vdd_s2-supply = <&vph_pwr>;
> + vdd_s3-supply = <&vph_pwr>;
> + vdd_s4-supply = <&vph_pwr>;
> + vdd_s5-supply = <&vph_pwr>;
> + vdd_l1_l2-supply = <&vreg_s5_1p35>;
> + vdd_l3_l8-supply = <&vreg_s5_1p35>;
> + vdd_l4-supply = <&vreg_s5_1p35>;
> + vdd_l5_l6-supply = <&vreg_s4_1p8>;
> + vdd_l7-supply = <&vph_pwr>;
> + vdd_l9-supply = <&vreg_s5_1p35>;
> + vdd_l10_l11_l12_l13-supply = <&vph_pwr>;
>
> vreg_s4_1p8: s4 {
> regulator-min-microvolt = <1728000>;
> @@ -56,8 +56,8 @@
> };
>
> vreg_s5_1p35: s5 {
> - regulator-min-microvolt = <>;
> - regulator-max-microvolt = <>;
> + regulator-min-microvolt = <1352000>;
> + regulator-max-microvolt = <1352000>;
> };
>
> vreg_l1_1p3: l1 {
> --
> 2.18.0
>
Reviewed-by: Niklas Cassel <niklas.cassel@linaro.org>
next prev parent reply other threads:[~2019-03-04 19:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 18:32 [PATCH] arm64: dts: qcom: qcs404: Fix regulator supply names Bjorn Andersson
2019-03-04 19:23 ` Niklas Cassel [this message]
2019-03-05 4:09 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190304192355.GA13754@centauri.lan \
--to=niklas.cassel@linaro.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nicolas.dechesne@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.