From: Greg KH <greg@kroah.com>
To: idebleenasen@gmail.com
Cc: outreachy-kernel <outreachy-kernel@googlegroups.com>
Subject: Re: [Outreachy kernel] Re: Regarding undocumented string checkpatch.pl warning
Date: Tue, 5 Mar 2019 08:05:17 +0100 [thread overview]
Message-ID: <20190305070517.GC1538@kroah.com> (raw)
In-Reply-To: <f28dc17c-9521-4f21-8ca5-a54d79adac81@googlegroups.com>
On Mon, Mar 04, 2019 at 11:50:35AM -0800, idebleenasen@gmail.com wrote:
> On Tuesday, March 5, 2019 at 12:49:53 AM UTC+5:30, Debleena Sen wrote:
> >
> > I came across the following warning in drivers/staging/wilc1000/wilc_spi.c
> >
> > WARNING: DT compatible string "microchip,wilc1000-spi" appears
> > un-documented --check ./Documentation/devicetree/bindings/
> >
> > I referred to ./Documentation/devicetree/bindings/ and checked /staging,
> > resource-names.txt, vendor-prefixes.txt but I could not find anything
> > related to microchip or wilc1000.
> >
> > On referring to ./Documentation/devicetree/bindings/spi I found a text
> > file "microchip,spi-pic32.txt" but I do not think its related to WILC1000
> > driver.
> >
> > What should I do to remove this warning?
> >
>
> Wanted to add that I found another text file in drivers/staging/wilc1000
> itself named "microchip,wilc1000,spi.txt". I think this is the required
> file. Should I move/copy this file to ./Documentation/devicetree/bindings/
> to remove the warning?
No, staging drivers are supposed to be "self contained" and not need
changes in other parts of the kernel. That doesn't work well with DT
files, so for now, until the driver gets merged to the "correct" part of
the kernel, the DT files stay with the driver itself.
Please do not move that file, as I will not take that patch, and you can
just ignore that checkpatch warning, there's nothing to do for it at
this point in time.
hope this helps,
greg k-h
next prev parent reply other threads:[~2019-03-05 7:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-04 19:19 Regarding undocumented string checkpatch.pl warning Debleena Sen
2019-03-04 19:50 ` idebleenasen
2019-03-05 7:05 ` Greg KH [this message]
2019-03-05 7:13 ` [Outreachy kernel] " Debleena Sen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190305070517.GC1538@kroah.com \
--to=greg@kroah.com \
--cc=idebleenasen@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.