Re: [Outreachy kernel] [PATCH 3/5] Staging: vt6655: Fix warning about preprocessor conditionals

[Greg KH <gregkh@linuxfoundation.org>]

On Mon, Mar 04, 2019 at 06:24:01PM -0600, Madhumitha Prabakaran wrote:
> Fix the warning by removing code between #if and #endif, as coding style
> say the compiler will constant-fold the conditional away and include or
> exclude the block of code as with an endif.
> 
> Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
> ---
>  drivers/staging/vt6655/power.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/vt6655/power.c b/drivers/staging/vt6655/power.c
> index d6c581b31569..c2a7c120a94d 100644
> --- a/drivers/staging/vt6655/power.c
> +++ b/drivers/staging/vt6655/power.c
> @@ -64,7 +64,6 @@ PSvEnablePowerSaving(
>  	} else {
>  		/* set ATIM Window */
>  #if 0 /* TODO atim window */
> -		MACvWriteATIMW(priv->PortOffset, pMgmt->wCurrATIMWindow);
>  #endif
>  	}
>  	/* Set AutoSleep */

When you removed this line, you then ended up with:
	#if 0
	#endif

which does not make much sense :)

As this is a "TODO" item, I would just leave this alone for now.
Hopefully someone will fix this correctly in the future.

thanks,

greg k-h