From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: [bug report] misc: rtsx: Enable OCP for rts522a rts524a rts525a rts5260
Date: Tue, 05 Mar 2019 11:46:55 +0000 [thread overview]
Message-ID: <20190305114655.GA17506@kadam> (raw)
Hello RickyWu,
The patch bede03a579b3: "misc: rtsx: Enable OCP for rts522a rts524a
rts525a rts5260" from Feb 19, 2019, leads to the following static
checker warning:
drivers/misc/cardreader/rts5260.c:707 rts5260_init_params()
'0x50 | 0x50' has '0x50' set on both sides
drivers/misc/cardreader/rts5260.c
694 /* init latency of active, idle, L1OFF to 60us, 300us, 3ms */
695 option->ltr_active_latency = LTR_ACTIVE_LATENCY_DEF;
696 option->ltr_idle_latency = LTR_IDLE_LATENCY_DEF;
697 option->ltr_l1off_latency = LTR_L1OFF_LATENCY_DEF;
698 option->dev_aspm_mode = DEV_ASPM_DYNAMIC;
699 option->l1_snooze_delay = L1_SNOOZE_DELAY_DEF;
700 option->ltr_l1off_sspwrgate = LTR_L1OFF_SSPWRGATE_5250_DEF;
701 option->ltr_l1off_snooze_sspwrgate 702 LTR_L1OFF_SNOOZE_SSPWRGATE_5250_DEF;
703
704 option->ocp_en = 1;
705 if (option->ocp_en)
706 hw_param->interrupt_en |= SD_OC_INT_EN;
--> 707 hw_param->ocp_glitch = SDVIO_OCP_GLITCH_800U | SDVIO_OCP_GLITCH_800U;
^^^^^^^^^^^^^^^^^^^^^
This used to be SD_OCP_GLITCH_10M but now it's SDVIO_OCP_GLITCH_800U
on both sides.
708 option->sd_400mA_ocp_thd = RTS5260_DVCC_OCP_THD_550;
709 option->sd_800mA_ocp_thd = RTS5260_DVCC_OCP_THD_970;
710 }
regards,
dan carpenter
reply other threads:[~2019-03-05 11:46 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190305114655.GA17506@kadam \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.