From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 2/7] drm/edid: Allow to ignore the audio EDID data Date: Tue, 5 Mar 2019 17:24:13 +0200 Message-ID: <20190305152413.GD16917@intel.com> References: <4914bea9fc3ef3deaffa39ab691dbd9a76461e97.1551711042.git-series.maxime.ripard@bootlin.com> <87wole76ws.fsf@anholt.net> <20190305091240.sbkvdwosocaytx22@flea> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20190305091240.sbkvdwosocaytx22@flea> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Maxime Ripard Cc: alsa-devel@alsa-project.org, eben@raspberrypi.org, David Airlie , Maling list - DRI developers , Paul Kocialkowski , Sean Paul , Thomas Petazzoni , Daniel Vetter , linux-arm-kernel List-Id: alsa-devel@alsa-project.org T24gVHVlLCBNYXIgMDUsIDIwMTkgYXQgMTA6MTI6NDBBTSArMDEwMCwgTWF4aW1lIFJpcGFyZCB3 cm90ZToKPiBPbiBNb24sIE1hciAwNCwgMjAxOSBhdCAwMzowNTozMVBNIC0wNTAwLCBBbGV4IERl dWNoZXIgd3JvdGU6Cj4gPiBPbiBNb24sIE1hciA0LCAyMDE5IGF0IDI6NTMgUE0gRXJpYyBBbmhv bHQgPGVyaWNAYW5ob2x0Lm5ldD4gd3JvdGU6Cj4gPiA+Cj4gPiA+IE1heGltZSBSaXBhcmQgPG1h eGltZS5yaXBhcmRAYm9vdGxpbi5jb20+IHdyaXRlczoKPiA+ID4KPiA+ID4gPiBJbiBzb21lIGNh c2VzLCBpbiBvcmRlciB0byBhY2NvbW9kYXRlIHdpdGggZGlzcGxheXMgd2l0aCBwb29yIEVESURz LCB3ZQo+ID4gPiA+IG5lZWQgdG8gaWdub3JlIHRoYXQgdGhlIG1vbml0b3IgYWxsZWRnZWRseSBz dXBwb3J0cyBhdWRpbyBvdXRwdXQgYW5kCj4gPiA+ID4gZGlzYWJsZSB0aGUgYXVkaW8gb3V0cHV0 Lgo+ID4gPiA+Cj4gPiA+ID4gU2lnbmVkLW9mZi1ieTogTWF4aW1lIFJpcGFyZCA8bWF4aW1lLnJp cGFyZEBib290bGluLmNvbT4KPiA+ID4gPiAtLS0KPiA+ID4gPiAgZHJpdmVycy9ncHUvZHJtL2Ry bV9lZGlkLmMgfCA4ICsrKysrKysrCj4gPiA+ID4gIDEgZmlsZSBjaGFuZ2VkLCA4IGluc2VydGlv bnMoKykKPiA+ID4gPgo+ID4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2Vk aWQuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZWRpZC5jCj4gPiA+ID4gaW5kZXggOTkwYjE5MDlm OWQ3Li5jMDI1OGIwMTFiYjIgMTAwNjQ0Cj4gPiA+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2Ry bV9lZGlkLmMKPiA+ID4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2VkaWQuYwo+ID4gPiA+ IEBAIC00MTkwLDYgKzQxOTAsMTEgQEAgYm9vbCBkcm1fZGV0ZWN0X2hkbWlfbW9uaXRvcihzdHJ1 Y3QgZWRpZCAqZWRpZCkKPiA+ID4gPiAgfQo+ID4gPiA+ICBFWFBPUlRfU1lNQk9MKGRybV9kZXRl Y3RfaGRtaV9tb25pdG9yKTsKPiA+ID4gPgo+ID4gPiA+ICtzdGF0aWMgYm9vbCBpZ25vcmVfZWRp ZF9hdWRpbyA9IGZhbHNlOwo+ID4gPiA+ICttb2R1bGVfcGFyYW0oaWdub3JlX2VkaWRfYXVkaW8s IGJvb2wsIDA2NDQpOwo+ID4gPiA+ICtNT0RVTEVfUEFSTV9ERVNDKGlnbm9yZV9lZGlkX2F1ZGlv LAo+ID4gPiA+ICsgICAgICAgICAgICAgICJJZ25vcmUgdGhlIEVESUQgYW5kIGFsd2F5cyBjb25z aWRlciB0aGF0IGEgbW9uaXRvciBkb2Vzbid0IGhhdmUgYXVkaW8gY2FwYWJpbGl0aWVzIik7Cj4g PiA+ID4gKwo+ID4gPiA+ICAvKioKPiA+ID4gPiAgICogZHJtX2RldGVjdF9tb25pdG9yX2F1ZGlv IC0gY2hlY2sgbW9uaXRvciBhdWRpbyBjYXBhYmlsaXR5Cj4gPiA+ID4gICAqIEBlZGlkOiBFRElE IGJsb2NrIHRvIHNjYW4KPiA+ID4gPiBAQCAtNDIwOSw2ICs0MjE0LDkgQEAgYm9vbCBkcm1fZGV0 ZWN0X21vbml0b3JfYXVkaW8oc3RydWN0IGVkaWQgKmVkaWQpCj4gPiA+ID4gICAgICAgYm9vbCBo YXNfYXVkaW8gPSBmYWxzZTsKPiA+ID4gPiAgICAgICBpbnQgc3RhcnRfb2Zmc2V0LCBlbmRfb2Zm c2V0Owo+ID4gPiA+Cj4gPiA+ID4gKyAgICAgaWYgKGlnbm9yZV9lZGlkX2F1ZGlvKQo+ID4gPiA+ ICsgICAgICAgICAgICAgZ290byBlbmQ7Cj4gPiA+ID4gKwo+ID4gPiA+ICAgICAgIGVkaWRfZXh0 ID0gZHJtX2ZpbmRfY2VhX2V4dGVuc2lvbihlZGlkKTsKPiA+ID4gPiAgICAgICBpZiAoIWVkaWRf ZXh0KQo+ID4gPiA+ICAgICAgICAgICAgICAgZ290byBlbmQ7Cj4gPiA+Cj4gPiA+IEl0IGxvb2tz IGxpa2UgdGhlIG1vdGl2YXRpb24gZm9yIHRoZSBvcmlnaW5hbCBmbGFnIG9uIFJhc3BiZXJyeSBQ aSB3YXMKPiA+ID4gIkkndmUgZ290IGEgbm9uLWF1ZGlvIG1vbml0b3IsIGJ1dCB0aGUgc3lzdGVt IGNvbWVzIHVwIHRyeWluZyB0byBwbGF5Cj4gPiA+IGF1ZGlvIHRvIEhETUkgaW5zdGVhZCBvZiB0 aGUgYW5hbG9nIGphY2siLiAgRG8gd2UgaGF2ZSBzb21lIHdheSBmb3IgRFJNCj4gPiA+IHRvIGNv bW11bmljYXRlIHRvIEFMU0EgdGhhdCB0aGlzIGlzIG5vdCB0aGUgcmlnaHQgcGxhY2UgdG8gdHJ5 IHRvIHBsYXkKPiA+ID4gYXVkaW8gYnkgZGVmYXVsdD8KPiA+IAo+ID4gQXBwYXJlbnRseSBub3Qu ICBXZSBoYXZlIHVzZXJzIHVzaW5nIGRlYnVnIGtub2JzIGluIG91ciBkcml2ZXJzIHRvCj4gPiBk aXNhYmxlIGRpc3BsYXkgYXVkaW8gYmVjYXVzZSBBTFNBIGRlZmF1bHRzIHRvIHRoYXQgcmF0aGVy IHRoYW4gb3RoZXIKPiA+IGF1ZGlvLgo+IAo+IEkgZ3Vlc3Mgb25lIHdheSB0byBkbyB0aGlzIHdv dWxkIGJlIHRvIHJlZ2lzdGVyIHRoZSBjYXJkIG9ubHkgd2hlbiBhbgo+IGF1ZGlvLWNhcGFibGUg bW9uaXRvciBpcyBjb25uZWN0ZWQgaW5zdGVhZCBvZiBkb2luZyB0aGlzIGF0IHByb2JlCj4gdGlt ZS4gSSdtIG5vdCBzdXJlIGhvdyBjb252ZW5pZW50IGl0IGlzIGZvciB1c2Vyc3BhY2UgdGhvdWdo LgoKV2UgYWxyZWFkeSBwcm92aWRlIHRoZSBFTEQgdG8gYWxzYS4gSSdtIHByZXR0eSBzdXJlIHB1 bHNlYXVkaW8gdXNlcwp0aGF0IHN0dWZmIHNvbWVob3cgdG8gZmlndXJlIG91dCB3aGV0aGVyIHRv IHBsYXkgYXVkaW8gb3ZlciBIRE1JLgpCdXQgc2luY2UgSSBkb24ndCB1c2UgcHVsc2VhdWRpbyBt eXNlbGYgSSBjYW4ndCBiZSAxMDAlIHN1cmUuCgpDYzppbmcgVGFrYXNoaS9hbHNhIGZvbGtzIGZv ciBjb25maXJtYXRpb24uCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QK ZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7ADA0C43381 for ; Tue, 5 Mar 2019 15:24:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 492A220848 for ; Tue, 5 Mar 2019 15:24:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IeMsv+UE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 492A220848 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zV+oDEdcygc/ypVC5HtPyQTvwNB0cDMkwY7shj/gLgM=; b=IeMsv+UEtToZYT WnB8WoeyeZNEtwDFBVoTRuLTeliMM2c1lUU6wVRePAKLLtuJpQ3Mn7VOsnCFtHxrk5twg1FzfDz1N ocLIhL1ihnOf1Fdq9fwHQQpcNScgd0V7x/PxVd2cb4ZZiGuiMZ/g9yGyCbhZnIrSauJFWe+G9Giuo 2bEpcmhahd68iYqnv0d3ZEJ7mMFyxCTLPS3nCSpVXaBwMt04g595WAWVhMvE+vYdlbq9iYRuTrck9 Z65e/mlth2F6hs1bgBaWxonCpltgc7583L9ODxhp6uVmmSDL5BVrabN1ny3L/jsT22lgWuKIj3PdP CzTj29lwgr4LiW/3va+A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1Bvb-0004DJ-In; Tue, 05 Mar 2019 15:24:23 +0000 Received: from mga02.intel.com ([134.134.136.20]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1BvY-0004CZ-4s for linux-arm-kernel@lists.infradead.org; Tue, 05 Mar 2019 15:24:21 +0000 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Mar 2019 07:24:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,444,1544515200"; d="scan'208";a="138235862" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by FMSMGA003.fm.intel.com with SMTP; 05 Mar 2019 07:24:14 -0800 Received: by stinkbox (sSMTP sendmail emulation); Tue, 05 Mar 2019 17:24:13 +0200 Date: Tue, 5 Mar 2019 17:24:13 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Maxime Ripard Subject: Re: [PATCH 2/7] drm/edid: Allow to ignore the audio EDID data Message-ID: <20190305152413.GD16917@intel.com> References: <4914bea9fc3ef3deaffa39ab691dbd9a76461e97.1551711042.git-series.maxime.ripard@bootlin.com> <87wole76ws.fsf@anholt.net> <20190305091240.sbkvdwosocaytx22@flea> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190305091240.sbkvdwosocaytx22@flea> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190305_072420_239947_F716122E X-CRM114-Status: GOOD ( 25.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, eben@raspberrypi.org, David Airlie , Maling list - DRI developers , Paul Kocialkowski , Takashi Iwai , Sean Paul , Thomas Petazzoni , Alex Deucher , Daniel Vetter , linux-arm-kernel Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 05, 2019 at 10:12:40AM +0100, Maxime Ripard wrote: > On Mon, Mar 04, 2019 at 03:05:31PM -0500, Alex Deucher wrote: > > On Mon, Mar 4, 2019 at 2:53 PM Eric Anholt wrote: > > > > > > Maxime Ripard writes: > > > > > > > In some cases, in order to accomodate with displays with poor EDIDs= , we > > > > need to ignore that the monitor alledgedly supports audio output and > > > > disable the audio output. > > > > > > > > Signed-off-by: Maxime Ripard > > > > --- > > > > drivers/gpu/drm/drm_edid.c | 8 ++++++++ > > > > 1 file changed, 8 insertions(+) > > > > > > > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > > > > index 990b1909f9d7..c0258b011bb2 100644 > > > > --- a/drivers/gpu/drm/drm_edid.c > > > > +++ b/drivers/gpu/drm/drm_edid.c > > > > @@ -4190,6 +4190,11 @@ bool drm_detect_hdmi_monitor(struct edid *ed= id) > > > > } > > > > EXPORT_SYMBOL(drm_detect_hdmi_monitor); > > > > > > > > +static bool ignore_edid_audio =3D false; > > > > +module_param(ignore_edid_audio, bool, 0644); > > > > +MODULE_PARM_DESC(ignore_edid_audio, > > > > + "Ignore the EDID and always consider that a monitor = doesn't have audio capabilities"); > > > > + > > > > /** > > > > * drm_detect_monitor_audio - check monitor audio capability > > > > * @edid: EDID block to scan > > > > @@ -4209,6 +4214,9 @@ bool drm_detect_monitor_audio(struct edid *ed= id) > > > > bool has_audio =3D false; > > > > int start_offset, end_offset; > > > > > > > > + if (ignore_edid_audio) > > > > + goto end; > > > > + > > > > edid_ext =3D drm_find_cea_extension(edid); > > > > if (!edid_ext) > > > > goto end; > > > > > > It looks like the motivation for the original flag on Raspberry Pi was > > > "I've got a non-audio monitor, but the system comes up trying to play > > > audio to HDMI instead of the analog jack". Do we have some way for D= RM > > > to communicate to ALSA that this is not the right place to try to play > > > audio by default? > > = > > Apparently not. We have users using debug knobs in our drivers to > > disable display audio because ALSA defaults to that rather than other > > audio. > = > I guess one way to do this would be to register the card only when an > audio-capable monitor is connected instead of doing this at probe > time. I'm not sure how convenient it is for userspace though. We already provide the ELD to alsa. I'm pretty sure pulseaudio uses that stuff somehow to figure out whether to play audio over HDMI. But since I don't use pulseaudio myself I can't be 100% sure. Cc:ing Takashi/alsa folks for confirmation. -- = Ville Syrj=E4l=E4 Intel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel