All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
	Rob Herring <robh@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] phy: mapphone-mdm6600: add gpiolib dependency
Date: Tue, 5 Mar 2019 07:46:46 -0800	[thread overview]
Message-ID: <20190305154646.GH39872@atomide.com> (raw)
In-Reply-To: <20190304202406.1716350-3-arnd@arndb.de>

* Arnd Bergmann <arnd@arndb.de> [190304 20:24]:
> gcc points out that when CONFIG_GPIOLIB is disabled,
> gpiod_get_array_value_cansleep() returns 0 but fails to set its output:
> 
> drivers/phy/motorola/phy-mapphone-mdm6600.c: In function 'phy_mdm6600_status':
> drivers/phy/motorola/phy-mapphone-mdm6600.c:220:24: error: 'values[0]' is used uninitialized in this function [-Werror=uninitialized]
> 
> This could be fixed more generally in gpiolib by returning a failure
> code, but for this specific case, the easier workaround is to add a
> gpiolib dependency.

Thanks for fixing it:

Acked-by: Tony Lindgren <tony@atomide.com>

  reply	other threads:[~2019-03-05 15:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-04 20:23 [PATCH 1/3] phy: allwinner: allow compile testing Arnd Bergmann
2019-03-04 20:23 ` [PATCH 2/3] phy: ti: usb2: fix OMAP_CONTROL_PHY dependency Arnd Bergmann
2019-03-04 20:23 ` [PATCH 3/3] phy: mapphone-mdm6600: add gpiolib dependency Arnd Bergmann
2019-03-05 15:46   ` Tony Lindgren [this message]
2019-03-05  8:44 ` [PATCH 1/3] phy: allwinner: allow compile testing Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190305154646.GH39872@atomide.com \
    --to=tony@atomide.com \
    --cc=arnd@arndb.de \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.