All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sven Schnelle <svens@stackframe.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
	Sven Schnelle <svens@stackframe.org>, Fam Zheng <fam@euphon.net>
Subject: [Qemu-devel] [PATCH v2 5/5] lsi: return dfifo value
Date: Tue,  5 Mar 2019 20:55:19 +0100	[thread overview]
Message-ID: <20190305195519.24303-6-svens@stackframe.org> (raw)
In-Reply-To: <20190305195519.24303-1-svens@stackframe.org>

Code was assigning DFIFO, but didn't return the value to users.

Signed-off-by: Sven Schnelle <svens@stackframe.org>
---
 hw/scsi/lsi53c895a.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c
index 7d66d1a870..3783779da6 100644
--- a/hw/scsi/lsi53c895a.c
+++ b/hw/scsi/lsi53c895a.c
@@ -1688,7 +1688,7 @@ static uint8_t lsi_reg_readb(LSIState *s, int offset)
         break;
     CASE_GET_REG32(temp, 0x1c)
     case 0x20: /* DFIFO */
-        ret = 0;
+        ret = s->dfifo;
         break;
     case 0x21: /* CTEST4 */
         ret = s->ctest4;
-- 
2.20.1

  parent reply	other threads:[~2019-03-05 19:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-05 19:55 [Qemu-devel] [PATCH v2 0/5] LSI53C895 cleanups Sven Schnelle
2019-03-05 19:55 ` [Qemu-devel] [PATCH v2 1/5] lsi: use ldn_le_p()/stn_le_p() Sven Schnelle
2019-03-05 19:55 ` [Qemu-devel] [PATCH v2 2/5] lsi: use enum type for s->waiting Sven Schnelle
2019-03-05 19:55 ` [Qemu-devel] [PATCH v2 3/5] lsi: use enum type for s->msg_action Sven Schnelle
2019-03-05 19:55 ` [Qemu-devel] [PATCH v2 4/5] lsi: use SCSI phase names instead of numbers in trace Sven Schnelle
2019-03-05 19:55 ` Sven Schnelle [this message]
2019-03-08  9:17 ` [Qemu-devel] [PATCH v2 0/5] LSI53C895 cleanups Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190305195519.24303-6-svens@stackframe.org \
    --to=svens@stackframe.org \
    --cc=fam@euphon.net \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.