From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [PATCH 1/2] drm/i915/dp: deconflate PPS unlock from divisor register Date: Tue, 5 Mar 2019 12:19:30 -0800 Message-ID: <20190305201930.GR10303@intel.com> References: <20190305135215.29862-1-jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 149956E015 for ; Tue, 5 Mar 2019 20:19:22 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190305135215.29862-1-jani.nikula@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBNYXIgMDUsIDIwMTkgYXQgMDM6NTI6MTRQTSArMDIwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gUFBTIGxvY2tpbmcgaXMgYSB0aGluZyBvbiBwcmUtRERJLCB1cCB0byBhbmQgaW5jbHVk aW5nIENQVCBhbmQgUFBULgo+IAo+IFRoZSBQUFMgZGl2aXNvciByZWdpc3RlciBleGlzdHMgdXAg dG8gZ2VuIDkgQkMsIHJlcGxhY2VkIGJ5IGEgZmllbGQgaW4KPiB0aGUgY29udHJvbCByZWdpc3Rl ciBzdGFydGluZyBmcm9tIGdlbiA5IExQLCBpLmUuIEJYVCwgR0xLLCBhbmQgQ05QIG9uLgo+IAo+ IENvbW1pdCBiMGEwOGJlYzk2MzEgKCJkcm0vaTkxNS9ieHQ6IGVEUCBQYW5lbCBQb3dlciBzZXF1 ZW5jaW5nIikgc3RvcHBlZAo+IHVzaW5nIHRoZSBkaXZpc29yIHJlZ2lzdGVyLCBidXQgaW5hZHZl cnRlbnRseSBjb25mbGF0ZWQgdGhlIFBQUyB1bmxvY2sKPiBpbiB0aGUgY2hhbmdlLiBObyBsb25n ZXIgZG9pbmcgdGhlIHVubG9ja2luZyB3YXMgdGhlIHJpZ2h0IHRoaW5nIHRvIGRvLAo+IGhvd2V2 ZXIgd2Ugc2hvdWxkJ3ZlIHN0b3BwZWQgYWxyZWFkeSBhdCBMUFQgKG9yIERESSBwbGF0Zm9ybXMp Lgo+IAo+IERlY29uZmxhdGUgdGhlIHR3by4KPiAKPiBBcmd1YWJseSB0aGlzIGNvdWxkIGJlIG1v dmVkIGF3YXkgZnJvbSBoZXJlIGFsdG9nZXRoZXIsIGJ1dCB0aGlzIGlzIHRoZQo+IG1pbmltYWxs eSBpbnRydXNpdmUgY2hhbmdlIGZvciBub3cuCj4gCj4gQ2M6IFJvZHJpZ28gVml2aSA8cm9kcmln by52aXZpQGludGVsLmNvbT4KPiBDYzogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxp bnV4LmludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFA aW50ZWwuY29tPgoKUmV2aWV3ZWQtYnk6IFJvZHJpZ28gVml2aSA8cm9kcmlnby52aXZpQGludGVs LmNvbT4KCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMgfCA3ICsrKyst LS0KPiAgMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKPiAK PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiBpbmRleCBlMWEwNTFjMGZiZmUuLmUwZjQyMWU3NjMw NSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+IEBAIC02NDI1LDE1ICs2NDI1LDE2IEBA IGludGVsX3Bwc19yZWFkb3V0X2h3X3N0YXRlKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsIHN0 cnVjdCBlZHBfcG93ZXJfc2VxICpzZXEpCj4gIAo+ICAJaW50ZWxfcHBzX2dldF9yZWdpc3RlcnMo aW50ZWxfZHAsICZyZWdzKTsKPiAgCj4gLQkvKiBXb3JrYXJvdW5kOiBOZWVkIHRvIHdyaXRlIFBQ X0NPTlRST0wgd2l0aCB0aGUgdW5sb2NrIGtleSBhcwo+IC0JICogdGhlIHZlcnkgZmlyc3QgdGhp bmcuICovCj4gIAlwcF9jdGwgPSBpcm9ubGFrZV9nZXRfcHBfY29udHJvbChpbnRlbF9kcCk7Cj4g IAo+ICsJLyogRW5zdXJlIFBQUyBpcyB1bmxvY2tlZCAqLwo+ICsJaWYgKCFIQVNfRERJKGRldl9w cml2KSkKPiArCQlJOTE1X1dSSVRFKHJlZ3MucHBfY3RybCwgcHBfY3RsKTsKPiArCj4gIAlwcF9v biA9IEk5MTVfUkVBRChyZWdzLnBwX29uKTsKPiAgCXBwX29mZiA9IEk5MTVfUkVBRChyZWdzLnBw X29mZik7Cj4gIAlpZiAoIUlTX0dFTjlfTFAoZGV2X3ByaXYpICYmICFIQVNfUENIX0NOUChkZXZf cHJpdikgJiYKPiAgCSAgICAhSEFTX1BDSF9JQ1AoZGV2X3ByaXYpKSB7Cj4gLQkJSTkxNV9XUklU RShyZWdzLnBwX2N0cmwsIHBwX2N0bCk7Cj4gIAkJcHBfZGl2ID0gSTkxNV9SRUFEKHJlZ3MucHBf ZGl2KTsKPiAgCX0KPiAgCj4gLS0gCj4gMi4yMC4xCj4gCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4 QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2ludGVsLWdmeA==