From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH 2/2] drm/i915/dp: use single point of truth
 for PPS divisor register
Date: Tue, 5 Mar 2019 12:22:54 -0800
Message-ID: <20190305202254.GS10303@intel.com>
References: <20190305135215.29862-1-jani.nikula@intel.com>
 <20190305135215.29862-2-jani.nikula@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 6BB836E00F
 for <intel-gfx@lists.freedesktop.org>; Tue,  5 Mar 2019 20:22:44 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20190305135215.29862-2-jani.nikula@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gVHVlLCBNYXIgMDUsIDIwMTkgYXQgMDM6NTI6MTVQTSArMDIwMCwgSmFuaSBOaWt1bGEgd3Jv
dGU6Cj4gU2V0IHBwX2RpdiBmaWVsZCBvZiBzdHJ1Y3QgcHBzX3JlZ2lzdGVycyB0byBJTlZBTElE
X01NSU9fUkVHIHdoZW4gdGhlCj4gcmVnaXN0ZXIgaXNuJ3QgdGhlcmUsIGFuZCB1c2UgaTkxNV9t
bWlvX3JlZ192YWxpZCgpIGluc3RlYWQgb2YgcmVwZWF0aW5nCj4gdGhlIGNvbmRpdGlvbiBhbGwg
b3ZlciB0aGUgcGxhY2UuCj4gCj4gVXNlIElOVkFMSURfTU1JT19SRUcgZXhwbGljaXRseSBmb3Ig
ZG9jdW1lbnRhdGlvbiBwdXJwb3NlcywgZXZlbiBpZiB0aGUKPiB2YWx1ZSBpcyB1bmNoYW5nZWQg
ZnJvbSAwLgoKZ3JlYXQgY2xlYW4gdXAuIFRoYW5rcyBmb3IgdGhhdC4KCgpSZXZpZXdlZC1ieTog
Um9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29tPgoKCgo+IAo+IENjOiBSb2RyaWdv
IFZpdmkgPHJvZHJpZ28udml2aUBpbnRlbC5jb20+Cj4gQ2M6IFZpbGxlIFN5cmrDpGzDpCA8dmls
bGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogSmFuaSBOaWt1bGEg
PGphbmkubmlrdWxhQGludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50
ZWxfZHAuYyB8IDczICsrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUg
Y2hhbmdlZCwgMzkgaW5zZXJ0aW9ucygrKSwgMzQgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdp
dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkx
NS9pbnRlbF9kcC5jCj4gaW5kZXggZTBmNDIxZTc2MzA1Li5mNDBiMzM0MmQ4MmEgMTAwNjQ0Cj4g
LS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1
L2RybS9pOTE1L2ludGVsX2RwLmMKPiBAQCAtOTQ5LDggKzk0OSwxMiBAQCBzdGF0aWMgdm9pZCBp
bnRlbF9wcHNfZ2V0X3JlZ2lzdGVycyhzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwLAo+ICAJcmVn
cy0+cHBfc3RhdCA9IFBQX1NUQVRVUyhwcHNfaWR4KTsKPiAgCXJlZ3MtPnBwX29uID0gUFBfT05f
REVMQVlTKHBwc19pZHgpOwo+ICAJcmVncy0+cHBfb2ZmID0gUFBfT0ZGX0RFTEFZUyhwcHNfaWR4
KTsKPiAtCWlmICghSVNfR0VOOV9MUChkZXZfcHJpdikgJiYgIUhBU19QQ0hfQ05QKGRldl9wcml2
KSAmJgo+IC0JICAgICFIQVNfUENIX0lDUChkZXZfcHJpdikpCj4gKwo+ICsJLyogQ3ljbGUgZGVs
YXkgbW92ZWQgZnJvbSBQUF9ESVZJU09SIHRvIFBQX0NPTlRST0wgKi8KPiArCWlmIChJU19HRU45
X0xQKGRldl9wcml2KSB8fCBIQVNfUENIX0NOUChkZXZfcHJpdikgfHwKPiArCSAgICBIQVNfUENI
X0lDUChkZXZfcHJpdikpCj4gKwkJcmVncy0+cHBfZGl2ID0gSU5WQUxJRF9NTUlPX1JFRzsKPiAr
CWVsc2UKPiAgCQlyZWdzLT5wcF9kaXYgPSBQUF9ESVZJU09SKHBwc19pZHgpOwo+ICB9Cj4gIAo+
IEBAIC02NDIwLDcgKzY0MjQsNyBAQCBzdGF0aWMgdm9pZAo+ICBpbnRlbF9wcHNfcmVhZG91dF9o
d19zdGF0ZShzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwLCBzdHJ1Y3QgZWRwX3Bvd2VyX3NlcSAq
c2VxKQo+ICB7Cj4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBkcF90b19p
OTE1KGludGVsX2RwKTsKPiAtCXUzMiBwcF9vbiwgcHBfb2ZmLCBwcF9kaXYgPSAwLCBwcF9jdGwg
PSAwOwo+ICsJdTMyIHBwX29uLCBwcF9vZmYsIHBwX2N0bDsKPiAgCXN0cnVjdCBwcHNfcmVnaXN0
ZXJzIHJlZ3M7Cj4gIAo+ICAJaW50ZWxfcHBzX2dldF9yZWdpc3RlcnMoaW50ZWxfZHAsICZyZWdz
KTsKPiBAQCAtNjQzMywxMCArNjQzNyw2IEBAIGludGVsX3Bwc19yZWFkb3V0X2h3X3N0YXRlKHN0
cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsIHN0cnVjdCBlZHBfcG93ZXJfc2VxICpzZXEpCj4gIAo+
ICAJcHBfb24gPSBJOTE1X1JFQUQocmVncy5wcF9vbik7Cj4gIAlwcF9vZmYgPSBJOTE1X1JFQUQo
cmVncy5wcF9vZmYpOwo+IC0JaWYgKCFJU19HRU45X0xQKGRldl9wcml2KSAmJiAhSEFTX1BDSF9D
TlAoZGV2X3ByaXYpICYmCj4gLQkgICAgIUhBU19QQ0hfSUNQKGRldl9wcml2KSkgewo+IC0JCXBw
X2RpdiA9IEk5MTVfUkVBRChyZWdzLnBwX2Rpdik7Cj4gLQl9Cj4gIAo+ICAJLyogUHVsbCB0aW1p
bmcgdmFsdWVzIG91dCBvZiByZWdpc3RlcnMgKi8KPiAgCXNlcS0+dDFfdDMgPSAocHBfb24gJiBQ
QU5FTF9QT1dFUl9VUF9ERUxBWV9NQVNLKSA+Pgo+IEBAIC02NDUxLDEzICs2NDUxLDE3IEBAIGlu
dGVsX3Bwc19yZWFkb3V0X2h3X3N0YXRlKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsIHN0cnVj
dCBlZHBfcG93ZXJfc2VxICpzZXEpCj4gIAlzZXEtPnQxMCA9IChwcF9vZmYgJiBQQU5FTF9QT1dF
Ul9ET1dOX0RFTEFZX01BU0spID4+Cj4gIAkJICAgUEFORUxfUE9XRVJfRE9XTl9ERUxBWV9TSElG
VDsKPiAgCj4gLQlpZiAoSVNfR0VOOV9MUChkZXZfcHJpdikgfHwgSEFTX1BDSF9DTlAoZGV2X3By
aXYpIHx8Cj4gLQkgICAgSEFTX1BDSF9JQ1AoZGV2X3ByaXYpKSB7Cj4gKwlpZiAoaTkxNV9tbWlv
X3JlZ192YWxpZChyZWdzLnBwX2RpdikpIHsKPiArCQl1MzIgcHBfZGl2Owo+ICsKPiArCQlwcF9k
aXYgPSBJOTE1X1JFQUQocmVncy5wcF9kaXYpOwo+ICsKPiArCQlzZXEtPnQxMV90MTIgPSAoKHBw
X2RpdiAmIFBBTkVMX1BPV0VSX0NZQ0xFX0RFTEFZX01BU0spID4+Cj4gKwkJCQlQQU5FTF9QT1dF
Ul9DWUNMRV9ERUxBWV9TSElGVCkgKiAxMDAwOwo+ICsKPiArCX0gZWxzZSB7Cj4gIAkJc2VxLT50
MTFfdDEyID0gKChwcF9jdGwgJiBCWFRfUE9XRVJfQ1lDTEVfREVMQVlfTUFTSykgPj4KPiAgCQkJ
CUJYVF9QT1dFUl9DWUNMRV9ERUxBWV9TSElGVCkgKiAxMDAwOwo+IC0JfSBlbHNlIHsKPiAtCQlz
ZXEtPnQxMV90MTIgPSAoKHBwX2RpdiAmIFBBTkVMX1BPV0VSX0NZQ0xFX0RFTEFZX01BU0spID4+
Cj4gLQkJICAgICAgIFBBTkVMX1BPV0VSX0NZQ0xFX0RFTEFZX1NISUZUKSAqIDEwMDA7Cj4gIAl9
Cj4gIH0KPiAgCj4gQEAgLTY1ODIsNyArNjU4Niw3IEBAIGludGVsX2RwX2luaXRfcGFuZWxfcG93
ZXJfc2VxdWVuY2VyX3JlZ2lzdGVycyhzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwLAo+ICAJCQkJ
CSAgICAgIGJvb2wgZm9yY2VfZGlzYWJsZV92ZGQpCj4gIHsKPiAgCXN0cnVjdCBkcm1faTkxNV9w
cml2YXRlICpkZXZfcHJpdiA9IGRwX3RvX2k5MTUoaW50ZWxfZHApOwo+IC0JdTMyIHBwX29uLCBw
cF9vZmYsIHBwX2RpdiwgcG9ydF9zZWwgPSAwOwo+ICsJdTMyIHBwX29uLCBwcF9vZmYsIHBvcnRf
c2VsID0gMDsKPiAgCWludCBkaXYgPSBkZXZfcHJpdi0+cmF3Y2xrX2ZyZXEgLyAxMDAwOwo+ICAJ
c3RydWN0IHBwc19yZWdpc3RlcnMgcmVnczsKPiAgCWVudW0gcG9ydCBwb3J0ID0gZHBfdG9fZGln
X3BvcnQoaW50ZWxfZHApLT5iYXNlLnBvcnQ7Cj4gQEAgLTY2MjEsMTkgKzY2MjUsNiBAQCBpbnRl
bF9kcF9pbml0X3BhbmVsX3Bvd2VyX3NlcXVlbmNlcl9yZWdpc3RlcnMoc3RydWN0IGludGVsX2Rw
ICppbnRlbF9kcCwKPiAgCQkoc2VxLT50OCA8PCBQQU5FTF9MSUdIVF9PTl9ERUxBWV9TSElGVCk7
Cj4gIAlwcF9vZmYgPSAoc2VxLT50OSA8PCBQQU5FTF9MSUdIVF9PRkZfREVMQVlfU0hJRlQpIHwK
PiAgCQkgKHNlcS0+dDEwIDw8IFBBTkVMX1BPV0VSX0RPV05fREVMQVlfU0hJRlQpOwo+IC0JLyog
Q29tcHV0ZSB0aGUgZGl2aXNvciBmb3IgdGhlIHBwIGNsb2NrLCBzaW1wbHkgbWF0Y2ggdGhlIEJz
cGVjCj4gLQkgKiBmb3JtdWxhLiAqLwo+IC0JaWYgKElTX0dFTjlfTFAoZGV2X3ByaXYpIHx8IEhB
U19QQ0hfQ05QKGRldl9wcml2KSB8fAo+IC0JICAgIEhBU19QQ0hfSUNQKGRldl9wcml2KSkgewo+
IC0JCXBwX2RpdiA9IEk5MTVfUkVBRChyZWdzLnBwX2N0cmwpOwo+IC0JCXBwX2RpdiAmPSB+QlhU
X1BPV0VSX0NZQ0xFX0RFTEFZX01BU0s7Cj4gLQkJcHBfZGl2IHw9IChESVZfUk9VTkRfVVAoc2Vx
LT50MTFfdDEyLCAxMDAwKQo+IC0JCQkJPDwgQlhUX1BPV0VSX0NZQ0xFX0RFTEFZX1NISUZUKTsK
PiAtCX0gZWxzZSB7Cj4gLQkJcHBfZGl2ID0gKCgxMDAgKiBkaXYpLzIgLSAxKSA8PCBQUF9SRUZF
UkVOQ0VfRElWSURFUl9TSElGVDsKPiAtCQlwcF9kaXYgfD0gKERJVl9ST1VORF9VUChzZXEtPnQx
MV90MTIsIDEwMDApCj4gLQkJCQk8PCBQQU5FTF9QT1dFUl9DWUNMRV9ERUxBWV9TSElGVCk7Cj4g
LQl9Cj4gIAo+ICAJLyogSGFzd2VsbCBkb2Vzbid0IGhhdmUgYW55IHBvcnQgc2VsZWN0aW9uIGJp
dHMgZm9yIHRoZSBwYW5lbAo+ICAJICogcG93ZXIgc2VxdWVuY2VyIGFueSBtb3JlLiAqLwo+IEBA
IC02NjYwLDE5ICs2NjUxLDMzIEBAIGludGVsX2RwX2luaXRfcGFuZWxfcG93ZXJfc2VxdWVuY2Vy
X3JlZ2lzdGVycyhzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwLAo+ICAKPiAgCUk5MTVfV1JJVEUo
cmVncy5wcF9vbiwgcHBfb24pOwo+ICAJSTkxNV9XUklURShyZWdzLnBwX29mZiwgcHBfb2ZmKTsK
PiAtCWlmIChJU19HRU45X0xQKGRldl9wcml2KSB8fCBIQVNfUENIX0NOUChkZXZfcHJpdikgfHwK
PiAtCSAgICBIQVNfUENIX0lDUChkZXZfcHJpdikpCj4gLQkJSTkxNV9XUklURShyZWdzLnBwX2N0
cmwsIHBwX2Rpdik7Cj4gLQllbHNlCj4gKwo+ICsJLyoKPiArCSAqIENvbXB1dGUgdGhlIGRpdmlz
b3IgZm9yIHRoZSBwcCBjbG9jaywgc2ltcGx5IG1hdGNoIHRoZSBCc3BlYyBmb3JtdWxhLgo+ICsJ
ICovCj4gKwlpZiAoaTkxNV9tbWlvX3JlZ192YWxpZChyZWdzLnBwX2RpdikpIHsKPiArCQl1MzIg
cHBfZGl2Owo+ICsKPiArCQlwcF9kaXYgPSAoKDEwMCAqIGRpdikgLyAyIC0gMSkgPDwgUFBfUkVG
RVJFTkNFX0RJVklERVJfU0hJRlQ7Cj4gKwkJcHBfZGl2IHw9IChESVZfUk9VTkRfVVAoc2VxLT50
MTFfdDEyLCAxMDAwKSA8PAo+ICsJCQkgICBQQU5FTF9QT1dFUl9DWUNMRV9ERUxBWV9TSElGVCk7
Cj4gIAkJSTkxNV9XUklURShyZWdzLnBwX2RpdiwgcHBfZGl2KTsKPiArCX0gZWxzZSB7Cj4gKwkJ
dTMyIHBwX2N0bDsKPiArCj4gKwkJcHBfY3RsID0gSTkxNV9SRUFEKHJlZ3MucHBfY3RybCk7Cj4g
KwkJcHBfY3RsICY9IH5CWFRfUE9XRVJfQ1lDTEVfREVMQVlfTUFTSzsKPiArCQlwcF9jdGwgfD0g
KERJVl9ST1VORF9VUChzZXEtPnQxMV90MTIsIDEwMDApIDw8Cj4gKwkJCSAgIEJYVF9QT1dFUl9D
WUNMRV9ERUxBWV9TSElGVCk7Cj4gKwkJSTkxNV9XUklURShyZWdzLnBwX2N0cmwsIHBwX2N0bCk7
Cj4gKwl9Cj4gIAo+ICAJRFJNX0RFQlVHX0tNUygicGFuZWwgcG93ZXIgc2VxdWVuY2VyIHJlZ2lz
dGVyIHNldHRpbmdzOiBQUF9PTiAlI3gsIFBQX09GRiAlI3gsIFBQX0RJViAlI3hcbiIsCj4gIAkJ
ICAgICAgSTkxNV9SRUFEKHJlZ3MucHBfb24pLAo+ICAJCSAgICAgIEk5MTVfUkVBRChyZWdzLnBw
X29mZiksCj4gLQkJICAgICAgKElTX0dFTjlfTFAoZGV2X3ByaXYpIHx8IEhBU19QQ0hfQ05QKGRl
dl9wcml2KSAgfHwKPiAtCQkgICAgICAgSEFTX1BDSF9JQ1AoZGV2X3ByaXYpKSA/Cj4gLQkJICAg
ICAgKEk5MTVfUkVBRChyZWdzLnBwX2N0cmwpICYgQlhUX1BPV0VSX0NZQ0xFX0RFTEFZX01BU0sp
IDoKPiAtCQkgICAgICBJOTE1X1JFQUQocmVncy5wcF9kaXYpKTsKPiArCQkgICAgICBpOTE1X21t
aW9fcmVnX3ZhbGlkKHJlZ3MucHBfZGl2KSA/Cj4gKwkJICAgICAgSTkxNV9SRUFEKHJlZ3MucHBf
ZGl2KSA6Cj4gKwkJICAgICAgKEk5MTVfUkVBRChyZWdzLnBwX2N0cmwpICYgQlhUX1BPV0VSX0NZ
Q0xFX0RFTEFZX01BU0spKTsKPiAgfQo+ICAKPiAgc3RhdGljIHZvaWQgaW50ZWxfZHBfcHBzX2lu
aXQoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCkKPiAtLSAKPiAyLjIwLjEKPiAKX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcg
bGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl
c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4