From: Unai Martinez-Corral <unai.martinezcorral@ehu.eus>
To: qemu-devel@nongnu.org
Cc: laurent@vivier.eu, riku.voipio@iki.fi, eblake@redhat.com
Subject: [Qemu-devel] [PATCH v3 4/10] qemu-binfmt-conf.sh: remove 'qemu' prefix from cli options
Date: Wed, 6 Mar 2019 04:49:14 +0000 [thread overview]
Message-ID: <20190306044914.GD75@03612eec87fc> (raw)
In-Reply-To: <20190306031221.GA53@03612eec87fc>
This breaks backward compatibility.
Options 'qemu-path' and 'qemu-suffix' have the 'qemu-' prefix, which is
not present in other option names ('debian', 'systemd', 'persistent',
'credential'...). In order to keep consistency, the prefix is removed.
Signed-off-by: Unai Martinez-Corral <unai.martinezcorral@ehu.eus>
---
scripts/qemu-binfmt-conf.sh | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/scripts/qemu-binfmt-conf.sh b/scripts/qemu-binfmt-conf.sh
index e7a714e22c..68aa4c3f78 100755
--- a/scripts/qemu-binfmt-conf.sh
+++ b/scripts/qemu-binfmt-conf.sh
@@ -167,15 +167,15 @@ qemu_get_family() {
usage() {
cat <<EOF
-Usage: qemu-binfmt-conf.sh [--qemu-path PATH][--debian][--systemd CPU]
+Usage: qemu-binfmt-conf.sh [--path PATH][--debian][--systemd CPU]
[--help][--credential][--exportdir PATH]
- [--persistent][--qemu-suffix SUFFIX]
+ [--persistent][--suffix SUFFIX]
Configure binfmt_misc to use qemu interpreter
--help: display this usage
- --qemu-path: set path to qemu interpreter ($QEMU_PATH)
- --qemu-suffix: add a suffix to the default interpreter name
+ --path: set path to qemu interpreter ($QEMU_PATH)
+ --suffix: add a suffix to the default interpreter name
--debian: don't write into /proc,
instead generate update-binfmts templates
--systemd: don't write into /proc,
@@ -328,7 +328,7 @@ QEMU_PERSISTENT="${QEMU_PERSISTENT:-no}"
QEMU_SUFFIX=""
-options=$(getopt -o ds:Q:S:e:hcp -l debian,systemd:,qemu-path:,qemu-suffix:,exportdir:,help,credential,persistent -- "$@")
+options=$(getopt -o ds:Q:S:e:hcp -l debian,systemd:,path:,suffix:,exportdir:,help,credential,persistent -- "$@")
eval set -- "$options"
while true ; do
@@ -360,11 +360,11 @@ while true ; do
fi
fi
;;
- -Q|--qemu-path)
+ -Q|--path)
shift
QEMU_PATH="$1"
;;
- -F|--qemu-suffix)
+ -F|--suffix)
shift
QEMU_SUFFIX="$1"
;;
--
2.20.1
next prev parent reply other threads:[~2019-03-06 4:49 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-06 3:12 [Qemu-devel] [PATCH v3 0/10] qemu-binfmt-conf.sh Unai Martinez-Corral
2019-03-06 4:36 ` [Qemu-devel] [PATCH v3 1/10] qemu-binfmt-conf.sh: enforce safe style consistency Unai Martinez-Corral
2019-03-09 9:30 ` Laurent Vivier
2019-03-06 4:42 ` [Qemu-devel] [PATCH v3 2/10] qemu-binfmt-conf.sh: make opts -p and -c boolean Unai Martinez-Corral
2019-03-09 9:32 ` Laurent Vivier
2019-03-06 4:46 ` [Qemu-devel] [PATCH v3 3/10] qemu-binfmt-conf.sh: add QEMU_CREDENTIAL and QEMU_PERSISTENT Unai Martinez-Corral
2019-03-09 9:42 ` Laurent Vivier
2019-03-09 10:02 ` Unai Martinez Corral
2019-03-06 4:49 ` Unai Martinez-Corral [this message]
2019-03-09 9:43 ` [Qemu-devel] [PATCH v3 4/10] qemu-binfmt-conf.sh: remove 'qemu' prefix from cli options Laurent Vivier
2019-03-06 4:49 ` [Qemu-devel] [PATCH v3 5/10] qemu-binfmt-conf.sh: honour QEMU_PATH and/or QEMU_SUFFIX Unai Martinez-Corral
2019-03-09 9:46 ` Laurent Vivier
2019-03-09 10:24 ` Unai Martinez Corral
2019-03-06 4:50 ` [Qemu-devel] [PATCH v3 6/10] qemu-binfmt-conf.sh: generalize <CPU> to positional <CPUS> Unai Martinez-Corral
2019-03-10 17:02 ` Laurent Vivier
2019-03-11 4:05 ` Unai Martinez Corral
2019-03-06 4:52 ` [Qemu-devel] [PATCH v3 7/10] qemu-binfmt-conf.sh: add option --reset <ARCHS> Unai Martinez-Corral
2019-03-10 17:15 ` Laurent Vivier
2019-03-11 5:03 ` Unai Martinez Corral
2019-03-06 4:53 ` [Qemu-devel] [PATCH v3 8/10] qemu-binfmt-conf.sh: refactor usage() Unai Martinez-Corral
2019-03-10 17:17 ` Laurent Vivier
2019-03-06 4:54 ` [Qemu-devel] [PATCH v3 9/10] qemu-binfmt-conf.sh: update usage() Unai Martinez-Corral
2019-03-10 17:20 ` Laurent Vivier
2019-03-06 4:55 ` [Qemu-devel] [PATCH v3 10/10] qemu-binfmt-conf.sh: support QEMU_TARGETS Unai Martinez-Corral
2019-03-10 17:25 ` Laurent Vivier
2019-03-06 4:59 ` [Qemu-devel] [PATCH v3 0/10] qemu-binfmt-conf.sh no-reply
2019-03-09 9:33 ` no-reply
2019-03-09 9:36 ` no-reply
2019-03-09 9:47 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190306044914.GD75@03612eec87fc \
--to=unai.martinezcorral@ehu.eus \
--cc=eblake@redhat.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.