From: Kevin Wolf <kwolf@redhat.com>
To: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"qemu-block@nongnu.org" <qemu-block@nongnu.org>,
"armbru@redhat.com" <armbru@redhat.com>,
"mreitz@redhat.com" <mreitz@redhat.com>,
Denis Lunev <den@virtuozzo.com>,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
Roman Kagan <rkagan@virtuozzo.com>
Subject: Re: [Qemu-devel] [PATCH 2/3] iotests: ask QEMU for supported formats
Date: Wed, 6 Mar 2019 19:07:09 +0100 [thread overview]
Message-ID: <20190306180709.GL6818@localhost.localdomain> (raw)
In-Reply-To: <415d46bc-5b5a-fc1a-1b5c-6fc3dd2a73cc@virtuozzo.com>
Am 06.03.2019 um 18:59 hat Andrey Shinkevich geschrieben:
> On 06/03/2019 17:51, Kevin Wolf wrote:
> > This fixes it for me (the first hunk is actually a bonus which fixes a
> > preexisting bug, which somehow meant that the reason was not printed):
> >
> > diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
> > index e6ae4e91b7..b41ac4be51 100644
> > --- a/tests/qemu-iotests/iotests.py
> > +++ b/tests/qemu-iotests/iotests.py
> > @@ -712,7 +712,7 @@ def notrun(reason):
> > # Each test in qemu-iotests has a number ("seq")
> > seq = os.path.basename(sys.argv[0])
> >
> > - open('%s/%s.notrun' % (output_dir, seq), 'wb').write(reason + '\n')
> > + open('%s/%s.notrun' % (output_dir, seq), 'wt').write(reason + '\n')
> > print('%s not run: %s' % (seq, reason))
> > sys.exit(0)
> >
>
> Thanks a lot. I am going to add the fix above as a separate patch in v3
> with "Signed-off-by: Kevin Wolf <kwolf@redhat.com>"
Sounds good to me, thanks!
Kevin
next prev parent reply other threads:[~2019-03-06 18:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-04 10:08 [Qemu-devel] [PATCH 0/3] iotests: check whitelisted formats Andrey Shinkevich
2019-03-04 10:08 ` [Qemu-devel] [PATCH 1/3] block: iterate_format with account of whitelisting Andrey Shinkevich
2019-03-04 10:08 ` [Qemu-devel] [PATCH 2/3] iotests: ask QEMU for supported formats Andrey Shinkevich
2019-03-06 14:31 ` Kevin Wolf
2019-03-06 18:03 ` Andrey Shinkevich
2019-03-06 14:51 ` Kevin Wolf
2019-03-06 17:59 ` Andrey Shinkevich
2019-03-06 18:07 ` Kevin Wolf [this message]
2019-03-04 10:08 ` [Qemu-devel] [PATCH 3/3] iotests: check whitelisted formats Andrey Shinkevich
2019-03-06 14:52 ` Kevin Wolf
2019-03-06 17:53 ` Andrey Shinkevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190306180709.GL6818@localhost.localdomain \
--to=kwolf@redhat.com \
--cc=andrey.shinkevich@virtuozzo.com \
--cc=armbru@redhat.com \
--cc=den@virtuozzo.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rkagan@virtuozzo.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.