From: Stefano Brivio <sbrivio@redhat.com>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Eric Dumazet <eric.dumazet@gmail.com>,
syzbot <syzkaller@googlegroups.com>,
Sabrina Dubroca <sd@queasysnail.net>
Subject: Re: [PATCH net] fou, fou6: avoid uninit-value in gue_err() and gue6_err()
Date: Wed, 6 Mar 2019 20:33:13 +0100 [thread overview]
Message-ID: <20190306203313.60c413a3@redhat.com> (raw)
In-Reply-To: <20190306184100.190813-1-edumazet@google.com>
On Wed, 6 Mar 2019 10:41:00 -0800
Eric Dumazet <edumazet@google.com> wrote:
> My prior commit missed the fact that these functions
> were using udp_hdr() (aka skb_transport_header())
> to get access to GUE header.
Ouch, I totally missed this too. :/
> Since use pskb_transport_may_pull() does not exist yet,
Nit: s/use //
> we have to add transport_offset to our pskb_may_pull() calls.
Thanks for fixing this.
Acked-by: Stefano Brivio <sbrivio@redhat.com>
--
Stefano
next prev parent reply other threads:[~2019-03-06 19:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-06 18:41 [PATCH net] fou, fou6: avoid uninit-value in gue_err() and gue6_err() Eric Dumazet
2019-03-06 19:33 ` Stefano Brivio [this message]
2019-03-08 23:20 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190306203313.60c413a3@redhat.com \
--to=sbrivio@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sd@queasysnail.net \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.