From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [RFC v4 5/6] drm/i915/dp: Change a link bandwidth computation for DP YCbCr 4:2:0 output Date: Wed, 6 Mar 2019 23:04:42 +0200 Message-ID: <20190306210442.GR3888@intel.com> References: <20190306193102.306-1-gwan-gyeong.mun@intel.com> <20190306193102.306-6-gwan-gyeong.mun@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id F32BD6E1BF for ; Wed, 6 Mar 2019 21:04:45 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190306193102.306-6-gwan-gyeong.mun@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Gwan-gyeong Mun Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBNYXIgMDYsIDIwMTkgYXQgMDk6MzE6MDFQTSArMDIwMCwgR3dhbi1neWVvbmcgTXVu IHdyb3RlOgo+IEFsbCBvZiB0aGUgbGluayBiYW5kd2lkdGggYW5kIERhdGEgTS9OIGNhbGN1bGF0 aW9ucyB3ZXJlIGFzc3VtZWQgYSBicHAgYXMKPiBSR0IgZm9ybWF0LiBCdXQgV2hlbiB3ZSBhcmUg dXNpbmcgWUNiQ3IgNDoyOjAgb3V0cHV0IGZvcm1hdCBvbiBEUCwKPiB3ZSBzaG91bGQgY2hhbmdl IGJwcCBjYWxjdWxhdGlvbnMgYXMgWUNiQ3IgNDoyOjAgZm9ybWF0Lgo+IFRoZSBwaXBlX2JwcCB2 YWx1ZSB3YXMgYXNzdW1lZCBSR0IgZm9ybWF0LCB0aGVyZWZvcmUsIGl0IHdhcyBtdWx0aXBsaWVk Cj4gd2l0aCAzLiBCdXQgWUNiQ3IgNDoyOjAgcmVxdWlyZXMgYSBtdWx0aXBsaWVyIHZhbHVlIHRv IDEuNS4KPiBUaGVyZWZvcmUgd2UgbmVlZCB0byBkaXZpZGUgcGlwZV9icHAgdG8gMiB3aGlsZSBE UCBvdXRwdXQgdXNlcyBZQ2JDcjQ6MjowCj4gZm9ybWF0Lgo+ICAtIFJHQiBmb3JtYXQgYnBwID0g YnBjIHggMwo+ICAtIFlDYkNyIDQ6MjowIGZvcm1hdCBicHAgPSBicGMgeCAxLjUKPiAKPiBBbmQg aXQgYWRkcyBtaXNzZWQgYnBjIHZhbHVlcyBmb3IgYSBwcm9ncmFtbWluZyBvZiBWU0MgSGVhZGVy Lgo+IEl0IG9ubHkgYWZmZWN0cyBkcCBhbmQgZWRwIHBvcnQgd2hpY2ggdXNlIFlDYkNyIDQ6Mjow IG91dHB1dCBmb3JtYXQuCj4gQW5kIGZvciBub3csIGl0IGRvZXMgbm90IGNvbnNpZGVyIGEgdXNl IGNhc2Ugb2YgRFNDICsgWUNiQ3IgNDoyOjAuCj4gCj4gdjI6Cj4gICBBZGRyZXNzZWQgcmV2aWV3 IGNvbW1lbnRzIGZyb20gVmlsbGUuCj4gICBSZW1vdmUgYSBjaGFuZ2luZyBvZiBwaXBlX2JwcCBv biBpbnRlbF9kZGlfc2V0X3BpcGVfc2V0dGluZ3MoKS4KPiAgIEJlY2F1c2UgdGhlIHBpcGUgaXMg cnVubmluZyBhdCB0aGUgZnVsbCBicHAsIGtlZXAgcGlwZV9icHAgYXMgUkdCCj4gICBldmVuIHRo b3VnaCBZQ2JDciA0OjI6MCBvdXRwdXQgZm9ybWF0IGlzIHVzZWQuCj4gICBBZGQgYSBsaW5rIGJh bmR3aWR0aCBjb21wdXRhdGlvbiBmb3IgWUNiQ3I0OjI6MCBvdXRwdXQgZm9ybWF0Lgo+IAo+IFNp Z25lZC1vZmYtYnk6IEd3YW4tZ3llb25nIE11biA8Z3dhbi1neWVvbmcubXVuQGludGVsLmNvbT4K PiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYyB8IDY0ICsrKysrKysrKysr KysrKysrKysrKysrKysrKysrLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNTcgaW5zZXJ0aW9ucygr KSwgNyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZHAuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiBpbmRleCA3NGYw NTE0MjhmYjIuLmM2ODI2Y2RhOGM1ZiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9kcC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+IEBA IC0xNzIzLDcgKzE3MjMsOCBAQCB2b2lkIGludGVsX2RwX2NvbXB1dGVfcmF0ZShzdHJ1Y3QgaW50 ZWxfZHAgKmludGVsX2RwLCBpbnQgcG9ydF9jbG9jaywKPiAgc3RydWN0IGxpbmtfY29uZmlnX2xp bWl0cyB7Cj4gIAlpbnQgbWluX2Nsb2NrLCBtYXhfY2xvY2s7Cj4gIAlpbnQgbWluX2xhbmVfY291 bnQsIG1heF9sYW5lX2NvdW50Owo+IC0JaW50IG1pbl9icHAsIG1heF9icHA7Cj4gKwlpbnQgbWlu X2JwcCwgbWF4X2JwcCwgYnBwX3N0ZXA7Cj4gKwlib29sIGlzX3ljYmNyNDIwOwo+ICB9Owo+ICAK PiAgc3RhdGljIGJvb2wgaW50ZWxfZHBfc291cmNlX3N1cHBvcnRzX2ZlYyhzdHJ1Y3QgaW50ZWxf ZHAgKmludGVsX2RwLAo+IEBAIC0xODMzLDcgKzE4MzQsNyBAQCBpbnRlbF9kcF9jb21wdXRlX2xp bmtfY29uZmlnX3dpZGUoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCwKPiAgCWludCBicHAsIGNs b2NrLCBsYW5lX2NvdW50Owo+ICAJaW50IG1vZGVfcmF0ZSwgbGlua19jbG9jaywgbGlua19hdmFp bDsKPiAgCj4gLQlmb3IgKGJwcCA9IGxpbWl0cy0+bWF4X2JwcDsgYnBwID49IGxpbWl0cy0+bWlu X2JwcDsgYnBwIC09IDIgKiAzKSB7Cj4gKwlmb3IgKGJwcCA9IGxpbWl0cy0+bWF4X2JwcDsgYnBw ID49IGxpbWl0cy0+bWluX2JwcDsgYnBwIC09IGxpbWl0cy0+YnBwX3N0ZXApIHsKPiAgCQltb2Rl X3JhdGUgPSBpbnRlbF9kcF9saW5rX3JlcXVpcmVkKGFkanVzdGVkX21vZGUtPmNydGNfY2xvY2ss Cj4gIAkJCQkJCSAgIGJwcCk7Cj4gIAo+IEBAIC0xODQ3LDcgKzE4NDgsMTAgQEAgaW50ZWxfZHBf Y29tcHV0ZV9saW5rX2NvbmZpZ193aWRlKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsCj4gIAo+ ICAJCQkJaWYgKG1vZGVfcmF0ZSA8PSBsaW5rX2F2YWlsKSB7Cj4gIAkJCQkJcGlwZV9jb25maWct PmxhbmVfY291bnQgPSBsYW5lX2NvdW50Owo+IC0JCQkJCXBpcGVfY29uZmlnLT5waXBlX2JwcCA9 IGJwcDsKPiArCQkJCQlpZiAobGltaXRzLT5pc195Y2JjcjQyMCkKPiArCQkJCQkJcGlwZV9jb25m aWctPnBpcGVfYnBwID0gYnBwICogMjsKPiArCQkJCQllbHNlCj4gKwkJCQkJCXBpcGVfY29uZmln LT5waXBlX2JwcCA9IGJwcDsKClRoaXMgYXBwcm9hY2ggZmVlbHMgbmVlZGxlc3NseSBjb21wbGlj YXRlZC4KCkNhbid0IHdlIGp1c3QgZG8gc29tZXRoaW5nIGxpa2UgdGhpcz8KCnN0YXRpYyBpbnQg aW50ZWxfZHBfb3V0cHV0X2JwcChjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19z dGF0ZSwgaW50IGJwcCkKewoJaWYgKGNydGNfc3RhdGUtPm91dHB1dF9mb3JtYXQgPT0gSU5URUxf T1VUUFVUX0ZPUk1BVF9ZQ0JDUjQyMCkKCQlicHAgLz0gMjsKIAlyZXR1cm4gYnBwOwp9CgppbnRl bF9kcF9jb21wdXRlX2xpbmtfY29uZmlnXyooc3RydWN0IGludGVsX2RwICppbnRlbF9kcCwKewou Li4KCWZvciAoYnBwID0gbGltaXRzLT5tYXhfYnBwOyBicHAgPj0gbGltaXRzLT5taW5fYnBwOyBi cHAgLT0gMiAqIDMpIHsKKwkJaW50IG91dHB1dF9icHAgPSBpbnRlbF9kcF9vdXRwdXRfYnBwKHBp cGVfY29uZmlnLCBicHApOworCiAgICAgICAgICAgICAgICBtb2RlX3JhdGUgPSBpbnRlbF9kcF9s aW5rX3JlcXVpcmVkKGFkanVzdGVkX21vZGUtPmNydGNfY2xvY2ssCi0JCQkJCQkgICBicHApOwor CQkJCQkJICAgb3V0cHV0X2JwcCk7CgoKPiAgCQkJCQlwaXBlX2NvbmZpZy0+cG9ydF9jbG9jayA9 IGxpbmtfY2xvY2s7Cj4gIAo+ICAJCQkJCXJldHVybiAwOwo+IEBAIC0xODY5LDcgKzE4NzMsNyBA QCBpbnRlbF9kcF9jb21wdXRlX2xpbmtfY29uZmlnX2Zhc3Qoc3RydWN0IGludGVsX2RwICppbnRl bF9kcCwKPiAgCWludCBicHAsIGNsb2NrLCBsYW5lX2NvdW50Owo+ICAJaW50IG1vZGVfcmF0ZSwg bGlua19jbG9jaywgbGlua19hdmFpbDsKPiAgCj4gLQlmb3IgKGJwcCA9IGxpbWl0cy0+bWF4X2Jw cDsgYnBwID49IGxpbWl0cy0+bWluX2JwcDsgYnBwIC09IDIgKiAzKSB7Cj4gKwlmb3IgKGJwcCA9 IGxpbWl0cy0+bWF4X2JwcDsgYnBwID49IGxpbWl0cy0+bWluX2JwcDsgYnBwIC09IGxpbWl0cy0+ YnBwX3N0ZXApIHsKPiAgCQltb2RlX3JhdGUgPSBpbnRlbF9kcF9saW5rX3JlcXVpcmVkKGFkanVz dGVkX21vZGUtPmNydGNfY2xvY2ssCj4gIAkJCQkJCSAgIGJwcCk7Cj4gIAo+IEBAIC0xODgzLDcg KzE4ODcsMTAgQEAgaW50ZWxfZHBfY29tcHV0ZV9saW5rX2NvbmZpZ19mYXN0KHN0cnVjdCBpbnRl bF9kcCAqaW50ZWxfZHAsCj4gIAo+ICAJCQkJaWYgKG1vZGVfcmF0ZSA8PSBsaW5rX2F2YWlsKSB7 Cj4gIAkJCQkJcGlwZV9jb25maWctPmxhbmVfY291bnQgPSBsYW5lX2NvdW50Owo+IC0JCQkJCXBp cGVfY29uZmlnLT5waXBlX2JwcCA9IGJwcDsKPiArCQkJCQlpZiAobGltaXRzLT5pc195Y2JjcjQy MCkKPiArCQkJCQkJcGlwZV9jb25maWctPnBpcGVfYnBwID0gYnBwICogMjsKPiArCQkJCQllbHNl Cj4gKwkJCQkJCXBpcGVfY29uZmlnLT5waXBlX2JwcCA9IGJwcDsKPiAgCQkJCQlwaXBlX2NvbmZp Zy0+cG9ydF9jbG9jayA9IGxpbmtfY2xvY2s7Cj4gIAo+ICAJCQkJCXJldHVybiAwOwo+IEBAIC0y MDE1LDYgKzIwMjIsOCBAQCBpbnRlbF9kcF9jb21wdXRlX2xpbmtfY29uZmlnKHN0cnVjdCBpbnRl bF9lbmNvZGVyICplbmNvZGVyLAo+ICAJc3RydWN0IGxpbmtfY29uZmlnX2xpbWl0cyBsaW1pdHM7 Cj4gIAlpbnQgY29tbW9uX2xlbjsKPiAgCWludCByZXQ7Cj4gKwlib29sIGlzX3ljYmNyNDIwID0K PiArCQlwaXBlX2NvbmZpZy0+b3V0cHV0X2Zvcm1hdCA9PSBJTlRFTF9PVVRQVVRfRk9STUFUX1lD QkNSNDIwID8gdHJ1ZSA6IGZhbHNlOwo+ICAKPiAgCWNvbW1vbl9sZW4gPSBpbnRlbF9kcF9jb21t b25fbGVuX3JhdGVfbGltaXQoaW50ZWxfZHAsCj4gIAkJCQkJCSAgICBpbnRlbF9kcC0+bWF4X2xp bmtfcmF0ZSk7Cj4gQEAgLTIwMzAsNiArMjAzOSwyMCBAQCBpbnRlbF9kcF9jb21wdXRlX2xpbmtf Y29uZmlnKHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyLAo+ICAKPiAgCWxpbWl0cy5taW5f YnBwID0gNiAqIDM7Cj4gIAlsaW1pdHMubWF4X2JwcCA9IGludGVsX2RwX2NvbXB1dGVfYnBwKGlu dGVsX2RwLCBwaXBlX2NvbmZpZyk7Cj4gKwlsaW1pdHMuYnBwX3N0ZXAgPSAyICogMzsKPiArCj4g KwlsaW1pdHMuaXNfeWNiY3I0MjAgPSBpc195Y2JjcjQyMDsKPiArCj4gKwlpZiAoaXNfeWNiY3I0 MjApIHsKPiArCQkvKgo+ICsJCSAqIGJwcCB2YWx1ZSB3YXMgYXNzdW1lZCB0byBSR0IgdGhlcmVm b3JlIGl0IHdhcyBtdWx0aXBsaWVkCj4gKwkJICogd2l0aCAzLiBCdXQgWUNiQ3IgNDoyOjAgcmVx dWlyZXMgbXVsdGlwbGllciB2YWx1ZSB0byAxLjUKPiArCQkgKiB0aGVyZWZvcmUgaXQgZGl2aWRl cyBwaXBlX2JwcCB0byAyLgo+ICsJCSAqLwo+ICsJCWxpbWl0cy5taW5fYnBwIC89IDI7Cj4gKwkJ bGltaXRzLm1heF9icHAgLz0gMjsKPiArCQlsaW1pdHMuYnBwX3N0ZXAgLz0gMjsKPiArCX0KPiAg Cj4gIAlpZiAoaW50ZWxfZHBfaXNfZWRwKGludGVsX2RwKSAmJiBpbnRlbF9kcC0+ZWRwX2RwY2Rb MF0gPCBEUF9FRFBfMTQpIHsKPiAgCQkvKgo+IEBAIC0yMjI0LDEzICsyMjQ3LDIzIEBAIGludGVs X2RwX2NvbXB1dGVfY29uZmlnKHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyLAo+ICAJCQlp bnRlbF9jb25uX3N0YXRlLT5icm9hZGNhc3RfcmdiID09IElOVEVMX0JST0FEQ0FTVF9SR0JfTElN SVRFRDsKPiAgCX0KPiAgCj4gLQlpZiAoIXBpcGVfY29uZmlnLT5kc2NfcGFyYW1zLmNvbXByZXNz aW9uX2VuYWJsZSkKPiAtCQlpbnRlbF9saW5rX2NvbXB1dGVfbV9uKHBpcGVfY29uZmlnLT5waXBl X2JwcCwKPiArCWlmICghcGlwZV9jb25maWctPmRzY19wYXJhbXMuY29tcHJlc3Npb25fZW5hYmxl KSB7Cj4gKwkJLyoKPiArCQkgKiBCYXNpY2FsbHksIHBpcGVfYnBwIHZhbHVlIGlzIGFzc3VtZWQg dG8gUkdCLgo+ICsJCSAqIEFuZCBvbiB0aGUgY2FsY3VsYXRpb24gb2YgRGF0YSBNIGFuZCBEYXRh IE4sIFlDYkNyIDQ6MjowCj4gKwkJICogb3V0cHV0IGZvcm1hdCBvZiB0aGUgbnVtYmVyIG9mIGJ5 dGVzIHBlciBwaXhlbCB3aWxsIGJlIGhhbGYKPiArCQkgKiB0aGUgbnVtYmVyIG9mIGJ5dGVzIG9m IFJHQiBwaXhlbC4KPiArCQkgKi8KPiArCQlpbnQgcGlwZV9icHAgPSBwaXBlX2NvbmZpZy0+b3V0 cHV0X2Zvcm1hdCA9PSBJTlRFTF9PVVRQVVRfRk9STUFUX1lDQkNSNDIwID8KPiArCQkJcGlwZV9j b25maWctPnBpcGVfYnBwIC8gMiA6IHBpcGVfY29uZmlnLT5waXBlX2JwcDsKPiArCj4gKwkJaW50 ZWxfbGlua19jb21wdXRlX21fbihwaXBlX2JwcCwKPiAgCQkJCSAgICAgICBwaXBlX2NvbmZpZy0+ bGFuZV9jb3VudCwKPiAgCQkJCSAgICAgICBhZGp1c3RlZF9tb2RlLT5jcnRjX2Nsb2NrLAo+ICAJ CQkJICAgICAgIHBpcGVfY29uZmlnLT5wb3J0X2Nsb2NrLAo+ICAJCQkJICAgICAgICZwaXBlX2Nv bmZpZy0+ZHBfbV9uLAo+ICAJCQkJICAgICAgIGNvbnN0YW50X24pOwo+ICsJfQo+ICAJZWxzZQo+ ICAJCWludGVsX2xpbmtfY29tcHV0ZV9tX24ocGlwZV9jb25maWctPmRzY19wYXJhbXMuY29tcHJl c3NlZF9icHAsCj4gIAkJCQkgICAgICAgcGlwZV9jb25maWctPmxhbmVfY291bnQsCj4gQEAgLTQ0 NTgsNiArNDQ5MSwyMyBAQCBpbnRlbF9waXhlbF9lbmNvZGluZ19zZXR1cF92c2Moc3RydWN0IGlu dGVsX2RwICppbnRlbF9kcCwKPiAgCSAqIDEwMGIgPSAxNmJwYy4KPiAgCSAqLwo+ICAJdnNjX3Nk cC5EQjE3ID0gMHgxOwo+ICsJc3dpdGNoIChjcnRjX3N0YXRlLT5waXBlX2JwcCAvIDMpIHsKPiAr CWNhc2UgODogLyogOGJwYyAqLwo+ICsJCXZzY19zZHAuREIxNyA9IDB4MTsKPiArCQlicmVhazsK PiArCWNhc2UgMTA6IC8qIDEwYnBjICovCj4gKwkJdnNjX3NkcC5EQjE3ID0gMHgyOwo+ICsJCWJy ZWFrOwo+ICsJY2FzZSAxMjogLyogMTJicGMgKi8KPiArCQl2c2Nfc2RwLkRCMTcgPSAweDM7Cj4g KwkJYnJlYWs7Cj4gKwljYXNlIDE2OiAvKiAxNmJwYyAqLwo+ICsJCXZzY19zZHAuREIxNyA9IDB4 NDsKPiArCQlicmVhazsKPiArCWRlZmF1bHQ6Cj4gKwkJRFJNX0RFQlVHX0tNUygiSW52YWxpZCBi cHAgdmFsdWUgJyVkJ1xuIiwgY3J0Y19zdGF0ZS0+cGlwZV9icHApOwo+ICsJCWJyZWFrOwo+ICsJ fQo+ICAKPiAgCS8qCj4gIAkgKiBDb250ZW50IFR5cGUgKEJpdHMgMjowKQo+IC0tIAo+IDIuMjEu MAoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9pbnRlbC1nZng=