From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EEB1C43381 for ; Thu, 7 Mar 2019 00:07:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 55C99206DD for ; Thu, 7 Mar 2019 00:07:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726207AbfCGAH5 (ORCPT ); Wed, 6 Mar 2019 19:07:57 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:40120 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725790AbfCGAH5 (ORCPT ); Wed, 6 Mar 2019 19:07:57 -0500 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92 #3 (Red Hat Linux)) id 1h1gZn-0008Ha-F0; Thu, 07 Mar 2019 00:07:55 +0000 Date: Thu, 7 Mar 2019 00:07:55 +0000 From: Al Viro To: zhengbin Cc: bcrl@kvack.org, linux-fsdevel@vger.kernel.org, linux-aio@kvack.org, houtao1@huawei.com, yi.zhang@huawei.com Subject: Re: [PATCH] fix syzkaller task hung in exit_aio Message-ID: <20190307000755.GX2217@ZenIV.linux.org.uk> References: <1551880403-132638-1-git-send-email-zhengbin13@huawei.com> <20190306194455.GV2217@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190306194455.GV2217@ZenIV.linux.org.uk> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Mar 06, 2019 at 07:44:55PM +0000, Al Viro wrote: > Leak on error is real (see thread a few days ago), and overall logics for > "woken" should be similar to what you suggest, but I'd rather handle it > slightly differently (see the same thread). > > I've a patch that ought to fix that and it seems to survive testing; I'll > post once I finish carving it up - too many cleanups mixed into it. Give > me a couple of hours; should be done (and posted) by then. Carved up and posted - sorry, too longer than I hoped ;-/