From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19F73C43381 for ; Thu, 7 Mar 2019 00:26:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DA85420675 for ; Thu, 7 Mar 2019 00:26:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="upESCx2a" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726094AbfCGA0y (ORCPT ); Wed, 6 Mar 2019 19:26:54 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:48758 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725790AbfCGA0y (ORCPT ); Wed, 6 Mar 2019 19:26:54 -0500 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C8F99242; Thu, 7 Mar 2019 01:26:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1551918412; bh=eM7+ngoHOlZzfZHrqW0GFbNoTQct34BUKGkR5pdiW7I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=upESCx2aaZRDq7AFqtNYcRiAH22vYOHnl839Yubc3BCh8a3aQhcwbP39KnNa5TVEU G2wORlWxCflHrjCt6CSNQe7J0Dsbe84q8pRh+i/Db4yECLJVPQVOowZHRcYVYg0v0i qqg+lqqYWHc1T3Scj3YNUo2qkuRZkcc6DciwMOQA= Date: Thu, 7 Mar 2019 02:26:45 +0200 From: Laurent Pinchart To: Niklas =?utf-8?Q?S=C3=B6derlund?= Cc: linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH] rcar-csi2: Allow configuring of video standard Message-ID: <20190307002645.GJ4791@pendragon.ideasonboard.com> References: <20190216225758.7699-1-niklas.soderlund+renesas@ragnatech.se> <20190307001318.GF4791@pendragon.ideasonboard.com> <20190307002236.GJ9239@bigcity.dyn.berto.se> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190307002236.GJ9239@bigcity.dyn.berto.se> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Niklas, On Thu, Mar 07, 2019 at 01:22:36AM +0100, Niklas Söderlund wrote: > On 2019-03-07 02:13:18 +0200, Laurent Pinchart wrote: > > On Sat, Feb 16, 2019 at 11:57:58PM +0100, Niklas Söderlund wrote: > >> Allow the hardware to to do proper field detection for interlaced field > >> formats by implementing s_std() and g_std(). Depending on which video > >> standard is selected the driver needs to setup the hardware to correctly > >> identify fields. > > > > I don't think this belongs to the CSI-2 receiver. Standards are really > > an analog concept, and should be handled by the analog front-end. At the > > CSI-2 level there's no concept of analog standard anymore. > > I agree it should be handled by the analog front-end. This is patch just > lets the user propagate the information in the pipeline. The driver > could instead find its source subdevice in the media graph and ask which > standard it's supplying. > > I wrestled a bit with this and went with this approach as it then works > the same as with other format information, such as dimensions and pixel > format. If the driver acquires the standard by itself why should it no > the same for the format? I'm willing to change this but I would like to > understand where the divider for format propagating in kernel and > user-space is :-) > > Also what if there are subdevices between rcar-csi2 and the analog > front-end which do not support the g_std operation? My point is that the analog standard shouldn't be propagated at all, neither inside the kernel nor in userspace, as it is not applicable to CSI-2. > >> Later versions of the datasheet have also been updated to make it clear > >> that FLD register should be set to 0 when dealing with none interlaced > >> field formats. > >> > >> Signed-off-by: Niklas Söderlund > >> --- > >> drivers/media/platform/rcar-vin/rcar-csi2.c | 33 +++++++++++++++++++-- > >> 1 file changed, 30 insertions(+), 3 deletions(-) > >> > >> diff --git a/drivers/media/platform/rcar-vin/rcar-csi2.c b/drivers/media/platform/rcar-vin/rcar-csi2.c > >> index f3099f3e536d808a..664d3784be2b9db9 100644 > >> --- a/drivers/media/platform/rcar-vin/rcar-csi2.c > >> +++ b/drivers/media/platform/rcar-vin/rcar-csi2.c > >> @@ -361,6 +361,7 @@ struct rcar_csi2 { > >> struct v4l2_subdev *remote; > >> > >> struct v4l2_mbus_framefmt mf; > >> + v4l2_std_id std; > >> > >> struct mutex lock; > >> int stream_count; > >> @@ -389,6 +390,22 @@ static void rcsi2_write(struct rcar_csi2 *priv, unsigned int reg, u32 data) > >> iowrite32(data, priv->base + reg); > >> } > >> > >> +static int rcsi2_s_std(struct v4l2_subdev *sd, v4l2_std_id std) > >> +{ > >> + struct rcar_csi2 *priv = sd_to_csi2(sd); > >> + > >> + priv->std = std; > >> + return 0; > >> +} > >> + > >> +static int rcsi2_g_std(struct v4l2_subdev *sd, v4l2_std_id *std) > >> +{ > >> + struct rcar_csi2 *priv = sd_to_csi2(sd); > >> + > >> + *std = priv->std; > >> + return 0; > >> +} > >> + > >> static void rcsi2_standby_mode(struct rcar_csi2 *priv, int on) > >> { > >> if (!on) { > >> @@ -475,7 +492,7 @@ static int rcsi2_calc_mbps(struct rcar_csi2 *priv, unsigned int bpp) > >> static int rcsi2_start_receiver(struct rcar_csi2 *priv) > >> { > >> const struct rcar_csi2_format *format; > >> - u32 phycnt, vcdt = 0, vcdt2 = 0; > >> + u32 phycnt, vcdt = 0, vcdt2 = 0, fld = 0; > >> unsigned int i; > >> int mbps, ret; > >> > >> @@ -507,6 +524,15 @@ static int rcsi2_start_receiver(struct rcar_csi2 *priv) > >> vcdt2 |= vcdt_part << ((i % 2) * 16); > >> } > >> > >> + if (priv->mf.field != V4L2_FIELD_NONE) { > >> + fld = FLD_FLD_EN4 | FLD_FLD_EN3 | FLD_FLD_EN2 | FLD_FLD_EN; > >> + > >> + if (priv->std & V4L2_STD_525_60) > >> + fld |= FLD_FLD_NUM(2); > >> + else > >> + fld |= FLD_FLD_NUM(1); > >> + } > >> + > >> phycnt = PHYCNT_ENABLECLK; > >> phycnt |= (1 << priv->lanes) - 1; > >> > >> @@ -519,8 +545,7 @@ static int rcsi2_start_receiver(struct rcar_csi2 *priv) > >> rcsi2_write(priv, PHTC_REG, 0); > >> > >> /* Configure */ > >> - rcsi2_write(priv, FLD_REG, FLD_FLD_NUM(2) | FLD_FLD_EN4 | > >> - FLD_FLD_EN3 | FLD_FLD_EN2 | FLD_FLD_EN); > >> + rcsi2_write(priv, FLD_REG, fld); > >> rcsi2_write(priv, VCDT_REG, vcdt); > >> if (vcdt2) > >> rcsi2_write(priv, VCDT2_REG, vcdt2); > >> @@ -662,6 +687,8 @@ static int rcsi2_get_pad_format(struct v4l2_subdev *sd, > >> } > >> > >> static const struct v4l2_subdev_video_ops rcar_csi2_video_ops = { > >> + .s_std = rcsi2_s_std, > >> + .g_std = rcsi2_g_std, > >> .s_stream = rcsi2_s_stream, > >> }; > >> -- Regards, Laurent Pinchart