From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Jakub Kicinski <kubakici@wp.pl>
Cc: Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>,
Xose Vazquez Perez <xose.vazquez@gmail.com>,
Felix Fietkau <nbd@nbd.name>,
Lorenzo Bianconi <lorenzo@kernel.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
Hans Ulli Kroll <ulli.kroll@googlemail.com>
Subject: Re: mediatek: duplicate usb devices
Date: Thu, 7 Mar 2019 11:21:22 +0100 [thread overview]
Message-ID: <20190307102120.GA18424@redhat.com> (raw)
In-Reply-To: <20190306104240.64a26c51@cakuba.hsd1.ca.comcast.net>
On Wed, Mar 06, 2019 at 10:42:40AM -0800, Jakub Kicinski wrote:
> On Wed, 6 Mar 2019 12:03:30 +0100, Stanislaw Gruszka wrote:
> > On Wed, Mar 06, 2019 at 11:09:12AM +0100, Lorenzo Bianconi wrote:
> > > >
> > > > On Tue, Mar 05, 2019 at 07:33:51PM +0100, Xose Vazquez Perez wrote:
> > > > > There a three duplicate devices at:
> > > > >
> > > > > mt76/mt76x2/usb.c: { USB_DEVICE(0x0e8d, 0x7612) }, /* Alfa AWUS036ACM */
> > > > > mt76/mt76x2/usb.c: { USB_DEVICE(0x0e8d, 0x7612) }, /* Aukey USB-AC1200 */
> > > > One duplicated entry should be removed.
> > > >
> > > > > mt76/mt76x0/usb.c: { USB_DEVICE(0x148f, 0x760a) }, /* TP-Link unknown */
> > > > > mt7601u/usb.c: { USB_DEVICE(0x148f, 0x760a) },
> > >
> > > IIUC this is not in the mt7601u driver available on mtk website.
> >
> > The same apply to mt7610u. Vendor driver have only IDs for some
> > reference devices. Both mt7601u and mt7610u drivers do not include
> > 0x7610.
> >
> > For mt76x0u ids were provided by Hans
> > https://lore.kernel.org/linux-wireless/alpine.LNX.2.00.1804092042320.8369@T420s/
> > I'm not sure where they came from.
>
> The ones in mt7601u came from Xose, the GitHub repo has fuller history:
>
> https://github.com/kuba-moo/mt7601u/commit/5e6b565301d9882aab9af46b396a5cf489db6c78
>
> I don't really mind which one stays :)
I think this is same case as with duplicated id's for mt76x0u and
mt76x2u. We should not remove the IDs. I will just post patches that
will check chip version.
Stanislaw
prev parent reply other threads:[~2019-03-07 10:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 18:33 mediatek: duplicate usb devices Xose Vazquez Perez
2019-03-06 5:14 ` Kalle Valo
2019-03-06 7:50 ` Stanislaw Gruszka
2019-03-06 9:16 ` Lorenzo Bianconi
2019-03-06 10:09 ` Lorenzo Bianconi
2019-03-06 11:03 ` Stanislaw Gruszka
2019-03-06 18:42 ` Jakub Kicinski
2019-03-07 10:21 ` Stanislaw Gruszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190307102120.GA18424@redhat.com \
--to=sgruszka@redhat.com \
--cc=kubakici@wp.pl \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=lorenzo@kernel.org \
--cc=nbd@nbd.name \
--cc=ulli.kroll@googlemail.com \
--cc=xose.vazquez@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.