All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: David Marchand <david.marchand@redhat.com>,
	Bruce Richardson <bruce.richardson@intel.com>,
	Luca Boccassi <bluca@debian.org>
Subject: [PATCH v2 3/4] build: move meson version handling to config directory
Date: Thu,  7 Mar 2019 13:35:01 +0000	[thread overview]
Message-ID: <20190307133502.55321-4-bruce.richardson@intel.com> (raw)
In-Reply-To: <20190307133502.55321-1-bruce.richardson@intel.com>

To keep the top-level meson.build file as clean and clear as
possible, we move the version handling - which was originally short
but now is a lot longer - to the config/meson.build file, where the
rest of the build configuration is already being set up.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Luca Boccassi <bluca@debian.org>
---
V2: No changes, added Luca's ack
---
 config/meson.build | 26 ++++++++++++++++++++++++++
 meson.build        | 26 --------------------------
 2 files changed, 26 insertions(+), 26 deletions(-)

diff --git a/config/meson.build b/config/meson.build
index 0419607d3..bbe17c786 100644
--- a/config/meson.build
+++ b/config/meson.build
@@ -1,6 +1,32 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Intel Corporation
 
+# set the major version, which might be used by drivers and libraries
+# depending on the configuration options
+pver = meson.project_version().split('.')
+major_version = '@0@.@1@'.format(pver.get(0), pver.get(1))
+
+# extract all version information into the build configuration
+dpdk_conf.set('RTE_VER_YEAR', pver.get(0))
+dpdk_conf.set('RTE_VER_MONTH', pver.get(1))
+if pver.get(2).contains('-rc')
+	rc_ver = pver.get(2).split('-rc')
+	dpdk_conf.set('RTE_VER_MINOR', rc_ver.get(0))
+	dpdk_conf.set_quoted('RTE_VER_SUFFIX', '-rc')
+	dpdk_conf.set('RTE_VER_RELEASE', rc_ver.get(1))
+else
+	dpdk_conf.set('RTE_VER_MINOR', pver.get(2))
+	dpdk_conf.set_quoted('RTE_VER_SUFFIX', '')
+	dpdk_conf.set('RTE_VER_RELEASE', 0)
+endif
+
+pmd_subdir_opt = get_option('drivers_install_subdir')
+if pmd_subdir_opt.contains('<VERSION>')
+	pmd_subdir_opt = major_version.join(pmd_subdir_opt.split('<VERSION>'))
+endif
+driver_install_path = join_paths(get_option('libdir'), pmd_subdir_opt)
+eal_pmd_path = join_paths(get_option('prefix'), driver_install_path)
+
 # set the machine type and cflags for it
 if meson.is_cross_build()
 	machine = host_machine.cpu()
diff --git a/meson.build b/meson.build
index 9fefa1b75..9fba06767 100644
--- a/meson.build
+++ b/meson.build
@@ -19,32 +19,6 @@ dpdk_drivers = []
 dpdk_extra_ldflags = []
 dpdk_app_link_libraries = []
 
-# set the major version, which might be used by drivers and libraries
-# depending on the configuration options
-pver = meson.project_version().split('.')
-major_version = '@0@.@1@'.format(pver.get(0), pver.get(1))
-
-# extract all version information into the build configuration
-dpdk_conf.set('RTE_VER_YEAR', pver.get(0))
-dpdk_conf.set('RTE_VER_MONTH', pver.get(1))
-if pver.get(2).contains('-rc')
-	rc_ver = pver.get(2).split('-rc')
-	dpdk_conf.set('RTE_VER_MINOR', rc_ver.get(0))
-	dpdk_conf.set_quoted('RTE_VER_SUFFIX', '-rc')
-	dpdk_conf.set('RTE_VER_RELEASE', rc_ver.get(1))
-else
-	dpdk_conf.set('RTE_VER_MINOR', pver.get(2))
-	dpdk_conf.set_quoted('RTE_VER_SUFFIX', '')
-	dpdk_conf.set('RTE_VER_RELEASE', 0)
-endif
-
-pmd_subdir_opt = get_option('drivers_install_subdir')
-if pmd_subdir_opt.contains('<VERSION>')
-	pmd_subdir_opt = major_version.join(pmd_subdir_opt.split('<VERSION>'))
-endif
-driver_install_path = join_paths(get_option('libdir'), pmd_subdir_opt)
-eal_pmd_path = join_paths(get_option('prefix'), driver_install_path)
-
 # configure the build, and make sure configs here and in config folder are
 # able to be included in any file. We also store a global array of include dirs
 # for passing to pmdinfogen scripts
-- 
2.20.1

  parent reply	other threads:[~2019-03-07 13:35 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-07 11:54 [RFC PATCH 0/4] One versionfile to rule them all Bruce Richardson
2019-03-07 11:54 ` [PATCH 1/4] build: add single source of DPDK version number Bruce Richardson
2019-03-07 12:33   ` David Marchand
2019-03-07 11:54 ` [PATCH 2/4] build: use version number from config file Bruce Richardson
2019-03-07 12:37   ` David Marchand
2019-03-07 12:42     ` David Marchand
2019-03-07 13:12       ` Bruce Richardson
2019-03-07 13:01     ` Bruce Richardson
2019-03-07 11:54 ` [PATCH 3/4] build: move meson version handling to config directory Bruce Richardson
2019-03-07 11:54 ` [PATCH 4/4] eal: remove unneeded version logic Bruce Richardson
2019-03-07 12:09 ` [RFC PATCH 0/4] One versionfile to rule them all Luca Boccassi
2019-03-07 12:14   ` Bruce Richardson
2019-03-07 13:34 ` [PATCH v2 " Bruce Richardson
2019-03-07 13:34   ` [PATCH v2 1/4] build: add single source of DPDK version number Bruce Richardson
2019-03-13 11:06     ` Thomas Monjalon
2019-03-13 11:17       ` Bruce Richardson
2019-03-13 11:23         ` Thomas Monjalon
2019-03-13 11:27           ` Bruce Richardson
2019-03-07 13:35   ` [PATCH v2 2/4] build: use version number from config file Bruce Richardson
2019-03-13 11:13     ` Thomas Monjalon
2019-03-13 11:20       ` Bruce Richardson
2019-03-13 11:24         ` Thomas Monjalon
2019-03-07 13:35   ` Bruce Richardson [this message]
2019-03-07 13:35   ` [PATCH v2 4/4] eal: remove unneeded version logic Bruce Richardson
2019-03-15 18:20 ` [PATCH v3 0/4] One versionfile to rule them all Bruce Richardson
2019-03-15 18:20   ` [PATCH v3 1/4] build: add single source of DPDK version number Bruce Richardson
2019-03-16 18:01     ` Rami Rosen
2019-03-15 18:20   ` [PATCH v3 2/4] build: move meson version handling to config directory Bruce Richardson
2019-03-15 18:20   ` [PATCH v3 3/4] build: use version number from config file Bruce Richardson
2019-03-27  0:27     ` Thomas Monjalon
2019-03-15 18:20   ` [PATCH v3 4/4] eal: remove unneeded version logic Bruce Richardson
2019-03-27  0:34   ` [PATCH v3 0/4] One versionfile to rule them all Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190307133502.55321-4-bruce.richardson@intel.com \
    --to=bruce.richardson@intel.com \
    --cc=bluca@debian.org \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.