All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ismael Luceno Cortes <ismael.luceno@silicon-gears.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 6/6] ARM: rmobile: Sync Gen3 defconfigs
Date: Thu, 7 Mar 2019 14:47:23 +0000	[thread overview]
Message-ID: <20190307144723.GC8143@kiki> (raw)
In-Reply-To: <CAK7LNATEauLfypgMoHkUmgdCSWHpHzfSXd4VdTzww3Z9cnRxAg@mail.gmail.com>

On 07/Mar/2019 22:54, Masahiro Yamada wrote:
<...>
> Each defconfig supports multiple boards
> by using a different DEVICE_TREE.
> 
> If you are interested, doc/README.uniphier
> explains it supports much more boards than defconfig.
> 
> The drawback of this ways will increase the image size
> since it needs to compile-in all necessary
> boot-code and drivers.
> So, this solution only works when you have enough
> memory footprint.
> 
> 
> > >
> > > I'd still like to be able to do "make soc_board_defconfig ; make"
> > > without having to rack my brain which other .cfg files I need to append.
> > > I didn't find a good solution for this however. Do you know of one ?
> 
> One idea might be,
> to hack scripts/kconfig/Makefile
> to allow a defconfig to contain shell scripts.
> 
> 
> For example, r8a7795_salvator-x_defconfig will look like:
> 
>   #!/bin/sh
>   $MAKE r8a7795_defconfig
>   $MAKE r8a7795_salvator-x.config
> 
> 
> Makefile will run it if the first line is shebang,
> otherwise handle it as a normal defconfig.
> 
> 
> I am not so sure if this is the right thing to do.
> So, it should be discussed widely anyway if we try to
> introduce something new.
> 
> A problem in this way is, as Eugeniu pointed out,
> we have no way to sync .config fragment files.
> 
> 
> > I think we have proper tools to track the correctness of the defconfig
> > files (i.e. savedefconfig Kbuild target), but we don't seem to have
> > proper tools to validate configuration fragments. So, I agree the
> > contents of the fragments would potentially go wild. I think having
> > either a built-in Kbuild/Kconfig procedure or some scripted way to keep
> > the fragments under control would greatly increase the confidence in
> > using them, but I am unaware of such.
> 
> You are right.
> 
> We will need something like savedefconfig for .config files,
> but we do not have a good tool. At least, I do not know.

Perhaps a simpler solution would be to add support for some sort of
selection mechanism. E.g.:

family_defconfig:

	A=y if (SOC in {"A", "B", "C"})

board_A.config:

	SOC="C"

So that .config files can contain only simple meta-data; and both things
would be easy to validate.

There's a little impedance mismatch here and there, but it could work,
and the needed effort seems reasonable.

  reply	other threads:[~2019-03-07 14:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-18 13:05 [U-Boot] [PATCH 1/6] ARM: rmobile: Imply clock drivers per SoC Marek Vasut
2019-02-18 13:05 ` [U-Boot] [PATCH 2/6] ARM: rmobile: Imply pinctrl " Marek Vasut
2019-02-18 13:05 ` [U-Boot] [PATCH 3/6] clk: rmobile: Drop def_bool " Marek Vasut
2019-02-18 13:05 ` [U-Boot] [PATCH 4/6] pinctrl: renesas: " Marek Vasut
2019-02-18 13:05 ` [U-Boot] [PATCH 5/6] ARM: rmobile: Imply SoC per board Marek Vasut
2019-02-18 13:05 ` [U-Boot] [PATCH 6/6] ARM: rmobile: Sync Gen3 defconfigs Marek Vasut
2019-03-04 21:36   ` Eugeniu Rosca
2019-03-04 22:03     ` Marek Vasut
2019-03-04 23:40       ` Eugeniu Rosca
2019-03-05  3:36         ` Marek Vasut
2019-03-07 13:54         ` Masahiro Yamada
2019-03-07 14:47           ` Ismael Luceno Cortes [this message]
2019-03-07 20:21           ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190307144723.GC8143@kiki \
    --to=ismael.luceno@silicon-gears.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.