From: Nathan Chancellor <natechancellor@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Linus Walleij <linus.walleij@linaro.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mmc: davinci: remove extraneous __init annotation
Date: Thu, 7 Mar 2019 08:21:18 -0700 [thread overview]
Message-ID: <20190307152118.GE20201@archlinux-ryzen> (raw)
In-Reply-To: <20190307101024.594587-1-arnd@arndb.de>
On Thu, Mar 07, 2019 at 11:10:11AM +0100, Arnd Bergmann wrote:
> Building with clang finds a mistaken __init tag:
>
> WARNING: vmlinux.o(.text+0x5e4250): Section mismatch in reference from the function davinci_mmcsd_probe() to the function .init.text:init_mmcsd_host()
> The function davinci_mmcsd_probe() references
> the function __init init_mmcsd_host().
> This is often because davinci_mmcsd_probe lacks a __init
> annotation or the annotation of init_mmcsd_host is wrong.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
> ---
> drivers/mmc/host/davinci_mmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c
> index 49e0daf2ef5e..f37003df1e01 100644
> --- a/drivers/mmc/host/davinci_mmc.c
> +++ b/drivers/mmc/host/davinci_mmc.c
> @@ -1117,7 +1117,7 @@ static inline void mmc_davinci_cpufreq_deregister(struct mmc_davinci_host *host)
> {
> }
> #endif
> -static void __init init_mmcsd_host(struct mmc_davinci_host *host)
> +static void init_mmcsd_host(struct mmc_davinci_host *host)
> {
>
> mmc_davinci_reset_ctrl(host, 1);
> --
> 2.20.0
>
next prev parent reply other threads:[~2019-03-07 15:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 10:10 [PATCH] mmc: davinci: remove extraneous __init annotation Arnd Bergmann
2019-03-07 10:13 ` Wolfram Sang
2019-03-07 15:21 ` Nathan Chancellor [this message]
2019-03-18 10:51 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190307152118.GE20201@archlinux-ryzen \
--to=natechancellor@gmail.com \
--cc=arnd@arndb.de \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ndesaulniers@google.com \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.