Re: [Outreachy kernel] [PATCH] Staging: vt6655: Remove an unused function

[Madhumthia Prabakaran <madhumithabiw@gmail.com>]

On Thu, Mar 07, 2019 at 02:21:40PM +0100, Julia Lawall wrote:
> 
> 
> On Thu, 7 Mar 2019, Madhumitha Prabakaran wrote:
> 
> > Remove an unused function to improve codebase.
> >
> > Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
> > ---
> >  drivers/staging/vt6655/mac.h | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/staging/vt6655/mac.h b/drivers/staging/vt6655/mac.h
> > index 99de843b4551..59538ac09fc5 100644
> > --- a/drivers/staging/vt6655/mac.h
> > +++ b/drivers/staging/vt6655/mac.h
> > @@ -887,8 +887,6 @@ void MACvSetShortRetryLimit(struct vnt_private *priv,
> >  			    unsigned char byRetryLimit);
> >
> >  void MACvSetLongRetryLimit(struct vnt_private *priv, unsigned char byRetryLimit);
> > -void MACvGetLongRetryLimit(struct vnt_private *priv,
> > -			   unsigned char *pbyRetryLimit);
> 
> This is the prototype of a function.  Is there a definition somewhere?  If
> so, it would be good to remove the definition at the same time.
> 
> julia
> 
> >
> >  void MACvSetLoopbackMode(struct vnt_private *priv, unsigned char byLoopbackMode);
> >
> > --
> > 2.17.1
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190307124236.20430-1-madhumithabiw%40gmail.com.
> > For more options, visit https://groups.google.com/d/optout.
> >

There is no function definition in the code base. Do you I need to edit the commit log and resend it.

?