From: Greg KH <greg@kroah.com>
To: Daniela Mormocea <daniela.mormocea@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] staging: speakup: Fix NULL comparison warning
Date: Thu, 7 Mar 2019 21:05:11 +0100 [thread overview]
Message-ID: <20190307200511.GA7554@kroah.com> (raw)
In-Reply-To: <1551876162-1333-1-git-send-email-daniela.mormocea@gmail.com>
On Wed, Mar 06, 2019 at 02:42:42PM +0200, Daniela Mormocea wrote:
> Replace NULL comparison with '!' operator as indicated
> by checkpatch
>
> Signed-off-by: Daniela Mormocea <daniela.mormocea@gmail.com>
> ---
> drivers/staging/speakup/spk_ttyio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/speakup/spk_ttyio.c b/drivers/staging/speakup/spk_ttyio.c
> index 0057eb9..5a9eff0 100644
> --- a/drivers/staging/speakup/spk_ttyio.c
> +++ b/drivers/staging/speakup/spk_ttyio.c
> @@ -47,7 +47,7 @@ static int spk_ttyio_ldisc_open(struct tty_struct *tty)
> {
> struct spk_ldisc_data *ldisc_data;
>
> - if (tty->ops->write == NULL)
> + if (!tty->ops->write)
> return -EOPNOTSUPP;
> speakup_tty = tty;
>
Someone already sent this same fix to the same file just before you did,
sorry.
greg k-h
prev parent reply other threads:[~2019-03-07 20:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-06 12:42 [PATCH] staging: speakup: Fix NULL comparison warning Daniela Mormocea
2019-03-07 20:05 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190307200511.GA7554@kroah.com \
--to=greg@kroah.com \
--cc=daniela.mormocea@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.