From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH/next 1/1] package/log4cplus: add optional qt5 dependency
Date: Thu, 7 Mar 2019 23:13:11 +0100 [thread overview]
Message-ID: <20190307231311.463320c2@windsurf> (raw)
In-Reply-To: <20190303101252.3374-1-fontaine.fabrice@gmail.com>
Hello Fabrice,
On Sun, 3 Mar 2019 11:12:52 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/log4cplus/log4cplus.mk | 7 +++++++
> 1 file changed, 7 insertions(+)
Thanks, I've applied, with one minor change, see below.
> diff --git a/package/log4cplus/log4cplus.mk b/package/log4cplus/log4cplus.mk
> index 0bc4fc9aa6..b632066de1 100644
> --- a/package/log4cplus/log4cplus.mk
> +++ b/package/log4cplus/log4cplus.mk
> @@ -11,6 +11,13 @@ LOG4CPLUS_LICENSE = Apache-2.0, BSD-2-Clause, BSD-like (threadpool)
> LOG4CPLUS_LICENSE_FILES = LICENSE
> LOG4CPLUS_INSTALL_STAGING = YES
>
> +ifeq ($(BR2_PACKAGE_QT5),y)
I've changed to use BR2_PACKAGE_QT5BASE here. Obviously, it's
functionally exactly the same, because BR2_PACKAGE_QT5 selects
BR2_PACKAGE_QT5BASE. However, because we add qt5base to the
DEPENDENCIES variable below, I found it more consistent to check for
this specific package being enabled.
> +LOG4CPLUS_DEPENDENCIES += host-pkgconf qt5base
> +LOG4CPLUS_CONF_OPTS += --with-qt5
> +else
> +LOG4CPLUS_CONF_OPTS += --without-qt5
> +endif
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-03-07 22:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-03 10:12 [Buildroot] [PATCH/next 1/1] package/log4cplus: add optional qt5 dependency Fabrice Fontaine
2019-03-07 22:13 ` Thomas Petazzoni [this message]
2019-03-25 16:19 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190307231311.463320c2@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.