All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Wentao Cai <etsai042@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [PATCH v3 1/4] Staging: most: dim2: Fix SPDX-License-Identifier in errors.h
Date: Fri, 8 Mar 2019 08:04:00 +0100	[thread overview]
Message-ID: <20190308070400.GD17194@kroah.com> (raw)
In-Reply-To: <20190308031013.7952-2-etsai042@gmail.com>

On Thu, Mar 07, 2019 at 07:10:10PM -0800, Wentao Cai wrote:
> Fix the checkpatch.pl warning in drivers/staging/most/dim2/errors.h:
> WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
> 
> Signed-off-by: Wentao Cai <etsai042@gmail.com>
> ---
>  drivers/staging/most/dim2/errors.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/most/dim2/errors.h b/drivers/staging/most/dim2/errors.h
> index 3487510fbd2f..cbbdaaf5c52d 100644
> --- a/drivers/staging/most/dim2/errors.h
> +++ b/drivers/staging/most/dim2/errors.h
> @@ -1,4 +1,4 @@
> -// SPDX-License-Identifier: GPL-2.0
> +/* SPDX-License-Identifier: GPL-2.0+ */

You just changed the license of the file, not good at all :(

Don't do this unless you _really_ like talking to lawyers...

thanks,

greg k-h


  parent reply	other threads:[~2019-03-08  7:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-08  3:10 [PATCH v3 0/4] Fix malformed SPDX-License-Identifier Wentao Cai
2019-03-08  3:10 ` [PATCH v3 1/4] Staging: most: dim2: Fix SPDX-License-Identifier in errors.h Wentao Cai
2019-03-08  4:30   ` etsai042
2019-03-08  7:29     ` [Outreachy kernel] " Julia Lawall
2019-03-09  7:01       ` etsai042
2019-03-08  7:04   ` Greg KH [this message]
2019-03-09  6:57     ` etsai042
2019-03-08  7:06   ` Greg KH
2019-03-08  7:05 ` [PATCH v3 0/4] Fix malformed SPDX-License-Identifier Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190308070400.GD17194@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=etsai042@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.